Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722784361 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722780881 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

[jira] [Commented] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875059#comment-17875059 ] Matthias Pohl commented on FLINK-36099: --- actually, looking into it once more: we c

[jira] [Created] (FLINK-36107) schema event support custom callback

2024-08-19 Thread melin (Jira)
melin created FLINK-36107: - Summary: schema event support custom callback Key: FLINK-36107 URL: https://issues.apache.org/jira/browse/FLINK-36107 Project: Flink Issue Type: Improvement Comp

[jira] [Updated] (FLINK-36106) t_flink_autoscaler_event_handler is not cleaned after each testing

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36106: --- Labels: pull-request-available (was: ) > t_flink_autoscaler_event_handler is not cleaned af

[PR] [FLINK-36106][autoscaler] Clean up the t_flink_autoscaler_event_handler table after each test [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
1996fanrui opened a new pull request, #866: URL: https://github.com/apache/flink-kubernetes-operator/pull/866 ## What is the purpose of the change During review https://github.com/apache/flink-kubernetes-operator/pull/865, I found t_flink_autoscaler_event_handler is not cleaned after

[jira] [Created] (FLINK-36106) t_flink_autoscaler_event_handler is not cleaned after each testing

2024-08-19 Thread Rui Fan (Jira)
Rui Fan created FLINK-36106: --- Summary: t_flink_autoscaler_event_handler is not cleaned after each testing Key: FLINK-36106 URL: https://issues.apache.org/jira/browse/FLINK-36106 Project: Flink Iss

[jira] [Created] (FLINK-36105) CDC pipeline job could not restore from state in Flink 1.20

2024-08-19 Thread yux (Jira)
yux created FLINK-36105: --- Summary: CDC pipeline job could not restore from state in Flink 1.20 Key: FLINK-36105 URL: https://issues.apache.org/jira/browse/FLINK-36105 Project: Flink Issue Type: Improv

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722703716 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722700692 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

Re: [PR] [hotfix][API/DataStream] Log the right syncDurationMillis time [flink]

2024-08-19 Thread via GitHub
flinkbot commented on PR #25220: URL: https://github.com/apache/flink/pull/25220#issuecomment-2297949339 ## CI report: * 37d7af085598fa515b28219383b39555b3b1cdfc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36081][cdc-base][mysql] Fix that MySQL source connector missing some columns data of newly added tables [flink-cdc]

2024-08-19 Thread via GitHub
kevinwangcs commented on code in PR #3548: URL: https://github.com/apache/flink-cdc/pull/3548#discussion_r1722665872 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java: ###

[jira] [Comment Edited] (FLINK-36097) Add timeseries support for SampleSplitter

2024-08-19 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875043#comment-17875043 ] Jiabao Sun edited comment on FLINK-36097 at 8/20/24 4:15 AM: -

[jira] [Commented] (FLINK-36097) Add timeseries support for SampleSplitter

2024-08-19 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875043#comment-17875043 ] Jiabao Sun commented on FLINK-36097: The avgObjSize is also returned from the `$coll

[jira] [Updated] (FLINK-36097) Add timeseries support for SampleSplitter

2024-08-19 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-36097: --- Priority: Minor (was: Major) > Add timeseries support for SampleSplitter >

[jira] [Updated] (FLINK-36097) Add timeseries support for SampleSplitter

2024-08-19 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-36097: --- Fix Version/s: (was: mongodb-1.3.0) > Add timeseries support for SampleSplitter > --

[PR] [hotfix][API/DataStream] Log the right syncDurationMillis time [flink]

2024-08-19 Thread via GitHub
Myracle opened a new pull request, #25220: URL: https://github.com/apache/flink/pull/25220 ## What is the purpose of the change *Fix the wrong log info for the var syncDurationMillis.* ## Brief change log - *Move the set function before the log so that the var syncD

Re: [PR] [FLINK-36081][cdc-base][mysql] Fix that MySQL source connector missing some columns data of newly added tables [flink-cdc]

2024-08-19 Thread via GitHub
ruanhang1993 commented on code in PR #3548: URL: https://github.com/apache/flink-cdc/pull/3548#discussion_r1722636805 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java: ##

Re: [PR] [FLINK-36063][runtime] Migrate StreamGraph and its related classes from flink-streaming-java to flink-runtime. [flink]

2024-08-19 Thread via GitHub
flinkbot commented on PR #25219: URL: https://github.com/apache/flink/pull/25219#issuecomment-2297888248 ## CI report: * 4a0efe682055dd98d2cab7a11a7c4a0f72525448 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36063) Migrate StreamGraph and its related classes to flink-runtime

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36063: --- Labels: pull-request-available (was: ) > Migrate StreamGraph and its related classes to fli

[PR] [FLINK-36063][runtime] Migrate StreamGraph and its related classes from flink-streaming-java to flink-runtime. [flink]

2024-08-19 Thread via GitHub
JunRuiLee opened a new pull request, #25219: URL: https://github.com/apache/flink/pull/25219 ## What is the purpose of the change Migrate StreamGraph and its related classes from flink-streaming-java to flink-runtime. ## Brief change log Migrate StreamGraph and i

[jira] [Created] (FLINK-36104) flink 1.20 not suport logback

2024-08-19 Thread xuhaiLong (Jira)
xuhaiLong created FLINK-36104: - Summary: flink 1.20 not suport logback Key: FLINK-36104 URL: https://issues.apache.org/jira/browse/FLINK-36104 Project: Flink Issue Type: Bug Components:

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722606639 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

[jira] [Updated] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He updated FLINK-36100: - Description: Flink does not formally support ESCAPE in built-in function LIKE, but in some cases we do

[jira] [Updated] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He updated FLINK-36100: - Description: Flink does not formally support ESCAPE in built-in function LIKE, but in some cases we do

[jira] [Updated] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He updated FLINK-36100: - Description: Flink does not formally support ESCAPE in built-in function LIKE, but in some cases we do

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722589069 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcEventInteractor.java: ## @@ -152,4 +154,53 @@ protected Lis

[jira] [Closed] (FLINK-36102) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He closed FLINK-36102. Resolution: Duplicate > Support ESCAPE in built-in function LIKE formally > --

[jira] [Closed] (FLINK-36101) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He closed FLINK-36101. Resolution: Duplicate > Support ESCAPE in built-in function LIKE formally > --

[jira] [Closed] (FLINK-36103) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan He closed FLINK-36103. Resolution: Duplicate > Support ESCAPE in built-in function LIKE formally > --

[jira] [Created] (FLINK-36103) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
Dylan He created FLINK-36103: Summary: Support ESCAPE in built-in function LIKE formally Key: FLINK-36103 URL: https://issues.apache.org/jira/browse/FLINK-36103 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-36101) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
Dylan He created FLINK-36101: Summary: Support ESCAPE in built-in function LIKE formally Key: FLINK-36101 URL: https://issues.apache.org/jira/browse/FLINK-36101 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-36102) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
Dylan He created FLINK-36102: Summary: Support ESCAPE in built-in function LIKE formally Key: FLINK-36102 URL: https://issues.apache.org/jira/browse/FLINK-36102 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-19 Thread Dylan He (Jira)
Dylan He created FLINK-36100: Summary: Support ESCAPE in built-in function LIKE formally Key: FLINK-36100 URL: https://issues.apache.org/jira/browse/FLINK-36100 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-19 Thread via GitHub
Jiabao-Sun commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1722574780 ## flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemScenarioTest.java: ## @@ -148,31 +147,31 @@ public void simpleWriteTest() th

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-19 Thread via GitHub
Jiabao-Sun commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1722571689 ## flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemFactoryTest.java: ## @@ -22,10 +22,10 @@ import org.junit.jupiter.api.Tes

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-19 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874974#comment-17874974 ] Brad Atcheson commented on FLINK-34023: --- PR posted: https://github.com/apache/flin

[jira] [Updated] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34023: --- Labels: pull-request-available (was: ) > Expose Kinesis client retry config in sink > -

Re: [PR] [FLINK-34023][Connectors/Kinesis] Expose configuration of sink client retries [flink-connector-aws]

2024-08-19 Thread via GitHub
boring-cyborg[bot] commented on PR #156: URL: https://github.com/apache/flink-connector-aws/pull/156#issuecomment-2297304366 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[PR] [FLINK-34023][Connectors/Kinesis] Expose configuration of sink client retries [flink-connector-aws]

2024-08-19 Thread via GitHub
brada opened a new pull request, #156: URL: https://github.com/apache/flink-connector-aws/pull/156 ## Purpose of the change - Expose configuration of sink client retries. - The consumer side already exposes client retry configuration like [flink.shard.getrecords.maxretries](https:

[jira] [Assigned] (FLINK-35939) Do not set empty config values via ConfigUtils#encodeCollectionToConfig

2024-08-19 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky reassigned FLINK-35939: Assignee: Ferenc Csaky > Do not set empty config values via ConfigUtils#encodeCollectionT

[jira] [Closed] (FLINK-35939) Do not set empty config values via ConfigUtils#encodeCollectionToConfig

2024-08-19 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky closed FLINK-35939. Resolution: Fixed [{{e4abd06}}|https://github.com/apache/flink/commit/e4abd0652569a1fdba6e519d88d5

Re: [PR] [FLINK-35939] Do not set empty config values via ConfigUtils#encodeCollectionToConfig [flink]

2024-08-19 Thread via GitHub
ferenc-csaky merged PR #25139: URL: https://github.com/apache/flink/pull/25139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Resolved] (FLINK-35243) Carry pre-schema payload with SchemaChangeEvents

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35243. Resolution: Fixed master: 78fda8b5abb2c2fb038760e238707cc1b7d3cf18 > Carry pre-schema payload wit

[jira] [Assigned] (FLINK-35243) Carry pre-schema payload with SchemaChangeEvents

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35243: -- Assignee: yux > Carry pre-schema payload with SchemaChangeEvents > --

Re: [PR] [FLINK-35243] Extends schema change event types support [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang merged PR #3521: URL: https://github.com/apache/flink-cdc/pull/3521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35243] Extends schema change event types support [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang commented on PR #3521: URL: https://github.com/apache/flink-cdc/pull/3521#issuecomment-2297019201 CI passed, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-19 Thread via GitHub
ferenc-csaky commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1722088247 ## flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriterTest.java: ## @@ -49,12 +48,14 @@ class HadoopRecoverabl

[jira] [Assigned] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as volatile for thread safe.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36076: -- Assignee: Hongshun Wang > Hotfix: Set isSchemaChangeApplying as volatile for thread safe. > -

[jira] [Commented] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as volatile for thread safe.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874940#comment-17874940 ] Leonard Xu commented on FLINK-36076: master: d3473de4db92229eb09e1e4c698a2db5448c880

[jira] [Updated] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as volatile for thread safe.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36076: --- Issue Type: Technical Debt (was: Improvement) > Hotfix: Set isSchemaChangeApplying as volatile for

[jira] [Commented] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as volatile for thread safe.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874939#comment-17874939 ] Leonard Xu commented on FLINK-36076: Assigned to you [~loserwang1024]  > Hotfix: Se

Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang merged PR #3556: URL: https://github.com/apache/flink-cdc/pull/3556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Commented] (FLINK-36088) Fix NPE in PaimonDataSink.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874938#comment-17874938 ] Leonard Xu commented on FLINK-36088: master: 7f08c6caba082915b9684ea384363f1df85dab8

[jira] [Updated] (FLINK-36088) Fix NPE in PaimonDataSink.

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36088: --- Summary: Fix NPE in PaimonDataSink. (was: Fix NopointException in PaimonDataSink.) > Fix NPE in Pa

[jira] [Updated] (FLINK-36088) Fix NopointException in PaimonDataSink.

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36088: --- Labels: pull-request-available (was: ) > Fix NopointException in PaimonDataSink. >

Re: [PR] [FLINK-36088][pipeline-connector][paimon] Fix NullPointerException in BucketAssignOperator. [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang merged PR #3553: URL: https://github.com/apache/flink-cdc/pull/3553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2024-08-19 Thread via GitHub
flinkbot commented on PR #25218: URL: https://github.com/apache/flink/pull/25218#issuecomment-2296958166 ## CI report: * 90f8ef20aa29744816e5fe35609ffda84fd44da7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33977) Adaptive scheduler may not minimize the number of TMs during downscaling

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33977: --- Labels: pull-request-available (was: ) > Adaptive scheduler may not minimize the number of

[PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2024-08-19 Thread via GitHub
RocMarshal opened a new pull request, #25218: URL: https://github.com/apache/flink/pull/25218 ## What is the purpose of the change [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling ## Brief change log - Migrate th

[jira] [Comment Edited] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874919#comment-17874919 ] Matthias Pohl edited comment on FLINK-36099 at 8/19/24 3:47 PM: --

[jira] [Commented] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874919#comment-17874919 ] Matthias Pohl commented on FLINK-36099: --- @roman I guess that's a log message that

[jira] [Comment Edited] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874919#comment-17874919 ] Matthias Pohl edited comment on FLINK-36099 at 8/19/24 3:44 PM: --

[jira] [Updated] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36099: -- Labels: test-stability (was: ) > JobIDLoggingITCase fails due to "Cannot find task to fail fo

[jira] [Updated] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36099: -- Description: {{JobIDLoggingITCase}} can fail (observed with the {{AdaptiveScheduler}} enabled

[jira] [Created] (FLINK-36099) JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs

2024-08-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-36099: - Summary: JobIDLoggingITCase fails due to "Cannot find task to fail for execution [...]" info log message in TM logs Key: FLINK-36099 URL: https://issues.apache.org/jira/browse/F

Re: [PR] [FLINK-36083][docs] Fix kafka table api doc's Connector Options table broken [flink-connector-kafka]

2024-08-19 Thread via GitHub
GOODBOY008 commented on PR #112: URL: https://github.com/apache/flink-connector-kafka/pull/112#issuecomment-2296881530 @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Created] (FLINK-36098) Add support for Table Comments in Flink SQL ALTER TABLE statements

2024-08-19 Thread Steffen Hoellinger (Jira)
Steffen Hoellinger created FLINK-36098: -- Summary: Add support for Table Comments in Flink SQL ALTER TABLE statements Key: FLINK-36098 URL: https://issues.apache.org/jira/browse/FLINK-36098 Projec

Re: [PR] [FLINK-36092] Let schema evolve work with transform [flink-cdc]

2024-08-19 Thread via GitHub
yuxiqian commented on PR #3557: URL: https://github.com/apache/flink-cdc/pull/3557#issuecomment-2296839736 Considering this is blocking users from using schema evolution with transform blocks, could @leonardBang @aiwenmo please take a look? -- This is an automated message from the Apache

[jira] [Updated] (FLINK-36092) Transform doesn't fully support with schema evolution

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36092: --- Labels: pull-request-available (was: ) > Transform doesn't fully support with schema evolut

[PR] [FLINK-36092] Let schema evolve work with transform [flink-cdc]

2024-08-19 Thread via GitHub
yuxiqian opened a new pull request, #3557: URL: https://github.com/apache/flink-cdc/pull/3557 Currently, transform doesn't work very well with schema evolution. The main issue is that TransformOperator (including Pre- and Post-) simply passes all upstream schema change events to downs

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-19 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1721961659 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowProceduresOperation.java: ## @@ -65,7 +65,7 @@ protected Collection retrieveD

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-19 Thread via GitHub
flinkbot commented on PR #25217: URL: https://github.com/apache/flink/pull/25217#issuecomment-2296778734 ## CI report: * e9540832f77e74d5e7efdfdb11b1ee4647e18390 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36095) KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering

2024-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36095: --- Labels: pull-request-available (was: ) > KeyedLookupJoinWrapper should shuffle by input ups

[PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-19 Thread via GitHub
lincoln-lil opened a new pull request, #25217: URL: https://github.com/apache/flink/pull/25217 ## What is the purpose of the change If user encounter the NDU issue caused by a lookup join and enable the [TRY_RESOLVE mode](https://nightlies.apache.org/flink/flink-docs-master/docs/dev/tabl

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1721835512 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java: ## @@ -219,64 +240,205 @@ private v

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1721835078 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java: ## @@ -219,64 +240,205 @@ private v

Re: [PR] [Mysql Pipline] Support mysql pipline rate limit [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang commented on PR #3547: URL: https://github.com/apache/flink-cdc/pull/3547#issuecomment-2296584623 Thanks @gaoyan1998 for the contribution, FLIP 27 Source API also has a basic rate limiting design, Would you consider develop base on that one? -- This is an automated message fr

Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang commented on code in PR #3556: URL: https://github.com/apache/flink-cdc/pull/3556#discussion_r1721785897 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java: ## @@ -94,7 +94,7 @@ public class

Re: [PR] [FLINK-36082][pipeline-connector][kafka] fix NotSerializableException for KafkaDataSink. [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang merged PR #3549: URL: https://github.com/apache/flink-cdc/pull/3549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Commented] (FLINK-36082) Fix NotSerializableException for KafkaDataSink

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874876#comment-17874876 ] Leonard Xu commented on FLINK-36082: master: 0470fdbbc13a4281083488274e891a74cc8e81a

[jira] [Assigned] (FLINK-36086) SQL Server source connector skips changes if restarted mid transaction

2024-08-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36086: -- Assignee: Sergei Morozov > SQL Server source connector skips changes if restarted mid transac

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-19 Thread via GitHub
kottmann commented on PR #22789: URL: https://github.com/apache/flink/pull/22789#issuecomment-2296533731 Thanks, I rebased it onto master and it should be possible to merge now. Some classes received a bit of JUnit 5 migration from another commit before, and I resolved those conflicts or re

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-19 Thread via GitHub
kottmann commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1721750114 ## flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriterTest.java: ## @@ -49,12 +48,14 @@ class HadoopRecoverableWri

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-19 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1721682664 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowViewsConverter.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-19 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1721681790 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/AbstractSqlShowConverter.java: ## @@ -0,0 +1,73 @@ +/* + * Licen

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-19 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1721673717 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowProceduresOperation.java: ## @@ -20,130 +20,83 @@ import org.apache.flink.a

[jira] [Created] (FLINK-36097) Add timeseries support for SampleSplitter

2024-08-19 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-36097: -- Summary: Add timeseries support for SampleSplitter Key: FLINK-36097 URL: https://issues.apache.org/jira/browse/FLINK-36097 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-19 Thread via GitHub
vahmed-hamdy commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1721636724 ## flink-catalog-aws/flink-catalog-aws-glue/src/test/java/org/apache/flink/table/catalog/glue/TypeMapperTest.java: ## @@ -0,0 +1,91 @@ +package org.apache

Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]

2024-08-19 Thread via GitHub
leonardBang commented on PR #3556: URL: https://github.com/apache/flink-cdc/pull/3556#issuecomment-2296334567 The PR title and commit content confuse me a little, @loserwang1024 could you check your PR ? -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Assigned] (FLINK-36096) Add synchronous interfaces for State V2 API.

2024-08-19 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-36096: --- Assignee: wang qian > Add synchronous interfaces for State V2 API. > --

[jira] [Updated] (FLINK-36096) Add synchronous interfaces for State V2 API.

2024-08-19 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-36096: Priority: Major (was: Minor) > Add synchronous interfaces for State V2 API. > ---

[jira] [Updated] (FLINK-36096) Add synchronous interfaces for State V2 API.

2024-08-19 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-36096: Parent: FLINK-34974 Issue Type: Sub-task (was: Improvement) > Add synchronous interfaces

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-19 Thread via GitHub
vahmed-hamdy commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1720828696 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/factory/GlueCatalogFactory.java: ## @@ -0,0 +1,80 @@ +/* + *

[jira] [Assigned] (FLINK-36094) CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException

2024-08-19 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang reassigned FLINK-36094: - Assignee: Hongshun Wang > CDC SchemaRegistryRequestHandler should throw exception which is not

[jira] [Updated] (FLINK-36096) Support sync interface in state v2 api.

2024-08-19 Thread wang qian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wang qian updated FLINK-36096: -- Description: Add synchronous interfaces for State V2 API. (was: Add ) > Support sync interface in sta

[jira] [Updated] (FLINK-36096) Add synchronous interfaces for State V2 API.

2024-08-19 Thread wang qian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wang qian updated FLINK-36096: -- Summary: Add synchronous interfaces for State V2 API. (was: Support sync interface in state v2 api.)

[jira] [Updated] (FLINK-36096) Support sync interface in state v2 api.

2024-08-19 Thread wang qian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wang qian updated FLINK-36096: -- Description: Add  > Support sync interface in state v2 api. > ---

[jira] [Created] (FLINK-36096) Support sync interface in state v2 api.

2024-08-19 Thread wang qian (Jira)
wang qian created FLINK-36096: - Summary: Support sync interface in state v2 api. Key: FLINK-36096 URL: https://issues.apache.org/jira/browse/FLINK-36096 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-36095) KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering

2024-08-19 Thread lincoln lee (Jira)
lincoln lee created FLINK-36095: --- Summary: KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering Key: FLINK-36095 URL: https://issues.apache.org/jira/browse/FLIN

  1   2   >