RocMarshal commented on code in PR #865:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722700692
##########
flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java:
##########
@@ -430,6 +446,70 @@ void testScalingEventWithParallelismChange() throws
Exception {
});
}
+ @MethodSource("getExpiredEventHandlersCaseMatrix")
+ @ParameterizedTest
+ void testCleanExpiredEvents(
+ int expiredRecordsNum, Duration eventHandlerTtl, int
unexpiredRecordsNum)
+ throws Exception {
+ try (Connection con = getConnection();
+ PreparedStatement ps =
+ con.prepareStatement("delete from
t_flink_autoscaler_event_handler")) {
+ ps.execute();
+ }
Review Comment:
Here would be some data resulted by the parameterized test running due to
the shared database instance.
##########
flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java:
##########
@@ -430,6 +446,70 @@ void testScalingEventWithParallelismChange() throws
Exception {
});
}
+ @MethodSource("getExpiredEventHandlersCaseMatrix")
+ @ParameterizedTest
+ void testCleanExpiredEvents(
+ int expiredRecordsNum, Duration eventHandlerTtl, int
unexpiredRecordsNum)
+ throws Exception {
+ try (Connection con = getConnection();
+ PreparedStatement ps =
+ con.prepareStatement("delete from
t_flink_autoscaler_event_handler")) {
+ ps.execute();
+ }
Review Comment:
IIUC, Here would be some data resulted by the parameterized test running due
to the shared database instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
