brada opened a new pull request, #156: URL: https://github.com/apache/flink-connector-aws/pull/156
## Purpose of the change - Expose configuration of sink client retries. - The consumer side already exposes client retry configuration like [flink.shard.getrecords.maxretries](https://nightlies.apache.org/flink/flink-docs-stable/api/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.html#SHARD_GETRECORDS_RETRIES) but the sink producer side currently lacks similar config for PutRecords. - The AWS SDK has deprecated RetryPolicy in favour of RetryStrategy, meaning that the old "num-retries" config is being replaced with "max-attempts" (which includes the initial attempt) - This PR exposes the most important max-attempt config, but not the complete retry strategy, since representing all the various types of (jittered, linear, exponential etc) strategies with universal config keys is non-trivial. ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing - *Modified existing unit tests* - *Added unit tests* ## Significant changes *(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)* - [ ] Dependencies have been added or upgraded - [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`) - [ ] Serializers have been changed - [X] New feature has been introduced - If yes, how is this documented? (not applicable / docs / JavaDocs / not documented): not documented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
