1996fanrui commented on code in PR #865:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722784361


##########
flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java:
##########
@@ -430,6 +446,70 @@ void testScalingEventWithParallelismChange() throws 
Exception {
                         });
     }
 
+    @MethodSource("getExpiredEventHandlersCaseMatrix")
+    @ParameterizedTest
+    void testCleanExpiredEvents(
+            int expiredRecordsNum, Duration eventHandlerTtl, int 
unexpiredRecordsNum)
+            throws Exception {
+        try (Connection con = getConnection();
+                PreparedStatement ps =
+                        con.prepareStatement("delete from 
t_flink_autoscaler_event_handler")) {
+            ps.execute();
+        }

Review Comment:
   Actually, PostgreSQLExtension and MySQLExtension have `afterEach`, it cleans 
all data.
   
   But they missed `t_flink_autoscaler_event_handler` table. I submitted 
https://github.com/apache/flink-kubernetes-operator/pull/866 to fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to