RocMarshal commented on code in PR #865:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1722703716
##########
flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java:
##########
@@ -430,6 +446,70 @@ void testScalingEventWithParallelismChange() throws
Exception {
});
}
+ @MethodSource("getExpiredEventHandlersCaseMatrix")
+ @ParameterizedTest
+ void testCleanExpiredEvents(
+ int expiredRecordsNum, Duration eventHandlerTtl, int
unexpiredRecordsNum)
Review Comment:
Thanks for comments.
IIUC, Maybe it's accepted, because in the current case, we just want to test
the method `cleanExpiredEvents` of JdbcAutoScalerEventHandler instead of the
whole logic of the `JdbcAutoScalerEventHandler`.
If needed, I'd like to do some change for the stable test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
