[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607931#comment-16607931 ] ASF GitHub Bot commented on FLINK-9567: --- Clark commented on issue #6669: [FLINK

[GitHub] Clarkkkkk commented on issue #6669: [FLINK-9567][runtime][yarn] Fix the yarn container over allocation in…

2018-09-07 Thread GitBox
Clark commented on issue #6669: [FLINK-9567][runtime][yarn] Fix the yarn container over allocation in… URL: https://github.com/apache/flink/pull/6669#issuecomment-419618422 @TisonKun Thank you for your advice. This is an

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607912#comment-16607912 ] ASF GitHub Bot commented on FLINK-7243: --- HuangZhenQiu commented on issue #6483: [FL

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-09-07 Thread GitBox
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-419613742 @lvhuyen Thanks for digging out the root cause. I guess I should pass the logic type into RowPrimitiveConverter. So that dif

[jira] [Commented] (FLINK-10273) Access composite type fields after a function

2018-09-07 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607907#comment-16607907 ] Rong Rong commented on FLINK-10273: --- I found a solution via modifying Calcite {{Parser

[jira] [Commented] (FLINK-10303) Fix critical vulnerabilities Python API

2018-09-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607869#comment-16607869 ] vinoyang commented on FLINK-10303: -- cc [~Zentol] Maybe this issue deserves our attentio

[GitHub] TisonKun commented on issue #6674: [hotfix] [runtime] Remove unused legacy exception class

2018-09-07 Thread GitBox
TisonKun commented on issue #6674: [hotfix] [runtime] Remove unused legacy exception class URL: https://github.com/apache/flink/pull/6674#issuecomment-419529625 cc @zentol @GJL This is an automated message from the Apache Gi

[jira] [Created] (FLINK-10305) flink-conf.yaml grows continuously

2018-09-07 Thread Dimitrije (JIRA)
Dimitrije created FLINK-10305: - Summary: flink-conf.yaml grows continuously Key: FLINK-10305 URL: https://issues.apache.org/jira/browse/FLINK-10305 Project: Flink Issue Type: Bug Re

[jira] [Comment Edited] (FLINK-10298) Batch Job Failover Strategy

2018-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607460#comment-16607460 ] 陈梓立 edited comment on FLINK-10298 at 9/7/18 6:14 PM: - Hi [~isunjin],

[jira] [Comment Edited] (FLINK-10298) Batch Job Failover Strategy

2018-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607460#comment-16607460 ] 陈梓立 edited comment on FLINK-10298 at 9/7/18 6:13 PM: - Hi [~isunjin],

[jira] [Commented] (FLINK-10298) Batch Job Failover Strategy

2018-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607460#comment-16607460 ] 陈梓立 commented on FLINK-10298: - Hi [~isunjin], Thanks for raise this JIRA! After read the do

[jira] [Commented] (FLINK-9964) Add a CSV table format factory

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607420#comment-16607420 ] ASF GitHub Bot commented on FLINK-9964: --- buptljy commented on a change in pull requ

[GitHub] buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-09-07 Thread GitBox
buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r216035112 ## File path: flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDeserializationSchema

[jira] [Commented] (FLINK-9964) Add a CSV table format factory

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607413#comment-16607413 ] ASF GitHub Bot commented on FLINK-9964: --- buptljy commented on a change in pull requ

[GitHub] buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-09-07 Thread GitBox
buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r216034480 ## File path: flink-formats/flink-csv/pom.xml ## @@ -0,0 +1,88 @@ + + +http://maven.apache.org/POM/

[jira] [Commented] (FLINK-9190) YarnResourceManager sometimes does not request new Containers

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607382#comment-16607382 ] ASF GitHub Bot commented on FLINK-9190: --- TisonKun commented on issue #5931: [FLINK-

[GitHub] TisonKun commented on issue #5931: [FLINK-9190][flip6, yarn] Request new container if container completed unexpectedly

2018-09-07 Thread GitBox
TisonKun commented on issue #5931: [FLINK-9190][flip6,yarn] Request new container if container completed unexpectedly URL: https://github.com/apache/flink/pull/5931#issuecomment-419507178 IIRC it is [FLINK-9455](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-9455?filter=allopen

[jira] [Closed] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10242. Resolution: Fixed Release Note: Latency metrics are now disabled by default, which al

[jira] [Reopened] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-10242: -- > Disable latency metrics by default > -- > >

[jira] [Closed] (FLINK-10243) Add option to reduce latency metrics granularity

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10243. Resolution: Fixed Release Note: The default granularity for latency metrics was modif

[jira] [Commented] (FLINK-10243) Add option to reduce latency metrics granularity

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607357#comment-16607357 ] ASF GitHub Bot commented on FLINK-10243: zentol closed pull request #6658: [FLIN

[GitHub] zentol closed pull request #6658: [FLINK-10243][metrics] Make latency metrics granularity configurable

2018-09-07 Thread GitBox
zentol closed pull request #6658: [FLINK-10243][metrics] Make latency metrics granularity configurable URL: https://github.com/apache/flink/pull/6658 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] TisonKun opened a new pull request #6674: [hotfix] [runtime] Remove unused legacy exception class

2018-09-07 Thread GitBox
TisonKun opened a new pull request #6674: [hotfix] [runtime] Remove unused legacy exception class URL: https://github.com/apache/flink/pull/6674 ## What is the purpose of the change Remove unused legacy exception class `SlotException`. This exception class was introduced by a

[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607352#comment-16607352 ] ASF GitHub Bot commented on FLINK-8660: --- tillrohrmann commented on issue #5530: [FL

[GitHub] tillrohrmann commented on issue #5530: [FLINK-8660] Enable the user to provide custom HAServices implementation

2018-09-07 Thread GitBox
tillrohrmann commented on issue #5530: [FLINK-8660] Enable the user to provide custom HAServices implementation URL: https://github.com/apache/flink/pull/5530#issuecomment-419501245 Yes I think we should try to get this PR into 1.7 since it allows to implement your own `HighAvailabilitySer

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607349#comment-16607349 ] ASF GitHub Bot commented on FLINK-9891: --- tillrohrmann commented on issue #6540: [FL

[GitHub] tillrohrmann commented on issue #6540: [FLINK-9891] Added hook to shutdown cluster if a session was created in per-job mode.

2018-09-07 Thread GitBox
tillrohrmann commented on issue #6540: [FLINK-9891] Added hook to shutdown cluster if a session was created in per-job mode. URL: https://github.com/apache/flink/pull/6540#issuecomment-419500426 I like the idea of making this behaviour configurable. @packet23 do you have time to add this f

[jira] [Commented] (FLINK-9190) YarnResourceManager sometimes does not request new Containers

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607348#comment-16607348 ] ASF GitHub Bot commented on FLINK-9190: --- tillrohrmann commented on issue #5931: [FL

[GitHub] tillrohrmann commented on issue #5931: [FLINK-9190][flip6, yarn] Request new container if container completed unexpectedly

2018-09-07 Thread GitBox
tillrohrmann commented on issue #5931: [FLINK-9190][flip6,yarn] Request new container if container completed unexpectedly URL: https://github.com/apache/flink/pull/5931#issuecomment-419500186 Yes at the moment, this could happen. However, the superfluous `TaskManager` should be released af

[jira] [Commented] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607335#comment-16607335 ] ASF GitHub Bot commented on FLINK-10304: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread GitBox
TisonKun commented on a change in pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field URL: https://github.com/apache/flink/pull/6673#discussion_r216017006 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDe

[jira] [Commented] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607332#comment-16607332 ] ASF GitHub Bot commented on FLINK-10304: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread GitBox
TisonKun commented on a change in pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field URL: https://github.com/apache/flink/pull/6673#discussion_r216017006 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDe

[jira] [Commented] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607314#comment-16607314 ] ASF GitHub Bot commented on FLINK-10304: TisonKun opened a new pull request #667

[jira] [Updated] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10304: --- Labels: pull-request-available (was: ) > Remove deprecated AbstractYarnClusterDescriptor fi

[GitHub] TisonKun opened a new pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread GitBox
TisonKun opened a new pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field URL: https://github.com/apache/flink/pull/6673 ## Brief change log Remove deprecated AbstractYarnClusterDescriptor field ## Verifying this change This

[jira] [Created] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

2018-09-07 Thread JIRA
陈梓立 created FLINK-10304: --- Summary: Remove deprecated AbstractYarnClusterDescriptor field Key: FLINK-10304 URL: https://issues.apache.org/jira/browse/FLINK-10304 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-10303) Fix critical vulnerabilities Python API

2018-09-07 Thread Konstantin Knauf (JIRA)
Konstantin Knauf created FLINK-10303: Summary: Fix critical vulnerabilities Python API Key: FLINK-10303 URL: https://issues.apache.org/jira/browse/FLINK-10303 Project: Flink Issue Type: I

[jira] [Closed] (FLINK-10293) RemoteStreamEnvironment does not forward port to RestClusterClient

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10293. Resolution: Fixed master: 2dbd41354dc85b68754cad1777f733ca070eea9a 1.6: d8cc7684f5ffbea782

[jira] [Commented] (FLINK-9964) Add a CSV table format factory

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607236#comment-16607236 ] ASF GitHub Bot commented on FLINK-9964: --- twalthr commented on a change in pull requ

[GitHub] twalthr commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-09-07 Thread GitBox
twalthr commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r215992673 ## File path: flink-formats/flink-csv/pom.xml ## @@ -0,0 +1,88 @@ + + +http://maven.apache.org/POM/

[jira] [Commented] (FLINK-9964) Add a CSV table format factory

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607219#comment-16607219 ] ASF GitHub Bot commented on FLINK-9964: --- zentol commented on a change in pull reque

[GitHub] zentol commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-09-07 Thread GitBox
zentol commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r215989983 ## File path: flink-formats/flink-csv/pom.xml ## @@ -0,0 +1,88 @@ + + +http://maven.apache.org/POM/4

[jira] [Commented] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607217#comment-16607217 ] 陈梓立 commented on FLINK-10302: - Here are some example, their name are quite misleading. {{Jo

[GitHub] zentol commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-09-07 Thread GitBox
zentol commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r215989141 ## File path: flink-formats/flink-csv/pom.xml ## @@ -0,0 +1,88 @@ + + +http://maven.apache.org/POM/4

[jira] [Commented] (FLINK-9964) Add a CSV table format factory

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607214#comment-16607214 ] ASF GitHub Bot commented on FLINK-9964: --- zentol commented on a change in pull reque

[jira] [Created] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-07 Thread JIRA
陈梓立 created FLINK-10302: --- Summary: Mark legacy(non-flip 6) code as Deprecated Key: FLINK-10302 URL: https://issues.apache.org/jira/browse/FLINK-10302 Project: Flink Issue Type: Improvement

[jira] [Resolved] (FLINK-10174) getbytes with no charsets test error for hex and toBase64

2018-09-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-10174. -- Resolution: Fixed Fixed in 1.7.0: 99bf3a5087ac80ff20c8d22adef82f30e53ba568 > getbytes with no

[jira] [Commented] (FLINK-10174) getbytes with no charsets test error for hex and toBase64

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607199#comment-16607199 ] ASF GitHub Bot commented on FLINK-10174: asfgit closed pull request #6579: [FLIN

[GitHub] asfgit closed pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64

2018-09-07 Thread GitBox
asfgit closed pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64 URL: https://github.com/apache/flink/pull/6579 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Commented] (FLINK-10174) getbytes with no charsets test error for hex and toBase64

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607145#comment-16607145 ] ASF GitHub Bot commented on FLINK-10174: xueyumusic commented on a change in pul

[GitHub] xueyumusic commented on a change in pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64

2018-09-07 Thread GitBox
xueyumusic commented on a change in pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64 URL: https://github.com/apache/flink/pull/6579#discussion_r215964734 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/Scala

[jira] [Resolved] (FLINK-10193) Default RPC timeout is used when triggering savepoint via JobMasterGateway

2018-09-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10193. --- Resolution: Fixed Fixed via 1.7.0: bfbcd908bf9b59f64ddf8c783293addc098ee516 1.6.1: 5d93520ae

[jira] [Commented] (FLINK-10193) Default RPC timeout is used when triggering savepoint via JobMasterGateway

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607137#comment-16607137 ] ASF GitHub Bot commented on FLINK-10193: asfgit closed pull request #6601: [FLIN

[GitHub] asfgit closed pull request #6601: [FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint

2018-09-07 Thread GitBox
asfgit closed pull request #6601: [FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint URL: https://github.com/apache/flink/pull/6601 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607122#comment-16607122 ] ASF GitHub Bot commented on FLINK-10281: dawidwys commented on issue #6671: [FLI

[GitHub] dawidwys commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table API

2018-09-07 Thread GitBox
dawidwys commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table API URL: https://github.com/apache/flink/pull/6671#issuecomment-419438925 +1, Looks good from my side. This is an automated message

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-07 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607114#comment-16607114 ] Shimin Yang commented on FLINK-10247: - Hi [~Zentol], sounds good. I am gonna working

[jira] [Assigned] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-07 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimin Yang reassigned FLINK-10247: --- Assignee: Shimin Yang > Run MetricQueryService in separate thread pool > --

[jira] [Commented] (FLINK-10174) getbytes with no charsets test error for hex and toBase64

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607082#comment-16607082 ] ASF GitHub Bot commented on FLINK-10174: twalthr commented on a change in pull r

[GitHub] twalthr commented on a change in pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64

2018-09-07 Thread GitBox
twalthr commented on a change in pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64 URL: https://github.com/apache/flink/pull/6579#discussion_r215946888 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFu

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607069#comment-16607069 ] ASF GitHub Bot commented on FLINK-10281: yanghua commented on issue #6659: [FLIN

[GitHub] yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

2018-09-07 Thread GitBox
yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659#issuecomment-419427295 @twalthr It looks good, in fact I only saw the problem of parsing backslashes in single quotes, be

[jira] [Commented] (FLINK-7964) Add Apache Kafka 1.0/1.1 connectors

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607064#comment-16607064 ] ASF GitHub Bot commented on FLINK-7964: --- yanghua commented on issue #6577: [FLINK-7

[GitHub] yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors

2018-09-07 Thread GitBox
yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors URL: https://github.com/apache/flink/pull/6577#issuecomment-419426033 @pnowojski What do you think I follow @eliaslevy advice based on kafka client 2.0 to provide a connector implementation to verify that s

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607061#comment-16607061 ] ASF GitHub Bot commented on FLINK-10281: twalthr commented on issue #6659: [FLIN

[GitHub] twalthr commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

2018-09-07 Thread GitBox
twalthr commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659#issuecomment-419425099 @yanghua I found more issues related to this topic when testing your code. I fixed it in #6671. Wh

[jira] [Closed] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10242. Resolution: Fixed master: b0522e37181f8485610fd37dda9fc45858b6429e > Disable latency metr

[jira] [Updated] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9523: -- Labels: pull-request-available (was: ) > Add Kafka examples for Flink Table/SQL API > ---

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607053#comment-16607053 ] ASF GitHub Bot commented on FLINK-9523: --- SokolovMS opened a new pull request #6672:

[jira] [Commented] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607054#comment-16607054 ] ASF GitHub Bot commented on FLINK-10242: zentol closed pull request #6656: [FLIN

[jira] [Commented] (FLINK-10300) Prometheus job level metrics not removed after job finished

2018-09-07 Thread Helmut Zechmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607051#comment-16607051 ] Helmut Zechmann commented on FLINK-10300: - Yes, we had the problem with flink 1.

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607052#comment-16607052 ] ASF GitHub Bot commented on FLINK-10281: twalthr opened a new pull request #6671

[GitHub] zentol closed pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default

2018-09-07 Thread GitBox
zentol closed pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default URL: https://github.com/apache/flink/pull/6656 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] SokolovMS opened a new pull request #6672: [FLINK-9523] Add Kafka examples for Flink Table/SQL API

2018-09-07 Thread GitBox
SokolovMS opened a new pull request #6672: [FLINK-9523] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672 ## What is the purpose of the change Implementation of FLINK-9523 ## Brief change log Added an example of using Kafka JSON T

[GitHub] twalthr opened a new pull request #6671: [FLINK-10281] [table] Fix string literal parsing in Table API

2018-09-07 Thread GitBox
twalthr opened a new pull request #6671: [FLINK-10281] [table] Fix string literal parsing in Table API URL: https://github.com/apache/flink/pull/6671 ## What is the purpose of the change This PR fixes the string literal parsing of the Table API. Proper escaping of the quotes was not

[jira] [Commented] (FLINK-10290) Conversion error in StreamScan and BatchScan

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607048#comment-16607048 ] ASF GitHub Bot commented on FLINK-10290: jrthe42 commented on issue #: [FLIN

[GitHub] jrthe42 commented on issue #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-07 Thread GitBox
jrthe42 commented on issue #: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan URL: https://github.com/apache/flink/pull/#issuecomment-419422931 Sorry for the missed checkstyle error, already fixed. @yanghua cc @twalthr ---

[jira] [Commented] (FLINK-10293) RemoteStreamEnvironment does not forward port to RestClusterClient

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607046#comment-16607046 ] ASF GitHub Bot commented on FLINK-10293: zentol closed pull request #6665: [FLIN

[GitHub] zentol closed pull request #6665: [FLINK-10293][streaming] Properly forward REST port for remote environments

2018-09-07 Thread GitBox
zentol closed pull request #6665: [FLINK-10293][streaming] Properly forward REST port for remote environments URL: https://github.com/apache/flink/pull/6665 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[jira] [Commented] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607032#comment-16607032 ] ASF GitHub Bot commented on FLINK-10242: zentol commented on a change in pull re

[GitHub] zentol commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default

2018-09-07 Thread GitBox
zentol commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default URL: https://github.com/apache/flink/pull/6656#discussion_r215938129 ## File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ## @

[GitHub] yanghua commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-07 Thread GitBox
yanghua commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-419417892 @xccui Can you review this PR? This is an automated

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607029#comment-16607029 ] ASF GitHub Bot commented on FLINK-9991: --- yanghua commented on issue #6450: [FLINK-9

[jira] [Commented] (FLINK-10300) Prometheus job level metrics not removed after job finished

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607025#comment-16607025 ] Chesnay Schepler commented on FLINK-10300: -- On the ML you said you were using 1

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607024#comment-16607024 ] ASF GitHub Bot commented on FLINK-10301: zentol commented on a change in pull re

[GitHub] zentol commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-07 Thread GitBox
zentol commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r215934568 ## File path: flink-streaming-java/src/test/java/org/apac

[jira] [Updated] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10301: --- Labels: pull-request-available (was: ) > Allow a custom Configuration in StreamNetworkBench

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607016#comment-16607016 ] ASF GitHub Bot commented on FLINK-10301: NicoK opened a new pull request #6670:

[GitHub] NicoK opened a new pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-07 Thread GitBox
NicoK opened a new pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670 ## What is the purpose of the change `StreamNetworkBenchmarkEnvironment` currently instantiate

[jira] [Created] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-07 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-10301: --- Summary: Allow a custom Configuration in StreamNetworkBenchmarkEnvironment Key: FLINK-10301 URL: https://issues.apache.org/jira/browse/FLINK-10301 Project: Flink

[jira] [Commented] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607003#comment-16607003 ] ASF GitHub Bot commented on FLINK-10242: StefanRRichter commented on a change in

[GitHub] StefanRRichter commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default

2018-09-07 Thread GitBox
StefanRRichter commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default URL: https://github.com/apache/flink/pull/6656#discussion_r215928553 ## File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java #

[jira] [Commented] (FLINK-10242) Disable latency metrics by default

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607001#comment-16607001 ] ASF GitHub Bot commented on FLINK-10242: StefanRRichter commented on a change in

[GitHub] StefanRRichter commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default

2018-09-07 Thread GitBox
StefanRRichter commented on a change in pull request #6656: [FLINK-10242][metrics] Disable latency metrics by default URL: https://github.com/apache/flink/pull/6656#discussion_r215928326 ## File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java #

[jira] [Created] (FLINK-10300) Prometheus job level metrics not removed after job finished

2018-09-07 Thread Helmut Zechmann (JIRA)
Helmut Zechmann created FLINK-10300: --- Summary: Prometheus job level metrics not removed after job finished Key: FLINK-10300 URL: https://issues.apache.org/jira/browse/FLINK-10300 Project: Flink

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606958#comment-16606958 ] Chesnay Schepler commented on FLINK-10247: -- A possibly less invasive option wou

[jira] [Commented] (FLINK-7800) Enable window joins without equi-join predicates

2018-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606916#comment-16606916 ] ASF GitHub Bot commented on FLINK-7800: --- xccui commented on issue #4934: [FLINK-780

[jira] [Commented] (FLINK-10299) RowSerializer.copy data value cast exception

2018-09-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606915#comment-16606915 ] Fabian Hueske commented on FLINK-10299: --- Thanks for reporting this issue [~ambitio

[GitHub] xccui commented on issue #4934: [FLINK-7800] [table] Enable window joins without equi-join predicates

2018-09-07 Thread GitBox
xccui commented on issue #4934: [FLINK-7800] [table] Enable window joins without equi-join predicates URL: https://github.com/apache/flink/pull/4934#issuecomment-419388818 Sounds good. Then I'll do some refactorings to make sure that it works correctly for the current codebase. --

  1   2   >