[ 
https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607001#comment-16607001
 ] 

ASF GitHub Bot commented on FLINK-10242:
----------------------------------------

StefanRRichter commented on a change in pull request #6656: 
[FLINK-10242][metrics] Disable latency metrics by default
URL: https://github.com/apache/flink/pull/6656#discussion_r215928326
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
 ##########
 @@ -104,6 +104,12 @@
                        
.defaultValue("<host>.taskmanager.<tm_id>.<job_name>.<operator_name>.<subtask_index>")
                        .withDescription("Defines the scope format string that 
is applied to all metrics scoped to an operator.");
 
+       public static final ConfigOption<Long> LATENCY_INTERVAL =
+               key("metrics.latency.interval")
+                       .defaultValue(0L)
+                       .withDescription("Defines the interval at which latency 
tracking marks are emitted from the sources." +
 
 Review comment:
   Maybe enhance the description a bit to warn that this can have significant 
overhead and should more be used for debugging and not so munch in production?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disable latency metrics by default
> ----------------------------------
>
>                 Key: FLINK-10242
>                 URL: https://issues.apache.org/jira/browse/FLINK-10242
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Configuration, Metrics
>    Affects Versions: 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> With the plethora of recent issue around latency metrics we should disable 
> them by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to