TisonKun commented on a change in pull request #6673: [FLINK-10304] [client]
Remove deprecated AbstractYarnClusterDescriptor field
URL: https://github.com/apache/flink/pull/6673#discussion_r216017006
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -997,7 +980,6 @@ public ApplicationReport startAppMaster(
appMasterEnv.put(YarnConfigKeys.ENV_CLIENT_HOME_DIR,
homeDir.toString());
appMasterEnv.put(YarnConfigKeys.ENV_CLIENT_SHIP_FILES,
envShipFileList.toString());
appMasterEnv.put(YarnConfigKeys.ENV_SLOTS,
String.valueOf(clusterSpecification.getSlotsPerTaskManager()));
- appMasterEnv.put(YarnConfigKeys.ENV_DETACHED,
String.valueOf(detached));
Review comment:
I wonder if YARN need this config to distinguish a DETACHED session, if so,
`AbstractYarnClusterDescriptor` need to know whether or not it is in a detached
mode. We should keep the original code and remove the `@Deprecated` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
