[
https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607024#comment-16607024
]
ASF GitHub Bot commented on FLINK-10301:
----------------------------------------
zentol commented on a change in pull request #6670: [FLINK-10301][network]
extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances
URL: https://github.com/apache/flink/pull/6670#discussion_r215934568
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -115,7 +115,8 @@ public void setUp(
int channels,
boolean localMode,
int senderBufferPoolSize,
- int receiverBufferPoolSize) throws Exception {
+ int receiverBufferPoolSize,
+ Configuration config) throws Exception {
Review comment:
How about overloading this method instead with a variant that also accepts a
configuration? Then it would be easier to create benchmarks across different
flink versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow a custom Configuration in StreamNetworkBenchmarkEnvironment
> -----------------------------------------------------------------
>
> Key: FLINK-10301
> URL: https://issues.apache.org/jira/browse/FLINK-10301
> Project: Flink
> Issue Type: Improvement
> Components: Network, Tests
> Affects Versions: 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
>
> {{StreamNetworkBenchmarkEnvironment}} currently instantiates its
> {{NettyConfig}} with {{new Configuration()}} but for testing with different
> options, it would be nice to allow the user to provide a custom instance
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
