[
https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607217#comment-16607217
]
陈梓立 commented on FLINK-10302:
-----------------------------
Here are some example, their name are quite misleading.
{{JobClientActor}}, {{YarnApplicationMasterRunner}}, {{JobInfo}}
and note that FLIP-6 also has some classes named starts with JobManager, which
make things worse.
> Mark legacy(non-flip 6) code as Deprecated
> ------------------------------------------
>
> Key: FLINK-10302
> URL: https://issues.apache.org/jira/browse/FLINK-10302
> Project: Flink
> Issue Type: Improvement
> Reporter: 陈梓立
> Priority: Major
>
> There are several time I dash into some classes/methods, finding them weird
> from the FLIP-6 codebase and finally figure out that they are legacy codes.
> Currently we mix up legacy code with FLIP-6 code in same place(i.e. some
> package), new contributor might casually lost into such code and result in
> works in vain.
> With [FLINK-4319] closed we announced that FLIP-6 is production ready, and
> [~trohrm...@apache.org] comments on this
> [commits|https://github.com/apache/flink/commit/ddd6a99a95b56c52ea5b5153b7270b578f5479bc#commitcomment-30330739]
> shows that it is planned to remove legacy code.
> I'd prefer to marking all legacy class as Deprecated for now thus our
> contributors could recognize them quickly and do not ruin they work in vain.
> What do you think? cc [~Zentol]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
