[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982446#comment-15982446 ] ASF GitHub Bot commented on FLINK-5855: --- Github user kl0u commented on the issue:

[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...

2017-04-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3758 Yes. This sounds good, but you reopened this pull request right? Shouldn't this be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-6377) Support map types in the Table / SQL API

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982440#comment-15982440 ] ASF GitHub Bot commented on FLINK-6377: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982438#comment-15982438 ] ASF GitHub Bot commented on FLINK-6302: --- Github user haohui commented on the issue:

[GitHub] flink pull request #3767: [FLINK-6377] [table] Support map types in the Tabl...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3767#discussion_r113115187 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/sql/SqlITCase.java --- @@ -18,9 +18,15 @@ package org.a

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-24 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3720 +1 (non-binding) Tested on OSX Sierra. The documentation builds successfully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-6377) Support map types in the Table / SQL API

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982427#comment-15982427 ] ASF GitHub Bot commented on FLINK-6377: --- GitHub user haohui opened a pull request:

[GitHub] flink pull request #3767: [FLINK-6377] [table] Support map types in the Tabl...

2017-04-24 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/3767 [FLINK-6377] [table] Support map types in the Table / SQL API This PR adds the supports of the map types in the Table / SQL API. It covers both the parsing and the runtime. One caveat is tha

[jira] [Created] (FLINK-6379) Implement FLIP-6 Mesos Resource Manager

2017-04-24 Thread Eron Wright (JIRA)
Eron Wright created FLINK-6379: --- Summary: Implement FLIP-6 Mesos Resource Manager Key: FLINK-6379 URL: https://issues.apache.org/jira/browse/FLINK-6379 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-6378) Implement FLIP-6 Flink-on-Mesos

2017-04-24 Thread Eron Wright (JIRA)
Eron Wright created FLINK-6378: --- Summary: Implement FLIP-6 Flink-on-Mesos Key: FLINK-6378 URL: https://issues.apache.org/jira/browse/FLINK-6378 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982390#comment-15982390 ] ASF GitHub Bot commented on FLINK-5752: --- Github user ramkrish86 commented on the iss

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-24 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 The failures seems not directly related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-1526) Add Minimum Spanning Tree library method and example

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982354#comment-15982354 ] ASF GitHub Bot commented on FLINK-1526: --- Github user xccui closed the pull request a

[GitHub] flink pull request #3284: [FLINK-1526] [Gelly] Add Minimum Spanning Tree lib...

2017-04-24 Thread xccui
Github user xccui closed the pull request at: https://github.com/apache/flink/pull/3284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (FLINK-6377) Support map types in the Table / SQL API

2017-04-24 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-6377: - Summary: Support map types in the Table / SQL API Key: FLINK-6377 URL: https://issues.apache.org/jira/browse/FLINK-6377 Project: Flink Issue Type: New Feature

[jira] [Assigned] (FLINK-6368) Grouping keys in stream aggregations have wrong order

2017-04-24 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui reassigned FLINK-6368: -- Assignee: Xingcan Cui > Grouping keys in stream aggregations have wrong order > ---

[jira] [Updated] (FLINK-6351) Refactor YarnFlinkApplicationMasterRunner by combining AbstractYarnFlinkApplicationMasterRunner in one class

2017-04-24 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6351: Description: The currently YarnFlinkApplicationMasterRunner inherits from AbstractYarnFlinkApplicati

[jira] [Assigned] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-04-24 Thread zhangrucong1982 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangrucong1982 reassigned FLINK-6376: -- Assignee: zhangrucong1982 > when deploy flink cluster on the yarn, it is lack of hdfs d

[jira] [Created] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-04-24 Thread zhangrucong1982 (JIRA)
zhangrucong1982 created FLINK-6376: -- Summary: when deploy flink cluster on the yarn, it is lack of hdfs delegation token. Key: FLINK-6376 URL: https://issues.apache.org/jira/browse/FLINK-6376 Project

[jira] [Created] (FLINK-6375) Fix LongValue hashCode

2017-04-24 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-6375: - Summary: Fix LongValue hashCode Key: FLINK-6375 URL: https://issues.apache.org/jira/browse/FLINK-6375 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982277#comment-15982277 ] ASF GitHub Bot commented on FLINK-6288: --- GitHub user fanyon opened a pull request:

[GitHub] flink pull request #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Parti...

2017-04-24 Thread fanyon
GitHub user fanyon opened a pull request: https://github.com/apache/flink/pull/3766 [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic 1. add extra api addTopicPartitioner, user can use it to add special topic and p

[jira] [Created] (FLINK-6374) In yarn cluster model, the -ys parameter is not take effect.

2017-04-24 Thread zhangrucong1982 (JIRA)
zhangrucong1982 created FLINK-6374: -- Summary: In yarn cluster model, the -ys parameter is not take effect. Key: FLINK-6374 URL: https://issues.apache.org/jira/browse/FLINK-6374 Project: Flink

[jira] [Commented] (FLINK-6295) Update suspended ExecutionGraph to lower latency

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982255#comment-15982255 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on th

[GitHub] flink issue #3709: [FLINK-6295]Update suspended ExecutionGraph to lower late...

2017-04-24 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 @StephanEwen Sure. The current fix is like a "pull", while what you suggest is a "push" way. Both them can fix just make difference in how the EGs being updated. --- If your project is set

[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...

2017-04-24 Thread zhangminglei
GitHub user zhangminglei reopened a pull request: https://github.com/apache/flink/pull/3758 [FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles… …PerCheckpoint in BucketingSink. Thanks for contributing to Apache Flink. Before you open your pull request,

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982231#comment-15982231 ] ASF GitHub Bot commented on FLINK-5855: --- Github user zhangminglei closed the pull re

[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...

2017-04-24 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/3758 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982232#comment-15982232 ] ASF GitHub Bot commented on FLINK-5855: --- GitHub user zhangminglei reopened a pull re

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982229#comment-15982229 ] ASF GitHub Bot commented on FLINK-5855: --- Github user zhangminglei commented on the i

[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...

2017-04-24 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3758 @kl0u Thanks for review , very appreciate it. Yep, BTW, I would like to work on what you will thorough the code in the following days and keep watching this class ```synchronized()```. Hopes wor

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982038#comment-15982038 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982039#comment-15982039 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982036#comment-15982036 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982034#comment-15982034 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982037#comment-15982037 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982035#comment-15982035 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982040#comment-15982040 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113072949 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1281,7 +1323,7 @@ object Aggregate

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113072931 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1259,7 +1301,7 @@ object Aggregate

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113072758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1232,12 +1266,20 @@ object Aggrega

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113073730 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRangeProcessFunctionTest.scala --- @@ -51

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113067259 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala --- @@ -17,36 +17,93 @@ */ package

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113066365 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala --- @@ -17,36 +17,93 @@ */ package

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3762#discussion_r113065861 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -471,31 +480,36 @@ class CodeGenerator(

[jira] [Assigned] (FLINK-4897) Implement Dispatcher

2017-04-24 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright reassigned FLINK-4897: --- Assignee: Eron Wright Fix Version/s: (was: 1.3.0) > Implement Dispatcher >

[GitHub] flink pull request #3757: (refactor) some opportunities to use multi-catch

2017-04-24 Thread rbonifacio
Github user rbonifacio commented on a diff in the pull request: https://github.com/apache/flink/pull/3757#discussion_r113068939 --- Diff: flink-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroOutputFormat.java --- @@ -125,9 +125,7 @@ public void open(int taskN

[jira] [Commented] (FLINK-6373) Add runtime support for distinct aggregation over grouped windows

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981948#comment-15981948 ] ASF GitHub Bot commented on FLINK-6373: --- Github user haohui commented on the issue:

[GitHub] flink issue #3765: [FLINK-6373] Add runtime support for distinct aggregation...

2017-04-24 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3765 Note that this PR contains minimal amount of tests. Would love the feedbacks on what kinds of tests are required here. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #3765: [FLINK-6373] Add runtime support for distinct aggr...

2017-04-24 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/3765 [FLINK-6373] Add runtime support for distinct aggregation over grouped windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/haohui/flink FLIN

[jira] [Commented] (FLINK-6373) Add runtime support for distinct aggregation over grouped windows

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981934#comment-15981934 ] ASF GitHub Bot commented on FLINK-6373: --- GitHub user haohui opened a pull request:

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981878#comment-15981878 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113043582 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -255,17 +256,23 @@ class CodeGenerator(

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981891#comment-15981891 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981873#comment-15981873 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981887#comment-15981887 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113044998 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchScan.scala --- @@ -38,7 +39,9 @@ trait BatchScan extends

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113048128 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -102,13 +110,17 @@ object Aggregate

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981880#comment-15981880 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113045326 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCalc.scala --- @@ -45,7 +45,7 @@ class DataStrea

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113050568 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRowsOver.scala --- @@ -48,15 +49,15 @@ class Pr

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113047487 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala --- @@ -46,12 +47,12 @@ class Aggre

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981885#comment-15981885 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113048214 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -102,13 +110,17 @@ object Aggregate

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981872#comment-15981872 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981893#comment-15981893 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113048361 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -118,7 +130,7 @@ object AggregateUt

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981874#comment-15981874 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r112901336 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -723,11 +738,11 @@ abstract class TableEnviron

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981884#comment-15981884 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r112902344 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/types/CRowTypeInfo.scala --- @@ -0,0 +1,86 @@ +/* + * Licensed t

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113050330 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala --- @@ -69,10 +70,10 @@ class P

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981870#comment-15981870 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981889#comment-15981889 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981883#comment-15981883 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981886#comment-15981886 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981881#comment-15981881 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981894#comment-15981894 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981892#comment-15981892 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981877#comment-15981877 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981895#comment-15981895 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981879#comment-15981879 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113049930 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala --- @@ -69,10 +70,10 @@ class P

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981867#comment-15981867 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113049237 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -31,35 +32,35 @@ abstract c

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981871#comment-15981871 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981882#comment-15981882 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r112901608 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -723,11 +738,11 @@ abstract class TableEnviron

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981890#comment-15981890 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981888#comment-15981888 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981869#comment-15981869 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113049726 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala --- @@ -47,12 +48,12 @@ class P

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113043191 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenUtils.scala --- @@ -233,6 +234,9 @@ object CodeGenUtils {

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113051216 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/TimeWindowPropertyCollector.scala --- @@ -19,34 +19,44 @@

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113049009 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggReduceGroupFunction.scala --- @@ -66,7

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113046533 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCalc.scala --- @@ -92,11 +92,13 @@ class DataStr

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113046948 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRel.scala --- @@ -22,17 +22,16 @@ import org.apa

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113050816 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala --- @@ -82,9 +83,9 @@ class Pro

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981875#comment-15981875 ] ASF GitHub Bot commented on FLINK-6091: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r112901968 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -175,14 +176,19 @@ object FlinkTypeFactory

  1   2   3   >