[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982229#comment-15982229
]
ASF GitHub Bot commented on FLINK-5855:
---------------------------------------
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Thanks for review , very appreciate it. Yep, BTW, I would like to
work on what you will thorough the code in the following days and keep watching
this class ```synchronized()```. Hopes work on the new jira if you could assign
to me. I will close this PR and JIRA as well.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
> ----------------------------------------------------------------
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
