Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r113049237
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -31,35 +32,35 @@ abstract class GeneratedAggregations extends Function {
*
* @param accumulators the accumulators (saved in a row) which contains
the current
* aggregated results
- * @param output output results collected in a row
+ * @param output output results collected in a command row
*/
- def setAggregationResults(accumulators: Row, output: Row)
+ def setAggregationResults(accumulators: Row, output: CRow)
--- End diff --
I would change all `CRow` types back to `Row`. Let's leave the code
generation as it is and extract the rows in the wrapper classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
