Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r113049009
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggReduceGroupFunction.scala
 ---
    @@ -66,7 +66,7 @@ class DataSetSessionWindowAggReduceGroupFunction(
     
       private var aggregateBuffer: Row = _
       private var output: Row = _
    -  private var collector: TimeWindowPropertyCollector = _
    +  private var collector: TimeWindowPropertyCollector[Row] = _
    --- End diff --
    
    We can make `TimeWindowPropertyCollector` abstract and implement two 
versions, one for `Row` and one for `CRow`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to