[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981874#comment-15981874 ]
ASF GitHub Bot commented on FLINK-6091: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r113045326 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCalc.scala --- @@ -45,7 +45,7 @@ class DataStreamCalc( ruleDescription: String) extends Calc(cluster, traitSet, input, calcProgram) with CommonCalc - with DataStreamRel { + with DataStreamRel[CRow] { --- End diff -- `DataStreamRel` does not need a type parameter, IMO. All `DataStreamRel` nodes should produce `CRow`. > Implement and turn on the retraction for aggregates > --------------------------------------------------- > > Key: FLINK-6091 > URL: https://issues.apache.org/jira/browse/FLINK-6091 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: Shaoxuan Wang > Assignee: Hequn Cheng > > Implement functions for generating and consuming retract messages for > different aggregates. > 1. add delete/add property to Row > 2. implement functions for generating retract messages for unbounded groupBy > 3. implement functions for handling retract messages for different aggregates. > 4. handle retraction messages in CommonCorrelate and CommonCalc (retain > Delete property). > Note: Currently, only unbounded groupby generates retraction and it is > working under unbounded and processing time mode. Hence, retraction is only > supported for unbounded and processing time aggregations so far. We can add > more retraction support later. > supported now: unbounded groupby, unbounded and processing time over window > unsupported now: group window, event time or bounded over window. -- This message was sent by Atlassian JIRA (v6.3.15#6346)