Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r112901336
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
 ---
    @@ -723,11 +738,11 @@ abstract class TableEnvironment(val config: 
TableConfig) {
     
         val genFunction = generator.generateFunction(
           functionName,
    -      classOf[MapFunction[Row, T]],
    +      classOf[MapFunction[P, T]],
    --- End diff --
    
    I think we should not touch the code generator. Instead, we unwrap the 
`Row` from the `CRow` before handing it to the code-gen'd function. 
    I'll add more comments on this below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to