[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread ffbin
Github user ffbin commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38382368 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/AbstractStormSpoutWrappe

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724717#comment-14724717 ] ASF GitHub Bot commented on FLINK-2525: --- Github user ffbin commented on a diff in th

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724544#comment-14724544 ] ASF GitHub Bot commented on FLINK-2590: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136545997 Ah, thank you for the proof. And didn`t see the log2 in detail before, sorry. --- If your project is set up for it, you can reply to this email and have your repl

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724542#comment-14724542 ] ASF GitHub Bot commented on FLINK-2125: --- Github user HuangWHWHW commented on a diff

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-31 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1077#discussion_r38378250 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketTextStreamFunctionTest.java ---

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724537#comment-14724537 ] ASF GitHub Bot commented on FLINK-2125: --- Github user HuangWHWHW commented on a diff

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-31 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1077#discussion_r38378115 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketTextStreamFunctionTest.java ---

[jira] [Commented] (FLINK-1725) New Partitioner for better load balancing for skewed data

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724019#comment-14724019 ] ASF GitHub Bot commented on FLINK-1725: --- Github user anisnasir commented on the pull

[GitHub] flink pull request: [FLINK-1725]- New Partitioner for better load ...

2015-08-31 Thread anisnasir
Github user anisnasir commented on the pull request: https://github.com/apache/flink/pull/1069#issuecomment-136496310 @tillrohrmann Yes, we can design a system that adapts to the load imbalance and increases the number of partitions per key in real time. However, this comes with few o

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723967#comment-14723967 ] ASF GitHub Bot commented on FLINK-2125: --- Github user ogokal commented on the pull re

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-31 Thread ogokal
Github user ogokal commented on the pull request: https://github.com/apache/flink/pull/1077#issuecomment-136486224 I changed unit tests as HuangWHWHW suggested, added a simple test server socket and refactored test methods. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread s1ck
Github user s1ck commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136445029 @tillrohrmann I did not include the `shifter = getBitSize(getRuntimeContext().getNumberOfParallelSubtasks() - 1)` as your hint only applies for power of 2 values. E.g., `ge

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723779#comment-14723779 ] ASF GitHub Bot commented on FLINK-2590: --- Github user s1ck commented on the pull requ

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723701#comment-14723701 ] ASF GitHub Bot commented on FLINK-2590: --- Github user s1ck commented on the pull requ

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread s1ck
Github user s1ck commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136431165 @StephanEwen thx for the hint. works fine! Will cleanup and commit now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723681#comment-14723681 ] ASF GitHub Bot commented on FLINK-2590: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136427373 There is an issue that tracks the `ConcurrentModificationException`problem. As per discussion in that issue, can you use a `BroadcastVariableInitializer`? Safes redu

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723667#comment-14723667 ] ASF GitHub Bot commented on FLINK-2590: --- Github user s1ck commented on the pull requ

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread s1ck
Github user s1ck commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136426216 @tillrohrmann While writing the new tests for both methods, I encountered that `zipWithIndex` is broken, too. It sometimes throws `ConcurrentModificationException`. This is

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2015-08-31 Thread Trevor Grant (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723555#comment-14723555 ] Trevor Grant commented on FLINK-1994: - Sorry for the delay on this- I've been in the m

[jira] [Closed] (FLINK-2599) Failing Test: SlotCountExceedingParallelismTest

2015-08-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2599. --- > Failing Test: SlotCountExceedingParallelismTest > --- > >

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136386406 @s1ck, the `testZipWithUniqueId` test is bogus. You can remove this test case an replace it with your described test. It would also be great if you could set the pa

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723462#comment-14723462 ] ASF GitHub Bot commented on FLINK-2590: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136382814 @s1ck Good idea. You can also call `collect()`, add the IDs to a set and make sure the set has the right cardinality. In general, avoiding temp files and Strings for

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723446#comment-14723446 ] ASF GitHub Bot commented on FLINK-2590: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723434#comment-14723434 ] ASF GitHub Bot commented on FLINK-2590: --- Github user s1ck commented on the pull requ

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread s1ck
Github user s1ck commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136380943 There is already a test case for zipWithUniqueId() in https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/util/DataSetUtilsITCase.jav

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723418#comment-14723418 ] ASF GitHub Bot commented on FLINK-1984: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312802 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -275,7 +275,14 @@ * Path to Hadoop configuration

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-08-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-136377793 Thank you for the response. I was asking because I think its a requirement that the JobManager is running as a mesos task in the cluster as well. But as far as I unde

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723414#comment-14723414 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312609 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java ---

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723413#comment-14723413 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723411#comment-14723411 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312505 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/FiniteStormFileSpout.jav

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723407#comment-14723407 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723408#comment-14723408 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312340 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithSto

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312308 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithSto

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723405#comment-14723405 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723406#comment-14723406 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723404#comment-14723404 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312152 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithSto

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312165 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithSto

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38312112 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithSto

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38311967 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapper.java -

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723401#comment-14723401 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723400#comment-14723400 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38311822 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/AbstractStormSpoutWrappe

[GitHub] flink pull request: [core][runtime] move SerializedValueTest from ...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2599) Failing Test: SlotCountExceedingParallelismTest

2015-08-31 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723383#comment-14723383 ] Matthias J. Sax commented on FLINK-2599: I guess it would be better if you open a

[jira] [Commented] (FLINK-2372) Update KafkaSink to use new Producer API

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723382#comment-14723382 ] ASF GitHub Bot commented on FLINK-2372: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-08-31 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1082 [FLINK-2372] Add new FlinkKafkaProducer This pull request is reworking Flink's KafkaSink. I've renamed the class to `FlinkKafkaProducer` to match it with `FlinkKafkaConsumer`. It uses

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723369#comment-14723369 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-08-31 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136361760 @mxm Thank you! BTW:can you take a look about this PR:https://github.com/apache/flink/pull/992? I add a new test in that PR and I`m not sure is it you nee

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-31 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-136359875 @chiwanpark Yes, it's sure that the apache version of HCatalog is compiled against hadoop1. Using this jar in an hadoop2 environment will lead to binary incompatib

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-08-31 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136357113 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723355#comment-14723355 ] ASF GitHub Bot commented on FLINK-2480: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2399) Fail when actor versions don't match

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723349#comment-14723349 ] ASF GitHub Bot commented on FLINK-2399: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...

2015-08-31 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/945#issuecomment-136356151 Rebased to the current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [core][runtime] move SerializedValueTest from ...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1081#issuecomment-136355256 Looks good, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] flink pull request:

2015-08-31 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/a18994aabfba7c3775f6dc911bd9d59016216817#commitcomment-12974542 In flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedValueTest.java: In flink-runtime/src/test/java/org/apache/f

[GitHub] flink pull request: [core][runtime] move SerializedValueTest from ...

2015-08-31 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1081 [core][runtime] move SerializedValueTest from runtime to core - move createCopySerializable to core's CommonTestUtils - rename CommonTestUtils createCopy to createCopyWritable - adapt the tests t

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723339#comment-14723339 ] ASF GitHub Bot commented on FLINK-2590: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136352327 +1 for a test, otherwise this looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723335#comment-14723335 ] ASF GitHub Bot commented on FLINK-2590: --- Github user StephanEwen commented on a diff

[jira] [Resolved] (FLINK-2599) Failing Test: SlotCountExceedingParallelismTest

2015-08-31 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-2599. Resolution: Cannot Reproduce Fixed the NPE via ac9a911. The NPE is a follow up issue. The main prob

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1075#discussion_r38305177 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java --- @@ -121,6 +122,7 @@ public void mapPartition(Iterable values, Co

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-31 Thread Ozturk Gokal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1472#comment-1472 ] Ozturk Gokal commented on FLINK-2125: - I will change test codes to use a test socket s

[jira] [Commented] (FLINK-2291) Use ZooKeeper to elect JobManager leader and send information to TaskManagers

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723328#comment-14723328 ] ASF GitHub Bot commented on FLINK-2291: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2291] [runtime] Adds high availability ...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1016 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2448) registerCacheFile fails with MultipleProgramsTestbase

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723326#comment-14723326 ] ASF GitHub Bot commented on FLINK-2448: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2448]Create new Test environments on ge...

2015-08-31 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1031#issuecomment-136349300 @StephanEwen, this should be mergeable now. I've separated the Gelly change as a second commit. --- If your project is set up for it, you can reply to this em

[jira] [Commented] (FLINK-2584) ASM dependency is not shaded away

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723310#comment-14723310 ] ASF GitHub Bot commented on FLINK-2584: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136339437 Make sure it does not break with @tillrohrmann's recent merge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-2584) ASM dependency is not shaded away

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723305#comment-14723305 ] ASF GitHub Bot commented on FLINK-2584: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136336944 I'll merge this now into `master` and `0.10.0-milestone1`. In the long run, we can hopefully convince curator to offer a shaded version in addition to the un

[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1080#issuecomment-136335673 Thanks, will merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[jira] [Commented] (FLINK-2596) Failing Test: RandomSamplerTest

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723298#comment-14723298 ] ASF GitHub Bot commented on FLINK-2596: --- Github user StephanEwen commented on the pu

[jira] [Closed] (FLINK-2291) Use ZooKeeper to elect JobManager leader and send information to TaskManagers

2015-08-31 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2291. Resolution: Fixed Added via b9de4ed37ffa68ef50dc6d6b3819afcc00d1d029 > Use ZooKeeper to elect JobMa

[jira] [Commented] (FLINK-2291) Use ZooKeeper to elect JobManager leader and send information to TaskManagers

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723283#comment-14723283 ] ASF GitHub Bot commented on FLINK-2291: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2291] [runtime] Adds high availability ...

2015-08-31 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1016#issuecomment-136327681 Failing test is a Yarn test. Locally Travis passed. Will merge it now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request:

2015-08-31 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/commit/9e20147c2089d29e3071addec19f0956f68b7321#commitcomment-12973040 I'll fix it. Thanks for the pointer @JonathanH5 :-) --- If your project is set up for it, you can reply to this email and hav

[GitHub] flink pull request:

2015-08-31 Thread JonathanH5
Github user JonathanH5 commented on the pull request: https://github.com/apache/flink/commit/9e20147c2089d29e3071addec19f0956f68b7321#commitcomment-12972151 Hi Till, as reported by me and @FelixNeutatz: the stop-script has the same error... --- If your project is set up for

[GitHub] flink pull request: Stale Synchronous Parallel Iterations

2015-08-31 Thread nltran
Github user nltran commented on a diff in the pull request: https://github.com/apache/flink/pull/967#discussion_r38295439 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/iterative/event/EventWithAggregatorsTest.java --- @@ -123,6 +169,31 @@ private IterationEventWit

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136301903 @mjsax Thanks. I have a question: In my windows machine, the textPath of ExclamationWithStormSpoutITCase is file:/C:/Users/xxx/AppData/Local/Temp/org.apache.flink.s

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136305354 This might be the case. I never tried it. And as far as I know, all developers work on Linux or Mac, so this was never an issue. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136304296 Oh, So not all test case can run successfully in windows? I have change this and commit again. --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723219#comment-14723219 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723212#comment-14723212 ] ASF GitHub Bot commented on FLINK-2525: --- Github user ffbin commented on the pull req

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723209#comment-14723209 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136302889 Travis run on Linux. There is only a single ":" in the path there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723206#comment-14723206 ] ASF GitHub Bot commented on FLINK-2525: --- Github user ffbin commented on the pull req

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-08-31 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-136285097 @tillrohrmann Hi,very sorry for disturbing. I have changed the PR as your comments and passed the CI. It will be thankful if you can take a look. --- I

[jira] [Commented] (FLINK-1725) New Partitioner for better load balancing for skewed data

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723160#comment-14723160 ] ASF GitHub Bot commented on FLINK-1725: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-1725]- New Partitioner for better load ...

2015-08-31 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1069#issuecomment-136290092 @anisnasir, good to know that most real world data sets can be handled by just splitting keys into two components. But what about the rest? Wouldn't it be nice to h

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723153#comment-14723153 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-31 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136289777 This is the stack trace (occurs in 4/5 runs -- the other run failed before due to unrelated test). It seems you broke something. ``` Tests run: 1, Failures: 1, Erro

[jira] [Created] (FLINK-2599) Failing Test: SlotCountExceedingParallelismTest

2015-08-31 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created FLINK-2599: -- Summary: Failing Test: SlotCountExceedingParallelismTest Key: FLINK-2599 URL: https://issues.apache.org/jira/browse/FLINK-2599 Project: Flink Issue Type:

  1   2   >