Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136386406
@s1ck, the `testZipWithUniqueId` test is bogus. You can remove this test
case an replace it with your described test. It would also be great if you
could set the parallelism of `testZipWithIndex` to something greater than `1`.
Here it would also make sense to use `collect` instead of writing to disk.
+1 for renaming `log2` into `getBitSize(long value)`. When you rename the
method, could you also change the line `shifter =
getBitSize(getRuntimeContext().getNumberOfParallelSubtasks())` into `shifter =
getBitSize(getRuntimeContext().getNumberOfParallelSubtasks() - 1)`. That way,
we would also get the right unique ids in case of `parallelism = 1`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
