Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38311967
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapper.java
 ---
    @@ -205,7 +211,35 @@ public void open(final Configuration parameters) 
throws Exception {
                                        this.numberOfAttributes, 
flinkCollector));
                }
     
    -           this.bolt.prepare(null, topologyContext, stormCollector);
    +           Map stormConf = new HashMap();
    --- End diff --
    
    Seems to be the same code as in `AbstractStormSpoutWrapper.open(...)`. Can 
you unify it, ie, add a new static method to `StormWrapperSetupHelper` that 
does it, and just call it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to