Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312112
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithStormBolt.java
---
@@ -86,11 +99,40 @@ public static void main(final String[] args) throws
Exception {
// USER FUNCTIONS
//
*************************************************************************
- private static class ExclamationMap implements MapFunction<String,
String> {
+ private static class ExclamationMap extends AbstractRichFunction
implements MapFunction<String, String> {
+
+ private String exclamation;
+
+ @Override
+ public void open(Configuration parameters) throws Exception {
+ exclamation = new String("!!!");
--- End diff --
move this to new `else` in line 121 to make clear it is the default value
in case no config is given.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
