[ 
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723406#comment-14723406
 ] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38312165
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithStormBolt.java
 ---
    @@ -101,20 +143,23 @@ public String map(String value) throws Exception {
        private static boolean fileOutput = false;
        private static String textPath;
        private static String outputPath;
    +   private static int exclamationNum;
     
        private static boolean parseParameters(final String[] args) {
     
                if (args.length > 0) {
                        // parse input arguments
                        fileOutput = true;
    -                   if (args.length == 2) {
    +                   if (args.length == 3) {
                                textPath = args[0];
                                outputPath = args[1];
    +                           exclamationNum = Integer.parseInt(args[2]);
                        } else {
                                System.err.println("Usage: 
ExclamationWithStormBolt <text path> <result path>");
                                return false;
                        }
                } else {
    +                   exclamationNum = 3;
                        System.out.println("Executing ExclamationWithStormBolt 
example with built-in default data");
                        System.out.println("  Provide parameters to read input 
data from a file");
                        System.out.println("  Usage: ExclamationWithStormBolt 
<text path> <result path>");
    --- End diff --
    
    param list


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and 
> `Bolt.prepare()`, respectively. Both methods have a config `Map` as first 
> parameter. This map is currently not populated. Thus, Spouts and Bolts cannot 
> be configure with user defined parameters. In order to support this feature, 
> spout and bolt wrapper classes need to be extended to create a proper `Map` 
> object. Furthermore, the clients need to be extended to take a `Map`, 
> translate it into a Flink `Configuration` that is forwarded to the wrappers 
> for proper initialization of the map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to