Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Sebastian Bergmann
Am 27.01.2015 um 07:40 schrieb Matteo Beccati: > The warning is certainly annoying, but making it default to UTC or a wrong > timezone because the right one can't be guessed is a major WTF. Couldn't agree more; -1 for removing the warning. -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Matteo Beccati
On 27/01/2015 01:34, Bob Weinand wrote: Hey, I'd like to request removal of the date.timezone warning. Here is the RFC: https://wiki.php.net/rfc/date.timezone_warning_removal The warning is certainly annoying, but making it default to

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Pierre Joye
On Jan 27, 2015 2:29 AM, "Derick Rethans" wrote: > > On Mon, 26 Jan 2015, Ferenc Kovacs wrote: > > > On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann wrote: > > > > > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > > > how would YOU propose to replace it? > > > > > > I am not talking about r

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Pierre Joye
On Jan 27, 2015 12:01 PM, "Pierre Joye" wrote: > > > On Jan 27, 2015 2:29 AM, "Derick Rethans" wrote: > > > > On Mon, 26 Jan 2015, Ferenc Kovacs wrote: > > > > > On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann wrote: > > > > > > > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > > > > how wo

Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Pierre Joye
On Jan 27, 2015 11:25 AM, "Yasuo Ohgaki" wrote: > > Hi Kalle and all, > > On Tue, Jan 27, 2015 at 12:56 PM, Kalle Sommer Nielsen > wrote: > > > I think the warning is fair as it is, if it is annoying for small use > > cases like on the CLI then simply: php -d date.timezone=UTC -r "echo > > date('

Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Yasuo Ohgaki
Hi Kalle and all, On Tue, Jan 27, 2015 at 12:56 PM, Kalle Sommer Nielsen wrote: > I think the warning is fair as it is, if it is annoying for small use > cases like on the CLI then simply: php -d date.timezone=UTC -r "echo > date('H:i:s');" or the dirty way by using the silent operator. It used

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-26 Thread Joshua Rogers
On 27/01/15 14:32, Joshua Rogers wrote: > if '1' is returned, the it is OK to continue. > If '0' is returned, it is not OK to continue(return -1) > > > Since this is the case, should the do_fstat function be changed to a > boolean? https://github.com/php/php-src/pull/1031 -- -- Joshua Rogers

Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Kalle Sommer Nielsen
Hi 2015-01-27 1:34 GMT+01:00 Bob Weinand : > Hey, > > I'd like to request removal of the date.timezone warning. > > Here is the RFC: > https://wiki.php.net/rfc/date.timezone_warning_removal > > > Bob I think the warning is fair as it is, i

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-26 Thread Joshua Rogers
On 27/01/15 11:39, Joshua Rogers wrote: > if(do_fstat(data, 1)<0) { > return -1; > } This was wrong, anyways. if '1' is returned, the it is OK to continue. If '0' is returned, it is not OK to continue(return -1) Since this is the case, should the do_fstat function be changed to a boolean? It is

Re: [PHP-DEV][RFC] Enable error_handler callback parameters to be passed by reference

2015-01-26 Thread Yasuo Ohgaki
Hi Thomas, On Tue, Jan 27, 2015 at 11:45 AM, Thomas Bley wrote: > Here is the rfc: > > https://wiki.php.net/rfc/error_handler_callback_parameters_passed_by_reference > > Thanks to reeze for coding and putting it on the wiki. > It looks good to me. Future Scope set_error_handler() callback migh

Re: [PHP-DEV][RFC] Enable error_handler callback parameters to be passed by reference

2015-01-26 Thread Thomas Bley
Here is the rfc: https://wiki.php.net/rfc/error_handler_callback_parameters_passed_by_reference Thanks to reeze for coding and putting it on the wiki. Regards Thomas reeze wrote on 23.01.2015 10:59: > Yeah, seem other want it it too, so I just updated the PR to allow the first > four paramete

[PHP-DEV] Re: Discussion for RFC: Set appropriate/better defaults.

2015-01-26 Thread Yasuo Ohgaki
Hi all, On Tue, Jan 27, 2015 at 11:06 AM, Yasuo Ohgaki wrote: > - session.hash_function=1 : Use SHA1 rather than MD5 I realized that we should remove hashing for better performance. Since session ID is generated from crypt secure RNG (/dev/urandom by default), simply converting the data into

[PHP-DEV] Re: Deprecating all INI set/get functions and use ini_set/get()

2015-01-26 Thread Yasuo Ohgaki
Hi all, On Sun, Jan 25, 2015 at 9:29 AM, Yasuo Ohgaki wrote: > I would like to propose INI set/get function deprecation, raise > E_DEPRECATED, > and make PHP_INI_MH() use the CODING_STANDARDS. > > For example, session module has following INI set/get functions > > - http://php.net/manual/en/fun

[PHP-DEV] Discussion for RFC: Set appropriate/better defaults.

2015-01-26 Thread Yasuo Ohgaki
Hi all, I would like to write RFC that sets appropriate/better defaults by default. For example, htmlspecialchars has following definition now. string htmlspecialchars ( string $string [, int $flags = ENT_COMPAT | ENT_HTML401 [, string $encoding = ini_get("default_charset") [, bool $double_encod

Re: [PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Yasuo Ohgaki
HI Bob, On Tue, Jan 27, 2015 at 9:34 AM, Bob Weinand wrote: > > I'd like to request removal of the date.timezone warning. > > Here is the RFC: > https://wiki.php.net/rfc/date.timezone_warning_removal Nice RFC. I would like to remove the warning, too. Setting it to UTC without warning sounds rea

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-26 Thread Yasuo Ohgaki
Hi Joshua, On Tue, Jan 27, 2015 at 9:39 AM, Joshua Rogers wrote: > > This patch seems reasonable. Does anyone taking care of this? > Perhaps it should be > > if(do_fstat(data, 1)<0) { > return -1; > } > > just to conform with the rest of the code If nobody is taking care of this yet, please se

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-26 Thread Joshua Rogers
On 27/01/15 11:35, Yasuo Ohgaki wrote: > This patch seems reasonable. Does anyone taking care of this? Perhaps it should be if(do_fstat(data, 1)<0) { return -1; } just to conform with the rest of the code -- -- Joshua Rogers signature.asc Description: OpenPGP digital

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-26 Thread Yasuo Ohgaki
Hi all, On Thu, Jan 15, 2015 at 5:04 PM, Joshua Rogers wrote: > main/streams/plain_wrapper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c > index f52383d..72be0b0 100644 > --- a/main/streams/plain_wrapper.

Re: [PHP-DEV] [PATCH] Fix integer overflow in calender.

2015-01-26 Thread Joshua Rogers
On 27/01/15 11:30, Yasuo Ohgaki wrote: > Hi Joshua, > > Did you send PR or bug report for this? > We need PR or bug report for a bug fix. > Thank you. https://github.com/php/php-src/pull/1009 https://github.com/php/php-src/pull/1008 -- -- Joshua Rogers signature.asc De

[PHP-DEV] [RFC] Remove the date.timezone warning

2015-01-26 Thread Bob Weinand
Hey, I'd like to request removal of the date.timezone warning. Here is the RFC: https://wiki.php.net/rfc/date.timezone_warning_removal Bob

Re: [PHP-DEV] [PATCH] Fix integer overflow in calender.

2015-01-26 Thread Yasuo Ohgaki
Hi Joshua, Did you send PR or bug report for this? We need PR or bug report for a bug fix. Thank you. -- Yasuo Ohgaki yohg...@ohgaki.net On Mon, Jan 19, 2015 at 8:34 PM, Joshua Rogers wrote: > Fix in overflows in conversation functions for calendar. > Add tests for the overflows. > --- > ext/

Re: [PHP-DEV] [PATCH] Fix potential int overflow in date extension.

2015-01-26 Thread Yasuo Ohgaki
Hi all, On Tue, Jan 20, 2015 at 4:23 AM, Joshua Rogers wrote: > On 20/01/15 06:15, Joshua Rogers wrote: > > -- > > ext/date/lib/tm2unixtime.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > Somebody please take a look at /ext/date/lib/parse_tz.c too: > > 438timelib_sll timelib

[PHP-DEV] Error compiling with debug

2015-01-26 Thread Joshua Rogers
Hi guys, I'm trying to compile phpdbg, but am receiving these errors(yes, I know, I'm compiling as root. It's a VM): > In file included from /root/php-src/sapi/phpdbg/phpdbg.h:126:0, > from /root/php-src/sapi/phpdbg/phpdbg_bp.c:23: > /root/php-src/sapi/phpdbg/phpdbg_bp.c: In func

Re: [PHP-DEV] Re: [VOTE] Remove hex support in numeric strings

2015-01-26 Thread Pascal Martin, AFUP
Le 26/01/2015 21:02, Nikita Popov a écrit : Reminder: This vote closes tomorrow. Nikita Hi, Not many of us at AFUP expressed their opinion on this RFC (which is probably a sign this feature isn't used much and won't be missed ^^). Still, those who did all agree on removing this -- which me

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Lester Caine
On 26/01/15 19:29, Derick Rethans wrote: >> as easy as 1, install composer, >> > 2, install pickle with composer 3, install your pecl ext with pickle. > That is not easy. Certainly not as easy as just "pecl install > " anything similar short of that is not sufficient. And even more fun when a set

Re: [PHP-DEV] imagick on PHP 7 was Stepping stones to a working php7 ...

2015-01-26 Thread Lester Caine
On 26/01/15 17:58, Dan Ackroyd wrote: > Opening any issues you might find on Github would probably get them > resolved more quickly than bugs.php.net due to the more direct > notifications. I'm getting a unknown type name ‘smart_str’ after failing to find php_smart_str.h because my php7 build has p

Re: [PHP-DEV] [VOTE] jsond

2015-01-26 Thread Jakub Zelenka
On Mon, Jan 26, 2015 at 8:07 PM, Levi Morrison wrote: > > Voting on jsond is now open: > > > > https://wiki.php.net/rfc/jsond > > > > It's a simple Yes/No vote whether jsond should replace the current json > > extension in PHP 7. > > Before I vote I want to double-check something that I didn't fi

Re: [PHP-DEV] [VOTE] jsond

2015-01-26 Thread Jakub Zelenka
On Mon, Jan 26, 2015 at 8:04 AM, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 25/01/2015 18:29, Jakub Zelenka a écrit : > > Hi All! > > > > Voting on jsond is now open: > > > > https://wiki.php.net/rfc/jsond > > > > It's a simple Yes/No vote whether jsond should rep

Re: [PHP-DEV] Re: [VOTE] Remove hex support in numeric strings

2015-01-26 Thread Paul Dragoonis
On 26 Jan 2015 20:02, "Nikita Popov" wrote: > > On Sat, Jan 17, 2015 at 8:40 PM, Nikita Popov wrote: > > > Hi internals! > > > > The RFC proposing to remove support for hexadecimal strings in > > is_numeric_string() is now in voting: > > > > https://wiki.php.net/rfc/remove_hex_support_in_nume

Re: [PHP-DEV] [VOTE] jsond

2015-01-26 Thread Levi Morrison
> Voting on jsond is now open: > > https://wiki.php.net/rfc/jsond > > It's a simple Yes/No vote whether jsond should replace the current json > extension in PHP 7. Before I vote I want to double-check something that I didn't find explicitly mentioned in the RFC and at a quick glance in the impleme

[PHP-DEV] Re: [VOTE] Remove hex support in numeric strings

2015-01-26 Thread Nikita Popov
On Sat, Jan 17, 2015 at 8:40 PM, Nikita Popov wrote: > Hi internals! > > The RFC proposing to remove support for hexadecimal strings in > is_numeric_string() is now in voting: > > https://wiki.php.net/rfc/remove_hex_support_in_numeric_strings > Reminder: This vote closes tomorrow. Nikita

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Derick Rethans
On Mon, 26 Jan 2015, Ferenc Kovacs wrote: > On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann wrote: > > > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > > how would YOU propose to replace it? > > > > I am not talking about replacing but removing. > > > I could accept that for pear (as comp

Re: [PHP-DEV] Dort behaviour change on php7 master

2015-01-26 Thread Rasmus Lerdorf
On 01/26/2015 11:14 AM, Pascal Chevrel wrote: > Hi all, > > I just compiled master to test my main application and the good news is > that I have no functional regression and some of the views get a > considerable speed up (like, page generation divided by two!). > > I had one unit test failing a

[PHP-DEV] Dort behaviour change on php7 master

2015-01-26 Thread Pascal Chevrel
Hi all, I just compiled master to test my main application and the good news is that I have no functional regression and some of the views get a considerable speed up (like, page generation divided by two!). I had one unit test failing and I reduced that to a simple testcase that I put there

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Pierre Joye
On Jan 27, 2015 12:03 AM, "Ferenc Kovacs" wrote: > > On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann > wrote: > > > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > > how would YOU propose to replace it? > > > > I am not talking about replacing but removing. > > > > -- > > PHP Internals - PH

[PHP-DEV] imagick on PHP 7 was Stepping stones to a working php7 ...

2015-01-26 Thread Dan Ackroyd
On 26 January 2015 at 00:02, Lester Caine wrote: > /imagick ... need to get a copy to work with Imagick is now working on 7; you will need to use the PHP 7 branch from https://github.com/mkoppanen/imagick/tree/phpseven Opening any issues you might find on Github would probably get them resolved

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Nikita Popov
On Mon, Jan 26, 2015 at 6:03 PM, Ferenc Kovacs wrote: > On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann > wrote: > > > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > > how would YOU propose to replace it? > > > > I am not talking about replacing but removing. > > > > -- > > PHP Internals

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 26, 2015 at 6:10 PM, Sebastian Bergmann wrote: > Am 26.01.2015 um 18:03 schrieb Ferenc Kovacs: > > imo we can't ship php without a tool to install additional pecl > > extensions. > > I disagree and would argue that most people do not want to build > extensions themselves and instead

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Sebastian Bergmann
Am 26.01.2015 um 18:03 schrieb Ferenc Kovacs: > imo we can't ship php without a tool to install additional pecl > extensions. I disagree and would argue that most people do not want to build extensions themselves and instead prefer binary packages provided by their OS distribution. But even i

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 26, 2015 at 3:45 PM, Sebastian Bergmann wrote: > Am 26.01.2015 um 13:56 schrieb Lester Caine: > > how would YOU propose to replace it? > > I am not talking about replacing but removing. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Sebastian Bergmann
Am 26.01.2015 um 13:56 schrieb Lester Caine: > how would YOU propose to replace it? I am not talking about replacing but removing. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PEAR-CORE] Re: [PHP-DEV] PEAR and make install on master

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 19, 2015 at 9:56 PM, Christian Weiske wrote: > Hello Xinchen, > > > > >> In PEAR/Installer/Role.php but I'm not sure where to commit the > > >> patch or how to get it into phars (they don't seem to be the > > >> latest code in git). Anybody knows what's the right way here? > > > > > >

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 26, 2015 at 1:54 PM, Sebastian Bergmann wrote: > Am 26.01.2015 um 13:51 schrieb Ferenc Kovacs: > > and bundling our own installer is only temporary, as I mentioned in the > PR > > probably there will be more BC breaks until php7 is frozen, and it would > > be clunky if we have to alwa

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Lester Caine
On 26/01/15 10:52, Sebastian Bergmann wrote: > Am 26.01.2015 um 11:31 schrieb Tony Marston: >>> PHP 7 would be a good time to cut the ties between the PHP core >>> and PEAR. Why not get rid of it completely? >> >> Because a lot of sites still use it, and you haven't provided an >> alternative which

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Sebastian Bergmann
Am 26.01.2015 um 13:51 schrieb Ferenc Kovacs: > and bundling our own installer is only temporary, as I mentioned in the PR > probably there will be more BC breaks until php7 is frozen, and it would > be clunky if we have to always wait for the official PEAR release so that > the pear installer of t

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 26, 2015 at 1:46 PM, Ferenc Kovacs wrote: > > > On Mon, Jan 26, 2015 at 11:17 AM, Sebastian Bergmann > wrote: > >> Am 26.01.2015 um 11:14 schrieb Ferenc Kovacs: >> > Commit:cfd7f5c8a3745097e0c3c3e627f6df10f2a2acdf >> > Author:Ferenc Kovacs Mon, 26 Jan 2015 >> 11:09:5

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Ferenc Kovacs
On Mon, Jan 26, 2015 at 11:17 AM, Sebastian Bergmann wrote: > Am 26.01.2015 um 11:14 schrieb Ferenc Kovacs: > > Commit:cfd7f5c8a3745097e0c3c3e627f6df10f2a2acdf > > Author:Ferenc Kovacs Mon, 26 Jan 2015 > 11:09:53 +0100 > > Parents: 8aa146b810108bde3353d9d2f8cf05a9dd012f6d > > B

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Sebastian Bergmann
Am 26.01.2015 um 11:31 schrieb Tony Marston: >> PHP 7 would be a good time to cut the ties between the PHP core >> and PEAR. Why not get rid of it completely? > > Because a lot of sites still use it, and you haven't provided an > alternative which allows modules be to added/updated/deleted through

[PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Tony Marston
"Sebastian Bergmann" wrote in message news:54c61447.9060...@php.net... Am 26.01.2015 um 11:14 schrieb Ferenc Kovacs: Commit:cfd7f5c8a3745097e0c3c3e627f6df10f2a2acdf Author:Ferenc Kovacs Mon, 26 Jan 2015 11:09:53 +0100 Parents: 8aa146b810108bde3353d9d2f8cf05a9dd012f6d Branc

[PHP-DEV] Re: [PHP-CVS] com php-src: Revert "Disable PEAR by default": configure.in

2015-01-26 Thread Sebastian Bergmann
Am 26.01.2015 um 11:14 schrieb Ferenc Kovacs: > Commit:cfd7f5c8a3745097e0c3c3e627f6df10f2a2acdf > Author:Ferenc Kovacs Mon, 26 Jan 2015 11:09:53 > +0100 > Parents: 8aa146b810108bde3353d9d2f8cf05a9dd012f6d > Branches: master > > Link: > http://git.php.net/?p=php-src.git;

[PHP-DEV] Re: PHP7 Homework for everyone reading this list

2015-01-26 Thread Arjen Schol
On 01/22/2015 06:05 PM, Rasmus Lerdorf wrote: By installing a couple of apps (Wordpress-4.1, Drupal8 and Moodle - there are still some issues in Moodle I haven't figured out yet) on a box we've tracked down some bugs over the last couple of days. It would be really useful if we got more eyes on t

Re: [PHP-DEV] PDO & size_t

2015-01-26 Thread Matteo Beccati
On 26/01/2015 03:42, Xinchen Hui wrote: On Mon, Jan 26, 2015 at 8:43 AM, Stanislav Malyshev wrote: With recent moving of string lengths to size_t, it looks like PDO APIs weren't updated. I.e.: typedef int (*pdo_stmt_get_col_data_func)(pdo_stmt_t *stmt, int colno, char **ptr, zend_ulong *len, i

Re: [PHP-DEV] [VOTE] jsond

2015-01-26 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 25/01/2015 18:29, Jakub Zelenka a écrit : > Hi All! > > Voting on jsond is now open: > > https://wiki.php.net/rfc/jsond > > It's a simple Yes/No vote whether jsond should replace the current > json extension in PHP 7. Minor notice: - - php 5.x u