On 26/01/2015 03:42, Xinchen Hui wrote:
On Mon, Jan 26, 2015 at 8:43 AM, Stanislav Malyshev <smalys...@gmail.com> wrote:
With recent moving of string lengths to size_t, it looks like PDO APIs
weren't updated. I.e.:
typedef int (*pdo_stmt_get_col_data_func)(pdo_stmt_t *stmt, int colno,
char **ptr, zend_ulong *len, int *caller_frees);
This looks like len should be size_t, and in fact fetch_value() in
pdo_stmt.c sends size_t parameter there, but since I'm not very familiar
with PDO internals, I'd like to double check - is it an omission and
will anything break if I change it to size_t?
I think it is okey, of course you should change all related apis in
pdo_* drivers
and bump:
ext/pdo/php_pdo_driver.h:#define PDO_DRIVER_API 20080721
I guess.
Cheers
--
Matteo Beccati
Development & Consulting - http://www.beccati.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
