Re: RFR [jdk8u-dev]: Add pl localization to jar tool

2015-03-25 Thread Michael Fang
o ja and zh_CN only (except "jar"). JRE resources are translated to 10 languages. These languages are "supported" because we have linguistic resource to support them if bugs are filed. thanks, -michael On 2015年03月24日 15:14, Jacob Wisor wrote: Hello Michael, Am 24.03.2015 um

Re: RFR [jdk8u-dev]: Add pl localization to jar tool

2015-03-24 Thread Michael Fang
Sorry for typo in your name, Jacob. -michael On 2015年03月24日 10:31, Michael Fang wrote: Hi Jabob, Thank you very much for contributing to the translation of native2ascii tool and jar tool. The information displayed on http://openjdk.java.net/groups/i18n was created prior to JDK8. Due to

Re: RFR [jdk8u-dev]: Add pl localization to jar tool

2015-03-24 Thread Michael Fang
Hi Jabob, Thank you very much for contributing to the translation of native2ascii tool and jar tool. The information displayed on http://openjdk.java.net/groups/i18n was created prior to JDK8. Due to Makefile updates, the localization instruction does not work anymore. We need to fix this pa

Re: [8u40] Review request for 8069122: l10n resource file update for JDK-8068491

2015-01-15 Thread Michael Fang
Thanks Naoto. -michael On 15年01月15日 04:24 下午, Naoto Sato wrote: Looks good to me. Naoto On 1/15/15, 4:13 PM, Michael Fang wrote: Hi, Please help to code review the changes for the following CR? 8069122: l10n resource file update for JDK-8068491 The webrev can be found at: http

[8u40] Review request for 8069122: l10n resource file update for JDK-8068491

2015-01-15 Thread Michael Fang
Hi, Please help to code review the changes for the following CR? 8069122: l10n resource file update for JDK-8068491 The webrev can be found at: http://cr.openjdk.java.net/~mfang/8069122/webrev.00/ The only change is changing "http" to "https" in 2 files. thanks, -michael

Re: [8u40] Review request for 8065157: jdk8u40 Japanese man page file translation update

2014-12-10 Thread Michael Fang
Thank you Naoto for the review. -michael On 14年12月10日 08:58 上午, Naoto Sato wrote: Looks good to me. Naoto On 12/9/14, 7:12 PM, Michael Fang wrote: Hi, Please help to code review the changes for the following CR: 8065157: jdk8u40 Japanese man page file translation update https

[8u40] Review request for 8065157: jdk8u40 Japanese man page file translation update

2014-12-09 Thread Michael Fang
Hi, Please help to code review the changes for the following CR: 8065157: jdk8u40 Japanese man page file translation update https://bugs.openjdk.java.net/browse/JDK-8065157 The webrev is located at: http://cr.openjdk.java.net/~mfang/8065157/webrev.00/ It's only done for 8u40 and is not ported b

Re: [8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2

2014-12-08 Thread Michael Fang
Hi Masayoshi, Thanks for the review. I decided to withdraw the proposed change in order to prevent the regression in sorting order. thanks, -michael On 14年11月26日 09:21 上午, Michael Fang wrote: Hi Masayoshi, Thank you for your review comment. This was a regular translation update from

Re: [8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2

2014-11-26 Thread Michael Fang
sorted in ja locale. The following are the old and new names sorted in ja locale. old: 韓国語 中国語 中国語(簡体字) 中国語(繁体字) 日本語 new: 簡体字中国語 韓国語 中国語 日本語 繁体字中国語 Masayoshi On 11/26/2014 4:20 AM, Michael Fang wrote: Hi, Please help to code review the changes for the following CR: 8065069: jdk8u40 l10n res

[8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2

2014-11-25 Thread Michael Fang
Hi, Please help to code review the changes for the following CR: 8065069: jdk8u40 l10n resource file translation update 2 https://bugs.openjdk.java.net/browse/JDK-8065069 The webrev is located at: http://cr.openjdk.java.net/~mfang/8065069/ thanks, -michael

Re: [9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect.

2014-11-17 Thread Michael Fang
Thanks Yuka. -michael On 14年11月17日 08:35 下午, Yuka Kamiya wrote: Hi Michael, The fix looks good to me. Thanks, -- Yuka On 2014/11/18 12:31, Michael Fang wrote: Hi, Please help to code review the changes for the following CR for jdk9: 8055798: Japanese translation for a warning from javac

[9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect.

2014-11-17 Thread Michael Fang
Hi, Please help to code review the changes for the following CR for jdk9: 8055798: Japanese translation for a warning from javac looks incorrect. https://bugs.openjdk.java.net/browse/JDK-8055798 The webrev is located at: http://cr.openjdk.java.net/~mfang/8055798/webrev.9/ thanks, -michael

Re: RFR: 8049343: (tz) Support tzdata2014g

2014-09-02 Thread Michael Fang
Aleksej, Yes, I agree the translation update of the time zone names can be handled separately as JDK-8057004. thanks, -michael On 14年09月01日 07:10 上午, Aleksej Efimov wrote: Masayoshi, I have addressed all your comments with proposed resolution. Thank you for such thorough analysis of this

Re: Review request for 8037343 Wrong dateformat for locale es_DO (backport from 9 to 8u-dev)

2014-06-13 Thread Michael Fang
Thanks Masayoshi. -michael On 14年06月13日 02:00 上午, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 6/13/2014 7:32 AM, Michael Fang wrote: Hi, I tried to backport the fix from 9 to 8u-dev. The patch applied OK except for test/sun/text/resources/LocaleDataTest.java in the bugid list

Review request for 8037343 Wrong dateformat for locale es_DO (backport from 9 to 8u-dev)

2014-06-12 Thread Michael Fang
22日 11:27 上午, Michael Fang wrote: Thanks Masayoshi. I have pushed the changeset to jdk9/dev. thanks, -michael On 14年05月21日 05:23 下午, Masayoshi Okutsu wrote: Sorry, I forgot about LocaleDataTest. The fix looks good to me. Masayoshi On 5/22/2014 9:13 AM, Michael Fang wrote: Hi all, I created

Re: RFR [9] 8043613: Update .properties files for serialver tool

2014-06-06 Thread Michael Fang
hanks, -michael On 14年06月04日 08:30 上午, Michael Fang wrote: Hi Alan, Yes, typically, we request dev team not to update l10n files (especially .rc files that are difficult to merge). But it's fine for me in this case for jdk9 since we are not planning to update the l10n resource files u

Re: RFR [9] 8043613: Update .properties files for serialver tool

2014-06-04 Thread Michael Fang
Hi Alan, Yes, typically, we request dev team not to update l10n files (especially .rc files that are difficult to merge). But it's fine for me in this case for jdk9 since we are not planning to update the l10n resource files until after feature complete. thanks, -michael On 14年06月04日 05:45

Re: 8037343 Ready for merge

2014-05-22 Thread Michael Fang
Thanks Masayoshi. I have pushed the changeset to jdk9/dev. thanks, -michael On 14年05月21日 05:23 下午, Masayoshi Okutsu wrote: Sorry, I forgot about LocaleDataTest. The fix looks good to me. Masayoshi On 5/22/2014 9:13 AM, Michael Fang wrote: Hi all, I created a test build and ran regression

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Thanks Masayoshi. Regards, Michael Sent from my iPhone > Masayoshi Okutsu 於 May 21, 2014 5:23 PM 寫道: > > Sorry, I forgot about LocaleDataTest. The fix looks good to me. > > Masayoshi > >> On 5/22/2014 9:13 AM, Michael Fang wrote: >> Hi all, >> >>

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Fang wrote: You are welcome, Sandipan. Thanks for your contribution. -michael On 14年05月21日 11:53 上午, Sandipan Razzaque wrote: Thanks Michael& team! Cheers, SR Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: Thanks Sandipan. I will work with

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
You are welcome, Sandipan. Thanks for your contribution. -michael On 14年05月21日 11:53 上午, Sandipan Razzaque wrote: Thanks Michael& team! Cheers, SR Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: Thanks Sandipan. I will work with our tea

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Thanks Sandipan. I will work with our team to import, test, and push it to jdk9. thanks, -michael On 14年05月21日 06:18 上午, Sandipan Razzaque wrote: Hi all, Take 2 - inlined into the email this time. Cheers, SR --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 2

Re: RFR: 8030822: (tz) Support tzdata2013i

2014-01-30 Thread Michael Fang
Looks good to me too. thanks, -michael On 14年01月29日 10:14 下午, Masayoshi Okutsu wrote: Looks good. Masayoshi On 1/30/2014 5:31 AM, Aleksej Efimov wrote: Masayoshi, Sean, Thank you for the review and your comments. I have prepared a second version of the fix [1] without the .properties file

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-08 Thread Michael Fang
duced using the public API. For example, two apps (client and server) running on different Java versions may not be able to perform consistent display name-based operations. Name changes should be minimized for fixing wrong names IMHO. Thanks, Masayoshi On 1/8/2014 1:02 PM, Michael Fang wrote

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-07 Thread Michael Fang
日 10:11 下午, Yong Huangwrote: Hi Michael, I think you also need to modify test/sun/text/resources/LocaleData so that those locale name change will be checked by regression test. thanks, Yong On 2014/1/8 12:02, Michael Fang wrote: Hi Masayoshi, Since the changes to the LocaleNames translation

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-07 Thread Michael Fang
ch as Jurc for Jurchen. Should this problem be out of the scope with the 8029239 fix? Thanks, Masayoshi [1] http://ja.wikipedia.org/wiki/%E4%B8%AD%E5%9B%BD_%28%E6%9B%96%E6%98%A7%E3%81%95%E5%9B%9E%E9%81%BF%29 On 12/5/2013 8:02 AM, Michael Fang wrote: Thanks Masayoshi for the feedback. I look

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2014-01-07 Thread Michael Fang
s, -michael On 14年01月07日 10:53 上午, Naoto Sato wrote: Hi Michael, jcmd.1 looks fine to me, however, what about the other two new ja man pages, i.e., jdeps and jjs? I could not find them in the artifact link you provided below. Naoto On 1/6/14, 8:06 PM, Michael Fang wrote: Found the source o

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2014-01-06 Thread Michael Fang
files can be found at: http://cr.openjdk.java.net/~mfang/8026570/solaris/ja_JP.UTF-8/man1/ http://cr.openjdk.java.net/~mfang/8026570/linux/ja_JP.UTF-8/man1/ thanks, -michael On 13年12月24日 11:15 上午, Michael Fang wrote: Thank you Masayoshi and Naoto for looking into it. About the missing space

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2013-12-24 Thread Michael Fang
words and Japanese characters have been removed. Why is that? I checked (OS native) man pages in Japanese on Solaris and Linux. They have spaces. I do prefer to have spaces. Thanks, Masayoshi On 12/23/2013 5:54 PM, Michael Fang wrote: Hi, Please help to review the changes for the following CR:

Re: RFR: 8025051: Update resource files for TimeZone display names

2013-12-23 Thread Michael Fang
Thanks Aleksej for addressing the ACT issue. The l10n files look fine to me. I agree that we should work on translation consistency issues separately the next time we have a translation cycle. thanks, -michael On 13?12?22? 10:14 ??, Aleksej Efimov wrote: Hi, The new version of patch for Time

[8] Request for review: 8026570: NLS: jdk8 man page update

2013-12-23 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026570 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026570/webrev.00/ The built man page files can be found at: http://cr.openjdk.java.net/~mfang/8026570/solaris/ja_JP.UTF-8

Re: [8] Request for review: 8026741: jdk8 l10n resource file translation update 5

2013-12-17 Thread Michael Fang
Thank you Naoto for the review. -michael On 13年12月17日 02:40 下午, Naoto Sato wrote: Looks good to me. Naoto On 11/26/13, 4:18 PM, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026741 A list of English resource files

Re: [8] Request for review: 7090826: Newly added codes need to be localized into pt_BR in LocaleNames.

2013-12-16 Thread Michael Fang
Thanks Masayoshi for the review! -michael On 13年12月16日 04:45 下午, Masayoshi Okutsu wrote: Looks good. Masayoshi On 12/13/2013 7:33 AM, Michael Fang wrote: Thanks Masayoshi for the review. I have added CS back to LocaleNames_pt.properties file, corrected LocaleData test related to CS and

Re: [8] Request for review: 7090826: Newly added codes need to be localized into pt_BR in LocaleNames.

2013-12-12 Thread Michael Fang
, Masayoshi On 12/10/2013 7:32 AM, Michael Fang wrote: Hi, Since it's a little bit complicated to review 8029239: jdk8 l10n resource file translation update - localenames, I would like to separate out the Portuguese portion out back to 7090826 Newly added codes need to be localized into

Re: [8] Request for review: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-12-11 Thread Michael Fang
Thanks Yong for the co-review! -michael On 13年12月11日 08:01 下午, Yong Huang wrote: It looks good to me. thanks, Yong On 2013/12/12 8:04, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026115 The webrev is available

Re: [8] Request for review: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-12-11 Thread Michael Fang
Thanks Naoto for the review! -michael On 13年12月11日 04:19 下午, Naoto Sato wrote: Looks good to me. Naoto On 12/11/13 4:04 PM, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026115 The webrev is available here: http

[8] Request for review: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-12-11 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026115 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026115/ thanks, -michael

[8] Request for review: 7090826: Newly added codes need to be localized into pt_BR in LocaleNames.

2013-12-09 Thread Michael Fang
Hi, Since it's a little bit complicated to review 8029239: jdk8 l10n resource file translation update - localenames, I would like to separate out the Portuguese portion out back to 7090826 Newly added codes need to be localized into pt_BR in LocaleNames. The Portuguese files are fully genera

Re: [8] Request for review: 8025974: l10n for policytool

2013-12-06 Thread Michael Fang
Thanks for the review! Regards, Michael Sent from my iPhone > On Dec 6, 2013, at 1:41 PM, Naoto Sato wrote: > > Looks good to me. > > Naoto > >> On 12/5/13, 5:15 PM, Michael Fang wrote: >> Hi, >> >> Please help to review the changes for the foll

[8] Request for review: 8025974: l10n for policytool

2013-12-05 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8025974 The webrev is available here: http://cr.openjdk.java.net/~mfang/8025974/ thanks, -michael

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2013-12-04 Thread Michael Fang
me. src/share/classes/sun/util/resources/ja/LocaleNames_ja.properties: -afa=\u30A2\u30D5\u30AC\u30CB\u30FC (1927-2002) +afa=\u30A2\u30D5\u30ED=\u30A2\u30B8\u30A2\u8A9E\u65CF Should the bug# be added to test/sun/text/resources/LocaleDataTest.java when LocaleData has been modified? Thanks, Masayoshi

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2013-12-03 Thread Michael Fang
eNames/pt/FM: file = "Micronu00e9sia" jvm = "Micron\\u00e9sia" Test failed. 2 errors. thanks, -michael On 13年12月03日 05:10 下午, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8029239 The webrev is av

[8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2013-12-03 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8029239 The webrev is available here: http://cr.openjdk.java.net/~mfang/8029239/ The changes included the following: Portuguese files were updated with resources generated from CLDR 2.1. Local

Re: [8] Request for review: 8027244: Need to translate new error message and usage information for jar tool

2013-11-27 Thread Michael Fang
Thank you Naoto for the review! -michael On 13年11月27日 10:04 上午, Naoto Sato wrote: Looks good to me. Naoto On 13-11-26 下午4:00, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8027244 The webrev is available here: http

[8] Request for review: 8026741: jdk8 l10n resource file translation update 5

2013-11-26 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026741 A list of English resource files were sent to translation vendors for translation update periodically that's why these l10n resource files have been updated. You do not need to review

[8] Request for review: 8027244: Need to translate new error message and usage information for jar tool

2013-11-26 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8027244 The webrev is available here: http://cr.openjdk.java.net/~mfang/8027244/ Only 2 lines were changed in each file which corresponded to the changes in English jar.properties file: http:/

Re: [8] Request for review: 8028803: jdk8 l10n resource file translation update 5 - jaxp repo

2013-11-21 Thread Michael Fang
that. Thanks, Joe On 11/21/2013 3:12 PM, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8028803 A list of English resource files are sent to translation vendors for translation update periodically that's why these l10

[8] Request for review: 8028803: jdk8 l10n resource file translation update 5 - jaxp repo

2013-11-21 Thread Michael Fang
Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8028803 A list of English resource files are sent to translation vendors for translation update periodically that's why these l10n resource files have been updated. You do not need to review

Re: Add Arabic Language -- or other languages to rt.jar

2013-11-19 Thread Michael Fang
: Hi Michael, An updated list of instructions will be great! .. Actually we plan to translate *all* the needed strings in JRE and JDK .. but for now we will start with the resource files in rt.jar On 15 November 2013 20:42, Michael Fang <mailto:michael.f...@oracle.com>> wrote:

Re: Add Arabic Language

2013-11-15 Thread Michael Fang
Hi Nashwan, We provided localization instructions around JDK6/7 time at the following URL: http://openjdk.java.net/groups/i18n/ However, there was lack of interest, so we did not continue with the project. The instructions is outdated now. If there is still interest in adding translation for

Re: Review Request - 8027695: There should be a space before % sign in Swedish locale

2013-11-07 Thread Michael Fang
It also looks good to me. thanks, -michael On 13年11月07日 11:46 上午, Naoto Sato wrote: Looks good. Naoto On 11/6/13 9:54 PM, Yong Huang wrote: Hello, Please review the fix of https://bugs.openjdk.java.net/browse/JDK-8027695 The webrev is http://cr.openjdk.java.net/~yhuang/8027695/webrev.00

Re: [8]: diff patch for jdk test on a non US platform

2013-11-04 Thread Michael Fang
Hi Francis, I am the one coordinating the translation of resource files. I have asked the translators about the extra space in the past for another file and they replied: Please note that this is not an error but a French standard. In French, we use a space before a colon. Typically, we do n

Re: [8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Michael Fang
of them with some script execution (might be wrong). So first can you check with them whether they will do this kind of clean up at the end? If not, can you fix not only this instance but all other unnecessary spaces in resource files? Naoto On 10/29/13 11:59 PM, Michael Fang wrote: Hello

[8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6931564 The webrev is available here: http://cr.openjdk.java.net/~mfang/6931564/ (Please ignore the part for 6192407 which shares the same regression test program) The diff is not very obvi

[8] Request for review: 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" window

2013-10-29 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6192407 The webrev is available here: http://cr.openjdk.java.net/~mfang/6192407/ thanks, -michael

i18n-dev@openjdk.java.net

2013-10-29 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8025521 The webrev is available here: http://cr.openjdk.java.net/~mfang/8025521/ The fix has been tested in a private build. thanks, -michael

[8] Request for review: 8008647: [es] minor cosmetic issues in translated java command line outputs

2013-10-29 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8008647 The webrev is available here: http://cr.openjdk.java.net/~mfang/8008647/ The webrev doesn't show anything. The change is only adding a space on usage between "-x" and "e

Re: [8] Request for review: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-10-29 Thread Michael Fang
ddition, should be translated to <文件> in the following? Other 's are translated. 67 {".certchain.file.name.of.alternative.certchain.file", 68 "[-certchain ] 替代 certchain 文件 的名称"}, Thanks, Masayoshi On 10/29/2013 2:25 PM, Mi

[8] Request for review: 8025646: [pt_BR] overtranslation of option in java command line output

2013-10-28 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8025646 The webrev is available here: http://cr.openjdk.java.net/~mfang/8025646/ The change is in: FROM -verbose:[classe|gc|jni]\n TO -verbose:[class|gc|jni]\n thanks! -michae

[8] Request for review: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-10-28 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026115 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026115/ thanks! -michael

[8] Request for review: 8026108: [it, ja, zh_CN] wrong translation in jar example.

2013-10-28 Thread Michael Fang
Hello, Please help to review the changes (3 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026108 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026108/ The issue was about missing a dot (or translated

[8] Request for review: 8008437: [sv] over-translation in java command line outputs

2013-10-28 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8008437 The webrev is available here: http://cr.openjdk.java.net/~mfang/8008437/

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
On 10/24/2013 12:12 AM, Michael Fang wrote: Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 <https://bugs.openjdk.java.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch locat

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-23 Thread Michael Fang
Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 , I believe we can remove t

[8] Request for review: 8026109: [ja] overtranslation of jarsigner in command line output

2013-10-22 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026109 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026109/ thanks! -michael

Re: [8] Request for review: 6607048: clear extra l10n resource files in demo

2013-10-22 Thread Michael Fang
Thanks Naoto for the review. -michael On 13年10月22日 11:21 上午, Naoto Sato wrote: Looks good to me. Naoto On 10/22/13 10:40 AM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: <https://bugs.openjdk.java.net/browse/JDK-6607048>https://bugs.openjdk.ja

[8] Request for review: 6607048: clear extra l10n resource files in demo

2013-10-22 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6607048 The webrev is available here: http://cr.openjdk.java.net/~mfang/6607048/webrev.00/ Unit testing has been performed by yhuang. thanks

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-16 Thread Michael Fang
Hi Aleksej and Masayoshi, The translation of the timezone names are correct according to the translators. So, the files in your webrev look fine to me. thanks, -michael On 13年10月14日 10:19 下午, Michael Fang wrote: Hi Masayoshi, I am not sure if the changes are correct. I need to check with

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-14 Thread Michael Fang
2. I need another one approval from a JDK 8 reviewer for this one. Anyway, the hg changeset patch can be found here: http://cr.openjdk.java.net/~aefimov/8025255/8/8025255_jdk8.patch Best Regards, Aleksej On 10/12/2013 12:43 AM, Michael Fang wrote: Hi Aleksej, Yes, you are right. They can be han

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
browse/JDK-8025051. I will work on it right > after the tzdata update and it will include this changes. > But anyway, it's not highly related to tzdata updates. I think, this two > processes can go separately. Do you agree? > > Thanks and Best Regards, > Aleksej > >

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
Hi Aleksej, I took a look at the localized TimeZoneNames_*.java files. They do not contain generic time zone names for JSR310... I think we can file a separate bug to track that issue. thanks, -michael On 13年10月10日 09:54 下午, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments.

[8]Request for review: 8025215: jdk8 l10n resource file translation update 4

2013-09-22 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8025215 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-18 Thread Michael Fang
Thanks Joe. -michael On 06/18/13 22:44, huizhe wang wrote: Looks great! Thanks for taking the time to fix the legal notice. -Joe On 6/18/2013 10:41 PM, Michael Fang wrote: Hi Joe, I have updated the copyright. The webrev has been updated at: http://cr.openjdk.java.net/~mfang/8016824

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-18 Thread Michael Fang
Hi Joe, I have updated the copyright. The webrev has been updated at: http://cr.openjdk.java.net/~mfang/8016824/webrev.jaxp.01/ thanks, -michael On 06/18/13 10:13, Michael Fang wrote: Hi Joe, I see. This is not part of automated translation process. Let me see what I can do. thanks

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread Michael Fang
Thanks Naoto for the review. -michael On 06/18/13 11:52, Naoto Sato wrote: Looks good to me. Naoto On 6/17/13 10:42 PM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-18 Thread Michael Fang
an to do in the next project). The other language files were added by Oracle, reflecting the internationalization effort by Oracle. I think those Oracle copyright headers shouldn't have been removed. Thanks, Joe On 6/18/2013 9:50 AM, Michael Fang wrote: Hi Joe, The translation tea

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-18 Thread Michael Fang
source file, others were added by Oracle. -Joe On 6/17/2013 10:56 PM, Michael Fang wrote: Hi Joe, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8016824 A list of English resource files are sent to translation group for translation update

Re: [8] Request for review: 8011870: i18n translations for JDK-8009636

2013-06-18 Thread Michael Fang
k. Thanks Max -Joe On 6/17/2013 11:02 PM, Michael Fang wrote: Hi Joe and all, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8011870 The webrev is available here: http://cr.openjdk.java.net/~mfang/8011870/ It's part of webrev for 8015657: jdk8

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-17 Thread Michael Fang
. thanks, Yong On 2013/6/18 13:42, Michael Fang wrote: Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are sent to translation group for translation update periodically that's why these l10n res

[8] Request for review: 8011870: i18n translations for JDK-8009636

2013-06-17 Thread Michael Fang
Hi Joe and all, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8011870 The webrev is available here: http://cr.openjdk.java.net/~mfang/8011870/ It's part of webrev for 8015657: jdk8 l10n resource file translation update 3 Please only look at the

[8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-17 Thread Michael Fang
Hi Joe, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8016824 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review

[8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-17 Thread Michael Fang
Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review t

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
Thanks Naoto for the review. JDK-8010782 <https://jbs.oracle.com/bugs/browse/JDK-8010782> has been created to track the Windows new line character issue (^M) thanks, -michael On 13年03月25日 02:41 下午, Naoto Sato wrote: On 3/25/13 2:29 PM, Michael Fang wrote: Hi Naoto, After further

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
have uploaded updated webrev: http://cr.openjdk.java.net/~mfang/8010521/webrev.jdk.01/ thanks, -michael On 13年03月25日 01:03 下午, Naoto Sato wrote: On 3/25/13 12:50 PM, Michael Fang wrote: Hi Naoto, Thank you so much for your review. Please see my comments inline below. thanks, -michael On 13年

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
e automatically filtered out those resources during translation process. Another option is to ask dev team not to use these ALL CAPS words in order to meet the t13y (translatability) requirements. Naoto On 3/22/13 4:18 PM, Michael Fang wrote: Hello, Please help to review the changes for th

[8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-22 Thread Michael Fang
Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8010521 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review t

Re: [8] Code review request: 8000983 and 8003267

2012-12-11 Thread Michael Fang
request about the translatable format, but I haven't had a chance to address it. The format hasn't changed. Sorry about this. Masayoshi On 12/10/2012 2:23 PM, Michael Fang wrote: Hi Okutsu-san, Do you have a way to provide some sort of converter to make time zone name translation t

Re: [8] Code review request: 8000983 and 8003267

2012-12-09 Thread Michael Fang
Hi Okutsu-san, Do you have a way to provide some sort of converter to make time zone name translation that can be handled by WPTG translation team? They currently cannot translate the file in existing format (they can translate properties files or basic java resource bundles). thanks, -mich

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-11 Thread Michael Fang
Thanks Mark for the comment. Yes, we will do that. thanks, -michael On 12年09月11日 08:09 上午, mark.reinh...@oracle.com wrote: 2012/9/10 14:26 -0700, michael.f...@oracle.com: I have updated the webrev: http://cr.openjdk.java.net/~mfang/7196354/webrev.01/ ... I am also moving the file from root

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-10 Thread Michael Fang
hrough JEP process. We would like to keep the syntax internal. When I review dev team's changes related to resource files, I will keep an eye on the files to be translated and translation language scope. thanks, -michael Server Globalization Technology On 12年09月06日 04:46 下午, Michael Fang

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-06 Thread Michael Fang
Hi Mark, Thanks for the review and feedback. Please see my comments inline below. thanks, -michael On 12年09月06日 01:29 下午, mark.reinh...@oracle.com wrote: 2012/9/5 14:08 -0700, michael.f...@oracle.com: Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom fi

[8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-05 Thread Michael Fang
Hello, Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom file to openjdk repo The webrev is located at: http://cr.openjdk.java.net/~mfang/7196354/webrev.00/ Build-dev: The file will be pushed to the top level openjdk repository http://hg.openjdk.java.net/j

hg: jdk8/l10n/langtools: 19 new changesets

2012-08-13 Thread michael . fang
Changeset: a39c99192184 Author:katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/l10n/langtools/rev/a39c99192184 Added tag jdk8-b44 for changeset 59cbead12ff4 ! .hgtags Changeset: 9cafabb5e576 Author:ksrini Date: 2012-06-11 15:33 -0700 URL:

hg: jdk8/l10n/jaxws: 7 new changesets

2012-08-13 Thread michael . fang
Changeset: e80ac58b5ba9 Author:katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/l10n/jaxws/rev/e80ac58b5ba9 Added tag jdk8-b44 for changeset f6a417540ef1 ! .hgtags Changeset: ae368a83c240 Author:katleman Date: 2012-06-28 09:32 -0700 URL: ht

hg: jdk8/l10n/corba: 18 new changesets

2012-08-13 Thread michael . fang
Changeset: ad3ba4b392cc Author:katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/l10n/corba/rev/ad3ba4b392cc Added tag jdk8-b44 for changeset 439d9bf8e4ff ! .hgtags Changeset: 5222b7d658d4 Author:coffeys Date: 2012-03-26 14:01 +0100 URL: htt

hg: jdk8/l10n: 21 new changesets

2012-08-13 Thread michael . fang
Changeset: 8fb4cd2f05a1 Author:mbykov Date: 2012-06-19 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/l10n/rev/8fb4cd2f05a1 7178241: Basic script for JDK source code legal headers conformance verification Summary: A new script lic_check.sh to check license headers in JDK source co

Re: Venezuela Currency has been changed to BS.F. now

2012-08-13 Thread Michael Fang
Hi Yong, I have pushed the changeset to "build" forest: http://hg.openjdk.java.net/jdk8/build/jdk Build infrastructure team will then push the changesets to master on their weekly push. I will now sync up l10n forest with "build" forest. It has not been synced in a while and you will proba

hg: jdk8/l10n/corba: 38 new changesets

2012-06-18 Thread michael . fang
Changeset: 79f709a099f4 Author:katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/l10n/corba/rev/79f709a099f4 Added tag jdk8-b25 for changeset e45d6b406d5f ! .hgtags Changeset: 4fffe75e4edd Author:katleman Date: 2012-02-16 13:01 -0800 URL: ht

hg: jdk8/l10n: 49 new changesets

2012-06-18 Thread michael . fang
Changeset: 2accafff224a Author:katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/l10n/rev/2accafff224a Added tag jdk8-b25 for changeset 221a378e06a3 ! .hgtags Changeset: 1533dfab9903 Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://h

  1   2   3   >