Looks good to me too.
thanks,
-michael
On 14年01月29日 10:14 下午, Masayoshi Okutsu wrote:
Looks good.
Masayoshi
On 1/30/2014 5:31 AM, Aleksej Efimov wrote:
Masayoshi, Sean,
Thank you for the review and your comments.
I have prepared a second version of the fix [1] without the
.properties files. These files are used in
test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNamesTest.java
test and because of that this test was removed also.
Thank you,
Aleksej
[1] http://cr.openjdk.java.net/~aefimov/8030822/9/webrev.01/
<http://cr.openjdk.java.net/%7Eaefimov/8030822/9/webrev.01/>
On 01/23/2014 08:43 AM, Masayoshi Okutsu wrote:
Hi Aleksej,
I think this one is the first tzdata change for JDK9. So I'd suggest
that all the TimeZoneNames*.properties files, which were temporarily
created for the translation work, be removed.
Thanks,
Masayoshi
On 1/21/2014 10:17 PM, Aleksej Efimov wrote:
Hi,
Can I have a review for 2013i timezone data integration [1] to JDK9.
There is one change in tzdb that affects naming for "Asia/Amman"
timezone:
"The Jordan switches back to standard time at 00:00 on December 20,
2013."
All changes in TimeZoneNames*.java and TimeZoneNames*.properties
files are related to this one tzdb change.
The list of executed regression test sets: test/sun/util/calendar
test/java/util/Calendar test/sun/util/resources/TimeZone
test/sun/util/calendar test/java/util/TimeZone test/java/time
test/java/util/Formatter test/closed/java/util/Calendar
test/closed/java/util/TimeZone
All tests gave PASS result.
Webrev location:
http://cr.openjdk.java.net/~aefimov/8030822/9/webrev.00/
Thank you,
Aleksej
[1] https://bugs.openjdk.java.net/browse/JDK-8030822
