Hi,

I tried to backport the fix from 9 to 8u-dev. The patch applied OK except for test/sun/text/resources/LocaleDataTest.java in the bugid list section.

Please help to review the manual merge of test/sun/text/resources/LocaleDataTest.java (one line only).

jdk9 webrev (reference): http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ <http://cr.openjdk.java.net/%7Emfang/8037343/webrev.00/> jdk8u-dev webrev (to review): http://cr.openjdk.java.net/~mfang/8037343/8u20/webrev.00/ <http://cr.openjdk.java.net/%7Emfang/8037343/8u20/webrev.00/>

thanks,

-michael


On 14年05月22日 11:27 上午, Michael Fang wrote:
Thanks Masayoshi. I have pushed the changeset to jdk9/dev.

thanks,

-michael

On 14年05月21日 05:23 下午, Masayoshi Okutsu wrote:
Sorry, I forgot about LocaleDataTest. The fix looks good to me.

Masayoshi

On 5/22/2014 9:13 AM, Michael Fang wrote:
Hi all,

I created a test build and ran regression tests. LocaleDataTest failed. I have updated the test data related to this bug fix. Please review the changes related to LocaleDataTest.

http://cr.openjdk.java.net/~mfang/8037343/webrev.00/

thanks,

-michael

On 14年05月21日 12:15 下午, Michael Fang wrote:
You are welcome, Sandipan.

Thanks for your contribution.

-michael

On 14年05月21日 11:53 上午, Sandipan Razzaque wrote:
Thanks Michael&  team!

Cheers,
SR
Sandipan Razzaque | www.sandipan.net


On Wed, May 21, 2014 at 2:02 PM, Michael Fang<michael.f...@oracle.com> wrote:
Thanks Sandipan.

I will work with our team to import, test, and push it to jdk9.

thanks,

-michael

On 14年05月21日 06:18 上午, Sandipan Razzaque wrote:
Hi all,

Take 2 - inlined into the email this time.

Cheers,
SR

--- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java
2014-05-14 22:28:33.393717389 -0400
+++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java
2014-05-14 22:28:33.277717384 -0400
@@ -75,8 +75,8 @@
                   new String[] {
"EEEE d' de 'MMMM' de 'yyyy", // full date pattern "d' de 'MMMM' de 'yyyy", // long date pattern
-                    "MM/dd/yyyy", // medium date pattern
-                    "MM/dd/yy", // short date pattern
+                    "dd/MM/yyyy", // medium date pattern
+                    "dd/MM/yy", // short date pattern
                   }
               },
               { "DateTimePatterns",
--- /dev/null 2014-05-11 05:40:37.233580026 -0400
+++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14
22:28:33.713717403 -0400
@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but
WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file
that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License
version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065
USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8037343
+ * @summary updating dateformat for es_DO
+ */
+
+import java.text.DateFormat;
+import java.util.Calendar;
+import java.util.Locale;
+
+public class Bug8037343
+{
+
+    public static void main(String[] arg)
+    {
+        final Locale esDO = new Locale("es", "DO");
+        final String expectedShort = "31/03/12";
+        final String expectedMedium = "31/03/2012";
+
+        int errors = 0;
+        DateFormat format;
+        String result;
+
+        Calendar cal = Calendar.getInstance(esDO);
+        cal.set(Calendar.DAY_OF_MONTH, 31);
+        cal.set(Calendar.MONTH, Calendar.MARCH);
+        cal.set(Calendar.YEAR, 2012);
+
+ format = DateFormat.getDateInstance(DateFormat.SHORT, esDO);
+        result = format.format(cal.getTime());
+        if (!expectedShort.equals(result)) {
+ System.out.println(String.format("Short Date format for es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort,
result));
+            errors++;
+        }
+
+ format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO);
+        result = format.format(cal.getTime());
+        if (!expectedMedium.equals(result)) {
+ System.out.println(String.format("Medium Date format for
es_DO is not as expected. Expected: [%s] Actual: [%s]",
expectedMedium, result));
+            errors++;
+        }
+
+        if (errors>   0) {
+            throw new RuntimeException();
+        }
+    }
+
+}





Sandipan Razzaque | www.sandipan.net


On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque<m...@sandipan.net>
wrote:
Hi all,

Patch 8037343 has been reviewed and is ready for merge. Please find it
attached to this email.

Cheers,
SR

Sandipan Razzaque | www.sandipan.net

Reply via email to