Thanks Masayoshi for the review.

I have added CS back to LocaleNames_pt.properties file, corrected LocaleData test related to CS and corrected the CLDR version number, which is 21.0.1.

The new webrev is:
http://cr.openjdk.java.net/~mfang/7090826/webrev.01/

JPRT build also completed successfully and passed the core testset.

thanks,

-michael

On 13年12月11日 08:14 下午, Masayoshi Okutsu wrote:
src/share/classes/sun/util/resources/pt/LocaleNames_pt.properties:

Looks like CS (transitionally reserved) has been removed and fallback is expected. But CS seems to be still alive in other locales according to the 8029239 webrev. I think it should be consistent with other locales (either remove CS from all locales or keep it in pt).

test/sun/text/resources/LocaleData:

+#bug 7090826 pt data updated to CLDR 2.1

Should the CLDR version be 21?

Otherwise, the fix looks good to me.

Thanks,
Masayoshi

On 12/10/2013 7:32 AM, Michael Fang wrote:
Hi,

Since it's a little bit complicated to review 8029239: jdk8 l10n resource file translation update - localenames, I would like to separate out the Portuguese portion out back to 7090826 Newly added codes need to be localized into pt_BR in LocaleNames.

The Portuguese files are fully generated from CLDR, so it should be relatively easy to review. LocaleNames_pt_BR.properties have been removed as a result since CLDR doesn't have a separate pt_BR.xml file now.

Please help to review the changes for the following CR:
https://bugs.openjdk.java.net/browse/JDK-7090826

The webrev is available here:
http://cr.openjdk.java.net/~mfang/7090826/webrev.00/

thanks,

-michael


Reply via email to