Re: Fw: gettext support

2009-06-26 Thread Carles Pina i Estany
Hi, On Jun/26/2009, Robert Millan wrote: > Also, if *.mo files contain plain text, compression would work well on > them. They could be gzipped. Yes, they contain plain text. I implemented gettext without the hashtable (the .mo files usually has a hashtable for the search). We will not have l

Re: Fw: gettext support

2009-06-26 Thread Pavel Roskin
On Fri, 2009-06-26 at 14:47 +0200, Robert Millan wrote: > On Thu, Jun 25, 2009 at 11:09:02PM -0400, Pavel Roskin wrote: > > > > My main concern is the size of the files we install in /boot/grub. It's > > approaching one megabyte already, > > We don't need to do that just because of OFW. I think

Re: Fw: gettext support

2009-06-26 Thread Robert Millan
On Thu, Jun 25, 2009 at 11:09:02PM -0400, Pavel Roskin wrote: > > My main concern is the size of the files we install in /boot/grub. It's > approaching one megabyte already, We don't need to do that just because of OFW. I think the approach of installing /boot/grub/ to that tiny filesystem is j

Re: Fw: gettext support

2009-06-25 Thread Pavel Roskin
On Thu, 2009-06-25 at 22:20 +0100, Carles Pina i Estany wrote: > IMHO: b1 looks more professional/nicer and complete than b2, that looks > like a quick-patch, no? But both has similar results. I realize now that the comparison with the kernel was wrong. The kernel output can be hidden from the u

Re: Fw: gettext support

2009-06-25 Thread Carles Pina i Estany
Hello, On Jun/21/2009, Pavel Roskin wrote: [picking up your message just to get one] > Do we really need to localize the bootloader? I think localization of > the tools should be sufficient. So, what we can do?: a1) add i18n support to the userland scripts b1) apply (and finish the building

Re: Fw: gettext support

2009-06-24 Thread Jordi Mallach
On Tue, Jun 23, 2009 at 12:45:39PM +0200, Javier Martín wrote: > Why not? A msgid does not necessarily mean a \n, you can printf("%s %s", > _("first"), _("second")) just OK without an intervening line break. In > this particular case the gettext "directives" [0] don't tell us either > to merge or s

Re: Fw: gettext support

2009-06-23 Thread Javier Martín
El mar, 23-06-2009 a las 12:05 +0200, Jordi Mallach escribió: > On Mon, Jun 22, 2009 at 09:42:17PM +0200, Javier Martín wrote: > > > msgid "Use the %C and %C keys to select which entry is highlighted." > > > msgid "Press enter to boot the selected OS, 'e' to edit the" > > > msgid "commands before b

Re: Fw: gettext support

2009-06-23 Thread Jordi Mallach
On Mon, Jun 22, 2009 at 09:42:17PM +0200, Javier Martín wrote: > > msgid "Use the %C and %C keys to select which entry is highlighted." > > msgid "Press enter to boot the selected OS, 'e' to edit the" > > msgid "commands before booting or 'c' for a command-line." > Actually, the first string could

Re: Fw: gettext support

2009-06-22 Thread Javier Martín
El lun, 22-06-2009 a las 21:03 +0200, Jordi Mallach escribió: > What is VERY important is that all the \n lines are part of a single msgid. > What would be problematic (really!) would be something like: > > msgid "Use the %C and %C keys to select which entry is highlighted." > msgid "Press enter t

Re: Fw: gettext support

2009-06-22 Thread Jordi Mallach
On Sun, Jun 21, 2009 at 11:18:08PM +0200, Robert Millan wrote: > > +" Use the %C and %C keys to select which entry is highlighted.\n" > > > > +" Press enter to boot the selected OS, 'e' to edit the\n" > > +" commands before booting or 'c' for a command-line." > Uhm this string seems

Re: Fw: gettext support

2009-06-22 Thread Colin Watson
On Mon, Jun 22, 2009 at 11:39:56AM +0200, Robert Millan wrote: > On Sun, Jun 21, 2009 at 07:42:13PM -0400, Pavel Roskin wrote: > > Actually, Colin D Bennett posted a link to a proposal to eliminate that > > text. That's the link to the screenshots: > > > > http://ubuntuforums.org/showpost.php?p=7

Re: Fw: gettext support

2009-06-22 Thread Robert Millan
On Sun, Jun 21, 2009 at 07:42:13PM -0400, Pavel Roskin wrote: > On Sun, 2009-06-21 at 22:09 +0100, Carles Pina i Estany wrote: > > > > Do we really need to localize the bootloader? I think localization of > > > the tools should be sufficient. > > > > By the moment I translated this string (as an

Re: Fw: gettext support

2009-06-21 Thread Pavel Roskin
On Sun, 2009-06-21 at 22:09 +0100, Carles Pina i Estany wrote: > > Do we really need to localize the bootloader? I think localization of > > the tools should be sufficient. > > By the moment I translated this string (as an example): > +" Use the %C and %C keys to select which entry is highl

Re: Fw: gettext support

2009-06-21 Thread Colin Watson
On Mon, Jun 22, 2009 at 12:47:15AM +0200, Robert Millan wrote: > On Sun, Jun 21, 2009 at 11:31:57PM +0100, Carles Pina i Estany wrote: > > On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote: > > > On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany > > > wrote: > > > Actually I think it would

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Sun, Jun 21, 2009 at 11:31:57PM +0100, Carles Pina i Estany wrote: > On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote: > > On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany > > wrote: > > Actually I think it would be a good move to provide translations of e.g. > > error strings, output

Re: Fw: gettext support

2009-06-21 Thread Carles Pina i Estany
Hi, On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany wrote: > > > > > Hi, > > > > On Jun/21/2009, Robert Millan wrote: > > > > > Sounds like an interesting option. It's a pity you already spent the > > effort > > > on implementing get

Re: Fw: gettext support

2009-06-21 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany wrote: > > Hi, > > On Jun/21/2009, Robert Millan wrote: > > > Sounds like an interesting option. It's a pity you already spent the > effort > > on implementing gettext in grub side, though :-( > > Yes it's pity, but I will not force to use wh

Re: Fw: gettext support

2009-06-21 Thread Carles Pina i Estany
Hi, On Jun/21/2009, Robert Millan wrote: > Sounds like an interesting option. It's a pity you already spent the effort > on implementing gettext in grub side, though :-( Yes it's pity, but I will not force to use what I implemented if now we think something better. So we can discuss that I wil

Re: Fw: gettext support

2009-06-21 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 21, 2009 at 11:09 PM, Carles Pina i Estany wrote: > Well, we could have another approach and this is also nice: > > _all_ strings that appears in a normal boot process (like the ones that > I showed above) are part of the grub.cfg file. So, when grub.cfg file is > generated we could ha

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Sun, Jun 21, 2009 at 10:09:14PM +0100, Carles Pina i Estany wrote: > > > > Do we really need to localize the bootloader? I think localization of > > the tools should be sufficient. > > By the moment I translated this string (as an example): > +" Use the %C and %C keys to select which ent

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Sun, Jun 21, 2009 at 03:14:59PM -0400, Pavel Roskin wrote: > > Do we really need to localize the bootloader? I think localization of > the tools should be sufficient. > > Even Linux kernel is not localized, and it's more likely to tell the > user something important than the bootloader. Besi

Re: Fw: gettext support

2009-06-21 Thread Carles Pina i Estany
Hola, On Jun/21/2009, Pavel Roskin wrote: > On Sun, 2009-06-21 at 20:42 +0200, Robert Millan wrote: > > On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote: > > > > > It's not a problem. We need two locations anyway: one where make > > > > > install > > > > > copies them and the

Re: Fw: gettext support

2009-06-21 Thread Pavel Roskin
On Sun, 2009-06-21 at 20:42 +0200, Robert Millan wrote: > On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote: > > > > It's not a problem. We need two locations anyway: one where make install > > > > copies them and the other one where ./grub-install copies them. Would > > > > it

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote: > > > It's not a problem. We need two locations anyway: one where make install > > > copies them and the other one where ./grub-install copies them. Would it > > > be > > > possible to use /usr/share/grub/locale/$LANG.mo rather

Re: Fw: gettext support

2009-06-21 Thread Carles Pina i Estany
Hello, On Jun/21/2009, Robert Millan wrote: > On Fri, Jun 19, 2009 at 12:42:26PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Fri, Jun 19, 2009 at 12:37 PM, Robert Millan wrote: > > > > > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote: > > > > > > -Copy ca.mo

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Fri, Jun 19, 2009 at 04:32:35PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > - lose, and get the C locale messages > > - try to set it up using the correct grub device that contains the > > locales. > > What if partition is in btrfs? Well, now I think using $prefix/locale is not that bad.

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Sat, Jun 20, 2009 at 12:08:44AM +0100, Carles Pina i Estany wrote: > > a) I afraid that having the .mo files in /usr/share/... makes Grub > quite much tight to GNU/Linux. In my opinion, boot loaders should be as > much as operating system agnostic as could be. Sounds like a good point. I don

Re: Fw: gettext support

2009-06-21 Thread Robert Millan
On Fri, Jun 19, 2009 at 12:42:26PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Fri, Jun 19, 2009 at 12:37 PM, Robert Millan wrote: > > > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote: > > > > > -Copy ca.mo to /usr/share/locale/ca/LC_MESSAGES/grub.mo > > > > > >

Re: Fw: gettext support

2009-06-19 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jun 20, 2009 at 1:13 AM, Carles Pina i Estany wrote: > > Hi, > > On Jun/19/2009, Vladimir 'phcoder' Serbinenko wrote: > > On Thu, Jun 18, 2009 at 11:07 PM, Carles Pina i Estany >wrote: > > > > > > > > Hi, > > > > > > On Jun/18/2009, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > If yo

Re: Fw: gettext support

2009-06-19 Thread Carles Pina i Estany
Hi, On Jun/19/2009, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jun 18, 2009 at 11:07 PM, Carles Pina i Estany wrote: > > > > > Hi, > > > > On Jun/18/2009, Vladimir 'phcoder' Serbinenko wrote: > > > > > If you want I'll add compilation po to mo to build system. > > > > this would be very nice

Re: Fw: gettext support

2009-06-19 Thread Carles Pina i Estany
Hi, On Jun/19/2009, Robert Millan wrote: > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote: > > > > -Copy ca.mo to /usr/share/locale/ca/LC_MESSAGES/grub.mo > > > > > > Languages files should go to a subdir of $PREFIX. E.g. to > > > $PREFIX/langs/$LANG.mo linux direc

Re: Fw: gettext support

2009-06-19 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 18, 2009 at 11:07 PM, Carles Pina i Estany wrote: > > Hi, > > On Jun/18/2009, Vladimir 'phcoder' Serbinenko wrote: > > > If you want I'll add compilation po to mo to build system. > > this would be very nice and speed up the process :-) > > As it's written in the TODO in grub/po, we ne

Re: Fw: gettext support

2009-06-19 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jun 19, 2009 at 3:55 PM, Jordi Mallach wrote: > On Fri, Jun 19, 2009 at 12:37:47PM +0200, Robert Millan wrote: > > > Now the gettext module will search in $prefix/locale/lang.mo, where > lang > > > is the variable that the user will setup in grub.cfg (e.g. ca for > > > catalan) and $prefi

Re: Fw: gettext support

2009-06-19 Thread Jordi Mallach
On Fri, Jun 19, 2009 at 12:37:47PM +0200, Robert Millan wrote: > > Now the gettext module will search in $prefix/locale/lang.mo, where lang > > is the variable that the user will setup in grub.cfg (e.g. ca for > > catalan) and $prefix is usually /boot/grub > Uhm I'm not sure I agree on this one. S

Re: Fw: gettext support

2009-06-19 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jun 19, 2009 at 12:37 PM, Robert Millan wrote: > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote: > > > > -Copy ca.mo to /usr/share/locale/ca/LC_MESSAGES/grub.mo > > > > > > Languages files should go to a subdir of $PREFIX. E.g. to > > > $PREFIX/langs/$LANG.mo

Re: Fw: gettext support

2009-06-19 Thread Robert Millan
On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote: > > > -Copy ca.mo to /usr/share/locale/ca/LC_MESSAGES/grub.mo > > > > Languages files should go to a subdir of $PREFIX. E.g. to > > $PREFIX/langs/$LANG.mo linux directories may be inaccessible > > Now the gettext modu

Re: Fw: gettext support

2009-06-19 Thread Robert Millan
On Thu, Jun 18, 2009 at 04:45:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > If you want I'll add compilation po to mo to build system. That would be very nice. The build system part looks like the part that would be easiest, but TBH I'm totally clueless on what would be the proper way to do

Re: Fw: gettext support

2009-06-18 Thread Carles Pina i Estany
Hi, On Jun/18/2009, Vladimir 'phcoder' Serbinenko wrote: > If you want I'll add compilation po to mo to build system. this would be very nice and speed up the process :-) As it's written in the TODO in grub/po, we need: -Compile all .po to .mo (msgfmt $LANG.po -o $LANG.mo) (during the make of

Re: Fw: gettext support

2009-06-18 Thread Carles Pina i Estany
Hello, On Jun/17/2009, Vladimir 'phcoder' Serbinenko wrote: > Hello > > > > Comments for next steps to commit the patch are welcomed. > > Quick look revealed that you haven't taken into account my comments exposed > here: http://lists.gnu.org/archive/html/grub-devel/2009-04/msg00181.html I w

Re: Fw: gettext support

2009-06-18 Thread Carles Pina i Estany
Hi, On Jun/18/2009, Robert Millan wrote: > On Wed, Jun 17, 2009 at 09:29:13PM +0100, Carles Pina i Estany wrote: > > > > Hi, > > > > On Jun/17/2009, Vladimir 'phcoder' Serbinenko wrote: > > > Hello > > > > > > > > > > Comments for next steps to commit the patch are welcomed. > > > > > > Quic

Re: Fw: gettext support

2009-06-18 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 18, 2009 at 3:38 PM, Robert Millan wrote: > On Wed, Jun 17, 2009 at 09:29:13PM +0100, Carles Pina i Estany wrote: >> >> Hi, >> >> On Jun/17/2009, Vladimir 'phcoder' Serbinenko wrote: >> > Hello >> > >> > >> > > Comments for next steps to commit the patch are welcomed. >> > >> > Quick lo

Re: Fw: gettext support

2009-06-18 Thread Robert Millan
On Wed, Jun 17, 2009 at 09:29:13PM +0100, Carles Pina i Estany wrote: > > Hi, > > On Jun/17/2009, Vladimir 'phcoder' Serbinenko wrote: > > Hello > > > > > > > Comments for next steps to commit the patch are welcomed. > > > > Quick look revealed that you haven't taken into account my comments e

Re: Fw: gettext support

2009-06-17 Thread Carles Pina i Estany
Hi, On Jun/17/2009, Vladimir 'phcoder' Serbinenko wrote: > Hello > > > > Comments for next steps to commit the patch are welcomed. > > Quick look revealed that you haven't taken into account my comments exposed > here: http://lists.gnu.org/archive/html/grub-devel/2009-04/msg00181.html Right,

Re: Fw: gettext support

2009-06-17 Thread Vladimir 'phcoder' Serbinenko
Hello > Comments for next steps to commit the patch are welcomed. Quick look revealed that you haven't taken into account my comments exposed here: http://lists.gnu.org/archive/html/grub-devel/2009-04/msg00181.html > > (maybe I need to setup the "path" to access to /usr/share/locale in the > G

Re: Fw: gettext support

2009-06-16 Thread Vladimir 'phcoder' Serbinenko
Hello. Welcome back and your work is appreciated. I will look at the patch later (In couple minutes I go to sleep) On Tue, Jun 16, 2009 at 11:47 PM, Carles Pina i Estany wrote: > > Hello, > > Last January I sent a patch to add gettext support. When I had time, the > list was not very, and afterwa

Fw: gettext support

2009-06-16 Thread Carles Pina i Estany
Hello, Last January I sent a patch to add gettext support. When I had time, the list was not very, and afterwards I didn't have time. Hopefully from now on and during next weeks I will have some time to follow up the discussion, make changes, etc. (not exactly everyday but I will be able to do,