Omega359 commented on issue #13782:
URL: https://github.com/apache/datafusion/issues/13782#issuecomment-2569330925
It's not the nullif, it's the real datatype:
```sql
> SELECT 1 - 213220800 * 1::REAL;
++
| Int64(1) - Int64(213220800) * Int64
crepererum merged PR #13978:
URL: https://github.com/apache/datafusion/pull/13978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
crepererum merged PR #13925:
URL: https://github.com/apache/datafusion/pull/13925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
cj-zhukov commented on PR #13981:
URL: https://github.com/apache/datafusion/pull/13981#issuecomment-2569196286
@alamb Andrew, I've noticed some checks have failed. Could you help me
understand if this is related to my changes or something else? I'd be happy to
address the issue.
--
This
westonpace commented on PR #13800:
URL: https://github.com/apache/datafusion/pull/13800#issuecomment-2569258311
Ok, I just needed a good night's sleep. I converted the `schema_name` /
`catalog_name` methods into parameters on the `resolve` function. Now each of
the new traits has only a s
comphead commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1901961326
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Functions
andygrove opened a new pull request, #1213:
URL: https://github.com/apache/datafusion-comet/pull/1213
## Which issue does this PR close?
N/A
## Rationale for this change
Fix this warning:
```
[INFO] compiling 6 Scala sources and 12 Java sources t
kazuyukitanimura commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902182027
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -919,14 +919,6 @@ class CometSparkSessionExtensions
}
ov
kazuyukitanimura commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902145561
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -272,18 +272,19 @@ object CometConf extends ShimCometConf {
.booleanConf
andygrove commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902182688
##
native/core/src/execution/shuffle/shuffle_writer.rs:
##
@@ -1567,17 +1585,41 @@ pub fn write_ipc_compressed(
let mut timer = ipc_time.timer();
l
andygrove commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902182125
##
native/core/src/execution/shuffle/shuffle_writer.rs:
##
@@ -1567,17 +1585,41 @@ pub fn write_ipc_compressed(
let mut timer = ipc_time.timer();
l
viirya closed issue #1035: `CometBuffer` can potentially lead to concurrent
modification of a held buffer (aka is "Unsound" in Rust terms)
URL: https://github.com/apache/datafusion-comet/issues/1035
--
This is an automated message from the Apache Git Service.
To respond to the message, please
viirya merged PR #1050:
URL: https://github.com/apache/datafusion-comet/pull/1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
milenkovicm opened a new pull request, #1155:
URL: https://github.com/apache/datafusion-ballista/pull/1155
# Which issue does this PR close?
Closes None.
# Rationale for this change
Test which covers (unsupported) `SessionContext` option `enable_url_table()`
so we can a
Lordworms commented on code in PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#discussion_r1902127243
##
benchmarks/transfer_dat_parquet.py:
##
Review Comment:
I'll refactor that, thanks a lot
--
This is an automated message from the Apache Git Service.
comphead commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902232963
##
native/core/src/execution/shuffle/shuffle_writer.rs:
##
@@ -1567,17 +1585,41 @@ pub fn write_ipc_compressed(
let mut timer = ipc_time.timer();
le
parthchandra commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1902256464
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2517,4 +2517,16 @@ class CometExpressionSuite extends CometTestBase with
Adap
andygrove commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902235813
##
native/core/src/execution/shuffle/shuffle_writer.rs:
##
@@ -1567,17 +1585,41 @@ pub fn write_ipc_compressed(
let mut timer = ipc_time.timer();
l
andygrove commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902239523
##
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/NativeBatchDecoderIterator.scala:
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache So
andygrove merged PR #1213:
URL: https://github.com/apache/datafusion-comet/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1902236276
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -272,18 +272,19 @@ object CometConf extends ShimCometConf {
.booleanConf
.crea
andygrove commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902234781
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -919,14 +919,6 @@ class CometSparkSessionExtensions
}
override
kazuyukitanimura commented on PR #1201:
URL:
https://github.com/apache/datafusion-comet/pull/1201#issuecomment-2569950958
Thanks @parthchandra
@andygrove @viirya can I get a committer approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kazuyukitanimura merged PR #1201:
URL: https://github.com/apache/datafusion-comet/pull/1201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
codecov-commenter commented on PR #1210:
URL:
https://github.com/apache/datafusion-comet/pull/1210#issuecomment-2569962633
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
kazuyukitanimura commented on PR #1201:
URL:
https://github.com/apache/datafusion-comet/pull/1201#issuecomment-2569962967
Thanks, merged @viirya @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
milenkovicm opened a new pull request, #14004:
URL: https://github.com/apache/datafusion/pull/14004
## Which issue does this PR close?
Closes #14003.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
Yes
milenkovicm opened a new issue, #14003:
URL: https://github.com/apache/datafusion/issues/14003
### Is your feature request related to a problem or challenge?
`SessionContext.enable_url_table()` will create new context with different
session context id. In most cases this does not make
matthewmturner opened a new pull request, #14002:
URL: https://github.com/apache/datafusion/pull/14002
## Which issue does this PR close?
Closes #.
## Rationale for this change
Fix outdated doc example
## What changes are included in this PR?
Update
comphead merged PR #13982:
URL: https://github.com/apache/datafusion/pull/13982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
milenkovicm opened a new pull request, #1154:
URL: https://github.com/apache/datafusion-ballista/pull/1154
as there is separate set of tests testing python functionality.
# Which issue does this PR close?
Closes none.
# Rationale for this change
we test python mod
jayzhan211 commented on PR #13980:
URL: https://github.com/apache/datafusion/pull/13980#issuecomment-2569905955
Not pretty sure is the logic applied to `first` too. I will work on it later
on
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jayzhan211 merged PR #13980:
URL: https://github.com/apache/datafusion/pull/13980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on issue #13872:
URL: https://github.com/apache/datafusion/issues/13872#issuecomment-2569907599
Which one do you think should return null?
> SELECT cardinality(array_remove([1], 1));
I think we should return 0 for this case 🤔 ?
--
This is an automated
zhuqi-lucas opened a new pull request, #13996:
URL: https://github.com/apache/datafusion/pull/13996
## Which issue does this PR close?
Closes [#7209](https://github.com/apache/datafusion/issues/7209)
## Rationale for this change
## What changes are include
rluvaton commented on issue #11030:
URL: https://github.com/apache/datafusion/issues/11030#issuecomment-2568920755
I would like to help with this, I'm big into tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yoavcloud opened a new pull request, #1639:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1639
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yoavcloud opened a new pull request, #1638:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1638
https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#overlaps-predicate
I did not gate this one by dialect, as it doesn't seem to conflict with
anything a
Blizzara commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1901637948
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -744,10 +752,10 @@ pub async fn from_substrait_plan_with_consumer(
match plan.relations[0
andygrove commented on PR #1211:
URL:
https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2569622997
> Thanks, so tests are passed, should we merge this PR?
If we merge this PR we will probably no longer be able to run the TPC-DS
benchmark. I will try running it now.
andygrove commented on PR #1211:
URL:
https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2569624567
> f we merge this PR we will probably no longer be able to run the TPC-DS
benchmark. I will try running it now.
Well, maybe if we don't enable SMJ with filter it is ok.
viirya commented on PR #1211:
URL:
https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2569624977
The two configs are still disabled by default now, isn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
comphead commented on PR #1211:
URL:
https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2569564363
> > Thanks @andygrove for running Q21, is it right the result row count is
the same?
>
> Yes, the output from the final two SMJs is correct, as is the final output.
jatin510 commented on issue #13872:
URL: https://github.com/apache/datafusion/issues/13872#issuecomment-2569547645
```
> SELECT array_remove([1,null], 1);
+--+
| array_remove(make_array(Int64(1),NULL),Int64(1)) |
+---
avkirilishin opened a new pull request, #14000:
URL: https://github.com/apache/datafusion/pull/14000
## Which issue does this PR close?
Closes #13979.
## Are these changes tested?
No new tests were added. It was manually tes
Chen-Yuan-Lai commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902001514
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Func
Chen-Yuan-Lai commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902001514
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Func
Chen-Yuan-Lai commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902001514
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Func
Chen-Yuan-Lai commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902005630
##
datafusion/functions/src/encoding/inner.rs:
##
@@ -126,10 +124,21 @@ impl ScalarUDFImpl for EncodeFunc {
}
fn documentation(&self) -> Option<&
comphead commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902025654
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Functions
comphead commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1902030922
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1758,167 +1758,6 @@ encode(expression, format)
- [decode](#decode)
-## Regular Expression Functions
comphead opened a new issue, #14001:
URL: https://github.com/apache/datafusion/issues/14001
I'll file a ticket to make `user_doc` to work with predefined
consts.
Currently the `doc_section` attribute must match fully the predefined
DocSection consts, for example
```
2010YOUY01 commented on issue #11030:
URL: https://github.com/apache/datafusion/issues/11030#issuecomment-2569092518
@rluvaton Thank you! I'm still interested in this project (though I haven’t
been working on it for a few months 😅) and I'm happy to help with any
contributions.
I thin
ankane commented on PR #13985:
URL: https://github.com/apache/datafusion/pull/13985#issuecomment-2569369567
Thanks @alamb! Will defer to you on a CI check (but isn't a big deal to
manually add them).
--
This is an automated message from the Apache Git Service.
To respond to the message, p
andygrove commented on PR #1211:
URL:
https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2569362549
> Thanks @andygrove for running Q21, is it right the result row count is the
same?
Yes, the output from the final two SMJs is correct, as is the final output.
--
This
andygrove commented on PR #1206:
URL:
https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2569642133
@rluvaton I think that this looks great but it is challenging to really
review the PR with so many changes.
.
--
This is an automated message from the Apache Git Service.
To resp
yoavcloud opened a new pull request, #1641:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1641
https://dev.mysql.com/doc/refman/8.4/en/insert.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
andygrove commented on PR #1210:
URL:
https://github.com/apache/datafusion-comet/pull/1210#issuecomment-2569445901
@Kontinuation, could you review this, particularly the updated Tuning Guide,
to make sure I understand it correctly?
--
This is an automated message from the Apache Git Serv
vbarua commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1901924005
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -233,6 +233,10 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
// These methods have default
andygrove commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1901922136
##
native/core/src/execution/jni_api.rs:
##
@@ -281,14 +279,13 @@ fn parse_memory_pool_config(
memory_pool_type: String,
memory_limit: i64,
me
vbarua commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1901926751
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -744,10 +752,10 @@ pub async fn from_substrait_plan_with_consumer(
match plan.relations[0].
jayzhan211 opened a new issue, #13998:
URL: https://github.com/apache/datafusion/issues/13998
### Is your feature request related to a problem or challenge?
```rust
pub(crate) fn create_group_accumulator(
agg_expr: &Arc,
) -> Result> {
if agg_expr.groups_accumulator
yoavcloud opened a new pull request, #1640:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1640
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gatesn commented on issue #2581:
URL: https://github.com/apache/datafusion/issues/2581#issuecomment-2569432044
I'm not sure I agree that these are two separate ideas, rather, a
generalization of the existing notion of projection.
Projection today is all about selecting some subset of
alamb commented on PR #13988:
URL: https://github.com/apache/datafusion/pull/13988#issuecomment-2569052790
Thank you for the review @ozankabak 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb commented on PR #13958:
URL: https://github.com/apache/datafusion/pull/13958#issuecomment-2569054376
Thank you @jonahgao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb merged PR #13988:
URL: https://github.com/apache/datafusion/pull/13988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
findepi commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1901954669
##
datafusion/core/src/catalog_common/information_schema.rs:
##
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|
viirya commented on PR #1050:
URL:
https://github.com/apache/datafusion-comet/pull/1050#issuecomment-2569654791
Thank you @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove merged PR #1211:
URL: https://github.com/apache/datafusion-comet/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #398: Support sort merge join with a join condition
URL: https://github.com/apache/datafusion-comet/issues/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Kontinuation commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902289845
##
native/core/src/execution/jni_api.rs:
##
@@ -281,14 +279,13 @@ fn parse_memory_pool_config(
memory_pool_type: String,
memory_limit: i64,
Kontinuation commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902290275
##
docs/source/user-guide/tuning.md:
##
@@ -23,11 +23,52 @@ Comet provides some tuning options to help you get the best
performance from you
## Memory
viirya commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902629149
##
docs/source/user-guide/tuning.md:
##
@@ -23,11 +23,52 @@ Comet provides some tuning options to help you get the best
performance from you
## Memory Tunin
viirya commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902636032
##
docs/source/user-guide/tuning.md:
##
@@ -23,11 +23,52 @@ Comet provides some tuning options to help you get the best
performance from you
## Memory Tunin
viirya commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902634368
##
docs/source/user-guide/tuning.md:
##
@@ -23,11 +23,52 @@ Comet provides some tuning options to help you get the best
performance from you
## Memory Tunin
zhuqi-lucas commented on issue #7209:
URL: https://github.com/apache/datafusion/issues/7209#issuecomment-2570474523
Hi @alamb , the draft PR works well and tested group by h2o benchmark, but
the join seems have some problems, i also submitted the question:
https://github.com/MrPowers/
Lordworms opened a new pull request, #14005:
URL: https://github.com/apache/datafusion/pull/14005
## Which issue does this PR close?
part of #7652
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these c
80 matches
Mail list logo
