vbarua commented on code in PR #13963: URL: https://github.com/apache/datafusion/pull/13963#discussion_r1901924005
########## datafusion/substrait/src/logical_plan/consumer.rs: ########## @@ -233,6 +233,10 @@ pub trait SubstraitConsumer: Send + Sync + Sized { // These methods have default implementations calling the common handler code, to allow for users // to re-use common handling logic. + async fn consume_rel(&self, rel: &Rel) -> Result<LogicalPlan> { Review Comment: Added a little bit of documentation for these. I'm planning to add some module levels docs as part of https://github.com/apache/datafusion/issues/13864. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org