kazuyukitanimura commented on code in PR #1210:
URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902182027
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -919,14 +919,6 @@ class CometSparkSessionExtensions
}
override def apply(plan: SparkPlan): SparkPlan = {
-
- // Comet required off-heap memory to be enabled
- if (!isOffHeapEnabled(conf) && !isTesting) {
Review Comment:
Looks like `isOffHeapEnabled` and `isTesting` are not used after PR. Should
we delete those methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
