avkirilishin opened a new pull request, #14000:
URL: https://github.com/apache/datafusion/pull/14000

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #13979.
   
   <!-- ## Rationale for this change -->
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   <!-- ## What changes are included in this PR? -->
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   No new tests were added. It was manually tested (removed the duplicated 
'Error during planning'; no changes made to 'Error during planning: Execution 
error:' in the third case):
   
   <table>
   <tr>
   <td><b>Before</b></td><td><b>After</b></td>
   </tr>
   <tr>
   <td>
   
   ```sql
   > select version(1);
   Error during planning: Error during planning:
   Failed to coerce arguments to satisfy a call
   to version function: coercion from [Int64] to
   the signature Exact([]) failed. No function
   matches the given name and argument
   types 'version(Int64)'. You might need to
   add explicit type casts.
   ```
   
   </td>
   <td>
   
   ```sql
   > select version(1);
   Error during planning: Failed to coerce
   arguments to satisfy a call to version
   function: coercion from [Int64] to the
   signature Exact([]) failed. No function
   matches the given name and argument
   types 'version(Int64)'. You might need
   to add explicit type casts.
   ```
   
   </td>
   </tr>
   
   <tr>
   <td>
   
   ```sql
   > select rank(1) over();
   Error during planning: Error during planning:
   The function expected zero argument but
   received 1 No function matches the given
   name and argument types 'rank(Int64)'. You
   might need to add explicit type casts.
   
   ```
   
   </td>
   <td>
   
   ```sql
   > select rank(1) over();
   Error during planning: The function expected
   zero argument but received 1 No function
   matches the given name and argument types
   'rank(Int64)'. You might need to add explicit
   type casts.
   
   ```
   
   </td>
   </tr>
   
   <tr>
   <td>
   
   ```sql
   > select max(1,2);
   Error during planning: Execution error:
   User-defined coercion failed with
   Execution("min/max was called with 2
   arguments. It requires only 1.") No
   function matches the given name and
   argument types 'max(Int64, Int64)'. You
   might need to add explicit type casts.
   ```
   
   </td>
   <td>
   
   ```sql
   > select max(1,2);
   Error during planning: Execution error:
   User-defined coercion failed with
   Execution("min/max was called with 2
   arguments. It requires only 1.") No
   function matches the given name and
   argument types 'max(Int64, Int64)'. You
   might need to add explicit type casts.
   ```
   
   </td>
   </tr>
   
   </table>
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   Although the output of some errors will change (improve), changes in the 
documentation are probably not necessary.
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to