parthchandra commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1902256464
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2517,4 +2517,16 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
checkSparkAnswer(df.select("arrUnsupportedArgs"))
}
}
+ test("array_remove") {
+ Seq(true, false).foreach { dictionaryEnabled =>
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "test.parquet")
+ makeParquetFileAllTypes(path, dictionaryEnabled, 10000)
+ spark.read.parquet(path.toString).createOrReplaceTempView("t1");
+ checkSparkAnswerAndOperator(sql("SELECT array_remove(array(_2, _3,_4),
_2) from t1"))
+ checkSparkAnswerAndOperator(sql("SELECT array_remove(array(_2, _3,_4),
3) from t1"))
+ checkSparkAnswerAndOperator(sql("SELECT array_remove(array(_2, _3,_4),
10) from t1"))
Review Comment:
Also can we tests where the array is null, array is empty, and array
contains nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
