viirya commented on code in PR #1210: URL: https://github.com/apache/datafusion-comet/pull/1210#discussion_r1902634368
########## docs/source/user-guide/tuning.md: ########## @@ -23,11 +23,52 @@ Comet provides some tuning options to help you get the best performance from you ## Memory Tuning -Comet shares an off-heap memory pool between Spark and Comet. This requires setting `spark.memory.offHeap.enabled=true`. -If this setting is not enabled, Comet will not accelerate queries and will fall back to Spark. +### Unified Memory Management with Off-Heap Memory + +The recommended way to share memory between Spark and Comet is to set `spark.memory.offHeap.enabled=true`. This allows +Comet to share an off-heap memory pool with Spark. The size of the pool is specified by `spark.memory.offHeap.size`. + +### Dedicated Comet Memory Pools + +If the `spark.memory.offHeap.enabled` setting is not enabled then Comet will use its own dedicated memory pools that Review Comment: ```suggestion Spark uses on-heap memory mode by default, i.e., the `spark.memory.offHeap.enabled` setting is not enabled. If Spark is under on-heap memory mode, Comet will use its own dedicated memory pools that ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
