jayzhan211 commented on issue #12622:
URL: https://github.com/apache/datafusion/issues/12622#issuecomment-2599579247
> Unfortunately, using Scalar in ColumnarValue and Expr breaks all patterns
that try to match the scalar for these types.
While we can fix this in the DataFusion code base
cj-zhukov commented on code in PR #14168:
URL: https://github.com/apache/datafusion/pull/14168#discussion_r1920985877
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -1379,6 +1379,29 @@ impl SessionContext {
Ok(())
}
+fn register_type_check(
+&
Spaarsh commented on issue #14098:
URL: https://github.com/apache/datafusion/issues/14098#issuecomment-2599524998
Apologies for the delay! @ion-elgreco is this the output you are expecting?
If so, I shall make a PR including some tests as well!
![Image](https://github.com/user-attachment
shehabgamin commented on issue #14008:
URL: https://github.com/apache/datafusion/issues/14008#issuecomment-2599492511
As promised, Sail is working on porting relevant tests into DataFusion.
A good starting point is a regression our tests caught in DataFusion 43,
which still seems to p
wForget commented on code in PR #1295:
URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937037
##
native/spark-expr/src/hash_funcs/utils.rs:
##
@@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float {
};
}
+#[macro_export]
+macro_rules! has
wForget commented on code in PR #1295:
URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937402
##
native/spark-expr/src/hash_funcs/utils.rs:
##
@@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float {
};
}
+#[macro_export]
+macro_rules! has
wForget commented on code in PR #1295:
URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937037
##
native/spark-expr/src/hash_funcs/utils.rs:
##
@@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float {
};
}
+#[macro_export]
+macro_rules! has
parthchandra commented on PR #1299:
URL:
https://github.com/apache/datafusion-comet/pull/1299#issuecomment-2599460209
@andygrove I added another fix since you approved. This was also a merge
issue and caused 6 test failures if native_datafusion was enabled.
Latest count :
```
nat
chenkovsky commented on issue #14141:
URL: https://github.com/apache/datafusion/issues/14141#issuecomment-2599457794
> > I try to make genericdialect more customizable, but it seems that it
maybe not a good idea. ಥ_ಥ
>
> Note there is: https://datafusion.apache.org/user-guide/configs.
parthchandra commented on issue #1266:
URL:
https://github.com/apache/datafusion-comet/issues/1266#issuecomment-2599442763
Is there some particular version of Spark that this failure is occurring
with?
--
This is an automated message from the Apache Git Service.
To respond to the message
comphead commented on code in PR #14168:
URL: https://github.com/apache/datafusion/pull/14168#discussion_r1920874016
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -1379,6 +1379,29 @@ impl SessionContext {
Ok(())
}
+fn register_type_check(
+&s
Omega359 commented on issue #14158:
URL: https://github.com/apache/datafusion/issues/14158#issuecomment-2599372511
First cut:
https://gist.github.com/Omega359/fd30f1e2807f08033c65957b5233fd0b
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
parthchandra commented on PR #1245:
URL:
https://github.com/apache/datafusion-comet/pull/1245#issuecomment-2599368441
> @mbutrovich, is it better to close this pull request and reopen if needed?
Personally, I think so. Also, do we want to continue supporting JDK8 for
long (FWIW,
wiedld commented on code in PR #14167:
URL: https://github.com/apache/datafusion/pull/14167#discussion_r1920831004
##
datafusion/common/src/scalar/mod.rs:
##
@@ -2849,6 +2849,50 @@ impl ScalarValue {
ScalarValue::from(value).cast_to(target_type)
}
+/// Return
wiedld commented on code in PR #14167:
URL: https://github.com/apache/datafusion/pull/14167#discussion_r1920830750
##
datafusion/common/src/scalar/mod.rs:
##
@@ -2849,6 +2849,50 @@ impl ScalarValue {
ScalarValue::from(value).cast_to(target_type)
}
+/// Return
wiedld commented on code in PR #14167:
URL: https://github.com/apache/datafusion/pull/14167#discussion_r1920830750
##
datafusion/common/src/scalar/mod.rs:
##
@@ -2849,6 +2849,50 @@ impl ScalarValue {
ScalarValue::from(value).cast_to(target_type)
}
+/// Return
andygrove opened a new issue, #1304:
URL: https://github.com/apache/datafusion-comet/issues/1304
### What is the problem the feature request solves?
We should start tracking issues that may affect us related to DF 45.
- https://github.com/apache/datafusion/pull/14094
###
comphead commented on code in PR #14157:
URL: https://github.com/apache/datafusion/pull/14157#discussion_r1920810030
##
datafusion/core/benches/sql_planner.rs:
##
@@ -147,6 +149,77 @@ fn benchmark_with_param_values_many_columns(ctx:
&SessionContext, b: &mut Benche
});
}
comphead merged PR #14155:
URL: https://github.com/apache/datafusion/pull/14155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on code in PR #14157:
URL: https://github.com/apache/datafusion/pull/14157#discussion_r1920808402
##
datafusion/core/benches/sql_planner.rs:
##
@@ -147,6 +149,77 @@ fn benchmark_with_param_values_many_columns(ctx:
&SessionContext, b: &mut Benche
});
}
comphead merged PR #14165:
URL: https://github.com/apache/datafusion/pull/14165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920803813
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNa
parthchandra commented on code in PR #1299:
URL: https://github.com/apache/datafusion-comet/pull/1299#discussion_r1920791563
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -190,7 +190,7 @@ class CometSparkSessionExtensions
// data
logan-keede commented on issue #14172:
URL: https://github.com/apache/datafusion/issues/14172#issuecomment-2599235975
Hi @alamb, Please check if my PR #14175 correctly addresses this issue
Thanks,
Logan
--
This is an automated message from the Apache Git Service.
To respond to the m
logan-keede opened a new pull request, #14175:
URL: https://github.com/apache/datafusion/pull/14175
## Which issue does this PR close?
Closes #14172
## Rationale for this change
Mark `max_size_statistics` deprecated
## What changes are included in this PR?
kazuyukitanimura commented on PR #1303:
URL:
https://github.com/apache/datafusion-comet/pull/1303#issuecomment-2599101337
merged, thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kazuyukitanimura merged PR #1303:
URL: https://github.com/apache/datafusion-comet/pull/1303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
andygrove merged PR #52:
URL: https://github.com/apache/datafusion-site/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
logan-keede commented on issue #14118:
URL: https://github.com/apache/datafusion/issues/14118#issuecomment-2599032845
I thought so, I looked at some other avenues,
Here are some things that might help anyone trying to solve this in future.
Problem:-
`exclude_using_columns` return
andygrove commented on code in PR #1299:
URL: https://github.com/apache/datafusion-comet/pull/1299#discussion_r1920620850
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -190,7 +190,7 @@ class CometSparkSessionExtensions
// data sou
andygrove commented on PR #52:
URL: https://github.com/apache/datafusion-site/pull/52#issuecomment-2598971562
@viirya @comphead @alamb Could I get an approval to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on code in PR #14153:
URL: https://github.com/apache/datafusion/pull/14153#discussion_r1920591420
##
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##
@@ -1815,6 +1815,8 @@ fn round_trip_datatype() {
}
}
+// TODO file a ticket about handling depr
alamb opened a new pull request, #14174:
URL: https://github.com/apache/datafusion/pull/14174
## Which issue does this PR close?
Follow on to
- https://github.com/apache/datafusion/pull/14153
## Rationale for this change
I filed a ticket to track the removal of some de
alamb opened a new issue, #14173:
URL: https://github.com/apache/datafusion/issues/14173
### Is your feature request related to a problem or challenge?
The most recent version of arrow deprecates the dictionary fields from
Schema, see
- https://github.com/apache/arrow-rs/pull/6873
alamb opened a new issue, #14172:
URL: https://github.com/apache/datafusion/issues/14172
### Is your feature request related to a problem or challenge?
The most recent version of arrow deprecates the `max_statistics_size`
parquet option
- https://github.com/apache/datafusion/pull/1
kazuyukitanimura opened a new pull request, #1303:
URL: https://github.com/apache/datafusion-comet/pull/1303
Leftover from https://github.com/apache/datafusion-comet/pull/1281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alamb commented on PR #13370:
URL: https://github.com/apache/datafusion/pull/13370#issuecomment-2598934705
We just updated to a version of arrow-rs that I think has the necessary
changes:
- https://github.com/apache/datafusion/pull/14153
(thanks @Owen-CH-Leung )
--
This is an automa
alamb closed pull request #13663: WIP Upgrade to arrow-rs/parquet `54.0.0`
URL: https://github.com/apache/datafusion/pull/13663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on PR #14153:
URL: https://github.com/apache/datafusion/pull/14153#issuecomment-2598933647
Thanks again @Owen-CH-Leung -- very much apprecaited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb closed issue #14114: Upgrade to arrow-rs/parquet `54.0.0`
URL: https://github.com/apache/datafusion/issues/14114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
alamb merged PR #14153:
URL: https://github.com/apache/datafusion/pull/14153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed pull request #14095: Add recursion limit configuration to
`DFParser`
URL: https://github.com/apache/datafusion/pull/14095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
kazuyukitanimura commented on code in PR #1295:
URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920575456
##
native/spark-expr/src/hash_funcs/utils.rs:
##
@@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float {
};
}
+#[macro_export]
+macro_r
alamb commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2598932383
To be clear I think we will still need to increase the recursion limit in
DataFusion to allow the sqllogictest to pass. But until the next sqlparser
upgrade I don't we can do so safely
alamb commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2598930685
Converting this to draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb commented on PR #14156:
URL: https://github.com/apache/datafusion/pull/14156#issuecomment-2598926902
Thank you @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb commented on PR #13707:
URL: https://github.com/apache/datafusion/pull/13707#issuecomment-2598924731
Marking this PR as a draft as it has some conflicts now and it doesn't seem
like we have consensus on the approach (some will be faster and some slower).
Let me know if this isn't righ
alamb commented on code in PR #14129:
URL: https://github.com/apache/datafusion/pull/14129#discussion_r1920568890
##
benchmarks/bench.sh:
##
@@ -401,9 +405,14 @@ data_clickbench_1() {
else
URL="https://datasets.clickhouse.com/hits_compatible/hits.parquet";
andygrove opened a new pull request, #1302:
URL: https://github.com/apache/datafusion-comet/pull/1302
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
Omega359 commented on PR #14156:
URL: https://github.com/apache/datafusion/pull/14156#issuecomment-2598879890
Status update: I've rerun the slt generation locally, I just need to apply
patches for 2 failures, have a look over the updates, then push a PR. Hopefully
by EOD today.
--
This i
alamb commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2598868919
Nice work everyone and thank you @Chen-Yuan-Lai especially 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb commented on PR #14155:
URL: https://github.com/apache/datafusion/pull/14155#issuecomment-2598871191
> LGTM, thank you @alamb. After your work on these equivalence API's, they
seem more clear and easy to use now.
Thank you -- now I just need to make them faster / more efficient
andygrove closed pull request #1296: IGNORE: chore: Merge comet-parquet-exec
into (just to see diff)
URL: https://github.com/apache/datafusion-comet/pull/1296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on issue #14141:
URL: https://github.com/apache/datafusion/issues/14141#issuecomment-2598865518
> I try to make genericdialect more customizable, but it seems that it maybe
not a good idea. ಥ_ಥ
Note there is:
https://datafusion.apache.org/user-guide/configs.html
andygrove closed pull request #1301: Enable native scan
URL: https://github.com/apache/datafusion-comet/pull/1301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
andygrove closed pull request #1301: Enable native scan
URL: https://github.com/apache/datafusion-comet/pull/1301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
andygrove opened a new pull request, #1301:
URL: https://github.com/apache/datafusion-comet/pull/1301
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
alamb commented on code in PR #14094:
URL: https://github.com/apache/datafusion/pull/14094#discussion_r1920358041
##
datafusion/expr/src/udf.rs:
##
@@ -342,6 +348,56 @@ pub struct ScalarFunctionArgs<'a> {
pub return_type: &'a DataType,
}
+#[derive(Debug)]
+pub struct Ret
alamb commented on PR #14094:
URL: https://github.com/apache/datafusion/pull/14094#issuecomment-2598845894
FYI @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
xarus01 opened a new pull request, #14171:
URL: https://github.com/apache/datafusion/pull/14171
## Which issue does this PR close?
Closes #8366.
## Rationale for this change
## What changes are included in this PR?
Added `How to add/edit doc
mvzink opened a new issue, #1665:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1665
Example:
```sql
ALTER TABLE tbl_name MODIFY COLUMN col_name column_definition FIRST,
ALGORITHM=INPLACE, LOCK=NONE;
```
See [`ALTER TABLE`
docs](https://dev.mysql.com/doc/
viirya commented on PR #1298:
URL:
https://github.com/apache/datafusion-comet/pull/1298#issuecomment-2598796942
> @viirya, I wonder if you could help me and @parthchandra understand why
the test in this PR is failing.
I may be able to look at this only after I get a new laptop...
xudong963 merged PR #14170:
URL: https://github.com/apache/datafusion/pull/14170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
comphead merged PR #14163:
URL: https://github.com/apache/datafusion/pull/14163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #13671: doc-gen: Migrate builtin scalar functions from
code based documentation to attribute based
URL: https://github.com/apache/datafusion/issues/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
comphead commented on PR #14163:
URL: https://github.com/apache/datafusion/pull/14163#issuecomment-2598761699
Thanks everyone, looks like these was last functions to migrate 🤖
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
andygrove opened a new pull request, #52:
URL: https://github.com/apache/datafusion-site/pull/52
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
xudong963 commented on code in PR #14167:
URL: https://github.com/apache/datafusion/pull/14167#discussion_r1920411199
##
datafusion/common/src/scalar/mod.rs:
##
@@ -2849,6 +2849,50 @@ impl ScalarValue {
ScalarValue::from(value).cast_to(target_type)
}
+/// Ret
xudong963 opened a new pull request, #14170:
URL: https://github.com/apache/datafusion/pull/14170
## Rationale for this change
I noticed the two tests would be unstable somethings.
## What changes are included in this PR?
Add `Order by` to make them stable
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920352694
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNa
alamb commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2598600811
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
I think we just need to tweak the max
andygrove commented on PR #1298:
URL:
https://github.com/apache/datafusion-comet/pull/1298#issuecomment-2598596742
I have this test passing now, but I don't know if the approach is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
alamb opened a new pull request, #14169:
URL: https://github.com/apache/datafusion/pull/14169
## Which issue does this PR close?
Closes #.
## Rationale for this change
I think it would be best to consolidate most "end user API tests" into a
single file so they ar
andygrove commented on PR #1298:
URL:
https://github.com/apache/datafusion-comet/pull/1298#issuecomment-2598563070
After more debugging, I understand what is happening, but not sure what the
correct fix is yet.
We set `firstNonBroadcastPlanNumPartitions` to `0` because that is what
andygrove commented on PR #1298:
URL:
https://github.com/apache/datafusion-comet/pull/1298#issuecomment-2598544621
More debug output showing the RDDs being zipped, with partition count:
```
zipping these RDDS:
UnionRDD parts = 10
CometBatchRDD parts = 0
```
--
andygrove opened a new issue, #1300:
URL: https://github.com/apache/datafusion-comet/issues/1300
### What is the problem the feature request solves?
Major releases are currently happening every 1-2 months, so we may want to
create a patch release at some point with bug fixes.
T
jonahgao commented on issue #10326:
URL: https://github.com/apache/datafusion/issues/10326#issuecomment-2598506302
I haven't started working on it yet. Feel free to take it. Thanks @lichuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove commented on PR #1298:
URL:
https://github.com/apache/datafusion-comet/pull/1298#issuecomment-2598503895
@viirya, I wonder if you could help me and @parthchandra understand why the
test in this PR is failing.
The error is:
```
Can't zip RDDs with unequal numbers
wugeer commented on code in PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#discussion_r1920283018
##
src/ast/query.rs:
##
@@ -328,6 +328,10 @@ pub struct Select {
pub value_table_mode: Option,
/// STARTING WITH .. CONNECT BY
pub connec
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920271011
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDa
alamb commented on issue #10326:
URL: https://github.com/apache/datafusion/issues/10326#issuecomment-2598457665
👋 @lichuang -- I don't know anyone working on it, but maybe @jonahgao
knows of something.
THank you!
--
This is an automated message from the Apache Git Service.
To re
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920264150
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDa
eliaperantoni commented on PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#issuecomment-2598471076
@alamb I'm very sorry for the delay. I think your points about not wanting
to change the logical types are valid, and I confess it was a bit of a pain to
make all the changes t
alamb commented on code in PR #14134:
URL: https://github.com/apache/datafusion/pull/14134#discussion_r1920255614
##
datafusion/expr/src/test/function_stub.rs:
##
@@ -252,6 +252,10 @@ impl AggregateUDFImpl for Count {
Ok(DataType::Int64)
}
+fn is_nullable(&se
alamb merged PR #14134:
URL: https://github.com/apache/datafusion/pull/14134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920254738
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDa
alamb commented on PR #14134:
URL: https://github.com/apache/datafusion/pull/14134#issuecomment-2598460363
Thank you for the review @jonahgao 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cj-zhukov opened a new pull request, #14168:
URL: https://github.com/apache/datafusion/pull/14168
… register_parquet, register_json, register_avro (#14144)
## Which issue does this PR close?
Closes #14144.
## Rationale for this change
## What change
alamb commented on code in PR #12978:
URL: https://github.com/apache/datafusion/pull/12978#discussion_r1920211318
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -1605,7 +1627,129 @@ fn build_statistics_expr(
Ok(statistics_expr)
}
+/// Convert `column LIKE literal
alamb commented on code in PR #14167:
URL: https://github.com/apache/datafusion/pull/14167#discussion_r1920205796
##
datafusion/common/src/scalar/mod.rs:
##
@@ -2849,6 +2849,50 @@ impl ScalarValue {
ScalarValue::from(value).cast_to(target_type)
}
+/// Returns
alamb opened a new pull request, #14167:
URL: https://github.com/apache/datafusion/pull/14167
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/14166
## Rationale for this change
See https://github.com/apache/datafusion/issues/141
alamb opened a new issue, #14166:
URL: https://github.com/apache/datafusion/issues/14166
### Is your feature request related to a problem or challenge?
We hit a bug upstream in InfluxDB in pruning where we didn't match a certain
kind of string ScalarValue
In this case , we want
cj-zhukov commented on issue #14164:
URL: https://github.com/apache/datafusion/issues/14164#issuecomment-2598368377
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lichuang commented on issue #10326:
URL: https://github.com/apache/datafusion/issues/10326#issuecomment-2598350826
Is this issue still on going? If so, let me have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kosiew commented on issue #14154:
URL: https://github.com/apache/datafusion/issues/14154#issuecomment-2598327221
Good catch @ion-elgreco ☝!
I managed to reproduce the error after fetching the latest main from the
upstream.
I investigated the delta-rs repo, because I earlier tested
chenkovsky commented on PR #1662:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1662#issuecomment-2598317162
> > > > @MartinSahlen @iffyio Please review it again. I know maybe it's not
a good idea to solve it in this library.
> > >
> > >
> > > Given how I've shown t
MartinSahlen commented on PR #1662:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1662#issuecomment-2598306277
> > > @MartinSahlen @iffyio Please review it again. I know maybe it's not a
good idea to solve it in this library.
> >
> >
> > Given how I've shown that wh
yoavcloud opened a new pull request, #1663:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1663
It appears that Snowflake allows specifying qualified column names in the
USING column list. For example:
`SELECT * FROM tbl1 AS t1 JOIN tbl2 AS t2 USING(t2.col1)`
--
This i
chenkovsky commented on PR #1662:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1662#issuecomment-2598286166
> > @MartinSahlen @iffyio Please review it again. I know maybe it's not a
good idea to solve it in this library.
>
> Given how I've shown that whether this is ev
chenkovsky commented on issue #14141:
URL: https://github.com/apache/datafusion/issues/14141#issuecomment-2598273644
I try to make genericdialect more customizable, but it seems that it maybe
not a good idea. ಥ_ಥ
--
This is an automated message from the Apache Git Service.
To respond to t
1 - 100 of 129 matches
Mail list logo