andygrove commented on code in PR #1299:
URL: https://github.com/apache/datafusion-comet/pull/1299#discussion_r1920620850
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -190,7 +190,7 @@ class CometSparkSessionExtensions
// data source V1
case scanExec @ FileSourceScanExec(
- HadoopFsRelation(_, partitionSchema, _, _, _:
ParquetFileFormat, _),
+ HadoopFsRelation(_, partitionSchema, _, _, _, _),
Review Comment:
This doesn't seem correct, because it would make us replace non-parquet
scans as well.
main branch has:
```scala
// data source V1
case scanExec @ FileSourceScanExec(
HadoopFsRelation(_, partitionSchema, _, _, fileFormat, _),
_: Seq[_],
requiredSchema,
_,
_,
_,
_,
_,
_)
if CometScanExec.isFileFormatSupported(fileFormat)
&& CometScanExec.isSchemaSupported(requiredSchema)
&& CometScanExec.isSchemaSupported(partitionSchema) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
