chenkovsky commented on issue #14141: URL: https://github.com/apache/datafusion/issues/14141#issuecomment-2599457794
> > I try to make genericdialect more customizable, but it seems that it maybe not a good idea. ಥ_ಥ > > Note there is: https://datafusion.apache.org/user-guide/configs.html > > That might be useful: > > datafusion.sql_parser.dialect generic Configure the SQL dialect used by DataFusion’s parser; supported values include: Generic, MySQL, PostgreSQL, Hive, SQLite, Snowflake, Redshift, MsSQL, ClickHouse, BigQuery, and Ansi. at the beginning, I want to implement a dialect which is similar to generic, but it seems that datafusion sql parser cannot support it easily. because too many `dialect_of!`. for OOP language, `dialect_of!` is ok, we can extend generic dialect, but for rust,`dialect_of!` may be not a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
