alamb commented on code in PR #14153:
URL: https://github.com/apache/datafusion/pull/14153#discussion_r1920591420
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1815,6 +1815,8 @@ fn round_trip_datatype() {
}
}
+// TODO file a ticket about handling deprecated dict_id attributes
Review Comment:
- filed https://github.com/apache/datafusion/issues/14173
I also updated this comment in
- https://github.com/apache/datafusion/pull/14174/files
##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -157,8 +158,10 @@ impl TryFrom<&TableParquetOptions> for
WriterPropertiesBuilder {
}
if let Some(max_statistics_size) = options.max_statistics_size {
- builder =
- builder.set_column_max_statistics_size(path,
max_statistics_size);
+ builder = {
+ #[allow(deprecated)]
+ builder.set_column_max_statistics_size(path,
max_statistics_size)
Review Comment:
- filed https://github.com/apache/datafusion/issues/14172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
