chenkovsky commented on PR #1662: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1662#issuecomment-2598286166
> > @MartinSahlen @iffyio Please review it again. I know maybe it's not a good idea to solve it in this library. > > Given how I've shown that whether this is evaluated as a function or identifier/column depending on not just if it has parentheses or not, but also by what identifiers/columns are in scope I think this PR is not a good idea, and a bit of a slippery slope. It is easy to deal with this using a visitor pattern, which is what I think it is designed for - so this library can focus on syntax. @MartinSahlen but i have a question, as you said, `whether this is evaluated as a function or identifier/column depending on not just if it ...`, if this is correct. this library should not parse it into function call. it should leave it to caller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
