Re: [Patch, v2] contrib/mklog.py: Improve PR handling (was: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

Now committed as r12-1700-gedf0c3ffb59d75c11e05bc722432dc554e275c72 / as attached. (We had some follow-up discussion on IRC.) On 21.06.21 14:53, Martin Liška wrote: +# PR number in the file name +fname = os.path.basename(file.path) This is a dead code. + fname = os.p

Re: [Patch, v2] contrib/mklog.py: Improve PR handling (was: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 6/21/21 10:37 AM, Tobias Burnus wrote: On 21.06.21 10:09, Martin Liška wrote: $ pytest test_mklog.py FAILED test_mklog.py::TestMklog::test_sorting - AssertionError: assert '\n\tPR 50209...New test.\n\n' == 'gcc/ChangeLo...New test.\n\n' Aha, missed that there is indeed a testsuite - nice!

Re: [Patch, v2] contrib/mklog.py: Improve PR handling (was: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 21.06.21 10:09, Martin Liška wrote: $ pytest test_mklog.py FAILED test_mklog.py::TestMklog::test_sorting - AssertionError: assert '\n\tPR 50209...New test.\n\n' == 'gcc/ChangeLo...New test.\n\n' Aha, missed that there is indeed a testsuite - nice! $ flake8 mklog.py mklog.py:187:23: Q000 Rem

Re: [Patch, v2] contrib/mklog.py: Improve PR handling (was: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

Hi. I see the following warnings: $ pytest test_mklog.py FAILED test_mklog.py::TestMklog::test_sorting - AssertionError: assert '\n\tPR 50209...New test.\n\n' == 'gcc/ChangeLo...New test.\n\n' $ flake8 mklog.py mklog.py:187:23: Q000 Remove bad quotes and ... contrib/mklog.py: Improve PR han

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

> On 21 Jun 2021, at 08:26, Martin Liška wrote: > > On 6/21/21 8:42 AM, Tobias Burnus wrote: >> On 18.06.21 16:41, Jason Merrill wrote: >>> >>> * Being able to specify the PR numbers on the command line in addition >>>(currently, they are only extracted from the testsuite patches)

[Patch, v2] contrib/mklog.py: Improve PR handling (was: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 17.06.21 02:17, Martin Sebor via Gcc wrote: @@ -147,6 +152,12 @@ def generate_changelog(data, no_functions=False, fill_pr_titles=False): # Extract PR entries from newly added tests if 'testsuite' in file.path and file.is_added_file: +name = os.path.basename(fi

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 6/18/21 1:40 PM, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:26, Tobias Burnus wrote: On 18.06.21 13:10, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 PR fortran/100123 - -ftree-fr

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 6/21/21 8:42 AM, Tobias Burnus wrote: On 18.06.21 16:41, Jason Merrill wrote:     * Being able to specify the PR numbers on the command line in addition    (currently, they are only extracted from the testsuite patches) This bit seems unnecessary to me, since we want the commit to inc

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 18.06.21 16:41, Jason Merrill wrote: * Being able to specify the PR numbers on the command line in addition (currently, they are only extracted from the testsuite patches) This bit seems unnecessary to me, since we want the commit to include tests that identify the PR. I full h

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On Fri, Jun 18, 2021 at 7:06 AM Tobias Burnus wrote: > On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: > > On 17/06/2021 18:21, Jakub Jelinek wrote: > >> mklog as is doesn't fill in the details (descriptions of the changes > >> to each function etc.), nor is realiable in many cases, and with J

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On Fri, 18 Jun 2021 at 12:26, Tobias Burnus wrote: > > On 18.06.21 13:10, Jonathan Wakely wrote: > > > On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > >> PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 > >> PR fortran/100123 - -ftree-fre gives incorrect result in su

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 18.06.21 13:10, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 PR fortran/100123 - -ftree-fre gives incorrect result in subroutine with array declared as length 1 PR c++/12394

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On Fri, Jun 18, 2021 at 12:10:33PM +0100, Jonathan Wakely wrote: > On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > > But with -p added, it becomes rather nice. For instance: > > > >git diff |./contrib/mklog.py -b foo/12394 -b 100123 -p > > > > nows prints: > > > > PR c++/12394 - internal c

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > But with -p added, it becomes rather nice. For instance: > >git diff |./contrib/mklog.py -b foo/12394 -b 100123 -p > > nows prints: > > PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 > PR fortran/100123 - -ftree-fr

[Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: On 17/06/2021 18:21, Jakub Jelinek wrote: mklog as is doesn't fill in the details (descriptions of the changes to each function etc.), nor is realiable in many cases, and with Jason's recent change just fills in the first and last part of the fi

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 17/06/2021 18:21, Jakub Jelinek wrote: > On Thu, Jun 17, 2021 at 05:12:52PM +, Joseph Myers wrote: >> On Thu, 17 Jun 2021, Richard Earnshaw via Gcc wrote: >> >>> It seems a bit dangerous to me to rely on just extracting PR numbers from >>> tests. What if the patch is just adjusting a test t

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/17/21 10:32 AM, Jonathan Wakely wrote: On Thu, 17 Jun 2021 at 16:33, Martin Sebor wrote: On 6/17/21 9:11 AM, Michael Matz wrote: Hello, On Thu, 17 Jun 2021, Martin Sebor via Gcc wrote: The original problem is that the PR wasn't _in the body_ of the commit But I see [PR100085] right

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 17, 2021 at 1:14 PM Joseph Myers wrote: > On Thu, 17 Jun 2021, Richard Earnshaw via Gcc wrote: > > > It seems a bit dangerous to me to rely on just extracting PR numbers from > > tests. What if the patch is just adjusting a test to make it compatible > with > > the remainder of the c

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 17, 2021 at 05:12:52PM +, Joseph Myers wrote: > On Thu, 17 Jun 2021, Richard Earnshaw via Gcc wrote: > > > It seems a bit dangerous to me to rely on just extracting PR numbers from > > tests. What if the patch is just adjusting a test to make it compatible > > with > > the remain

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 17 Jun 2021, Richard Earnshaw via Gcc wrote: > It seems a bit dangerous to me to rely on just extracting PR numbers from > tests. What if the patch is just adjusting a test to make it compatible with > the remainder of the change? Also, that a test is added for a PR, or a commit is relev

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 17 Jun 2021 at 16:33, Martin Sebor wrote: > > On 6/17/21 9:11 AM, Michael Matz wrote: > > Hello, > > > > On Thu, 17 Jun 2021, Martin Sebor via Gcc wrote: > > > >>> The original problem is that the PR wasn't _in the body_ of the commit > >> > >> But I see [PR100085] right there at the end o

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 17, 2021 at 09:33:06AM -0600, Martin Sebor wrote: > On 6/17/21 9:11 AM, Michael Matz wrote: > > Hello, > > > > On Thu, 17 Jun 2021, Martin Sebor via Gcc wrote: > > > > > > The original problem is that the PR wasn't _in the body_ of the commit > > > > > > But I see [PR100085] right th

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/17/21 9:11 AM, Michael Matz wrote: Hello, On Thu, 17 Jun 2021, Martin Sebor via Gcc wrote: The original problem is that the PR wasn't _in the body_ of the commit But I see [PR100085] right there at the end of the _summary line_: Emphasis mine. Let me make sure I understand: we ask u

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

Hello, On Thu, 17 Jun 2021, Martin Sebor via Gcc wrote: > > The original problem is that the PR wasn't _in the body_ of the commit > > But I see [PR100085] right there at the end of the _summary line_: Emphasis mine. Ciao, Michael.

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/17/21 4:18 AM, Jonathan Wakely wrote: On Thu, 17 Jun 2021 at 02:01, Martin Sebor wrote: On 6/16/21 6:40 PM, Jason Merrill wrote: On 6/16/21 8:17 PM, Martin Sebor wrote: 3) adds the PR component/n to each ChangeLog This would be reverting the r12-771 change, which seems both unrelat

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 17 Jun 2021 at 02:01, Martin Sebor wrote: > > On 6/16/21 6:40 PM, Jason Merrill wrote: > > On 6/16/21 8:17 PM, Martin Sebor wrote: > >> 3) adds the PR component/n to each ChangeLog > > > > This would be reverting the r12-771 change, which seems both unrelated > > and undesirable. > > No

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 17/06/2021 01:40, Jason Merrill via Gcc wrote: On 6/16/21 8:17 PM, Martin Sebor wrote: On 6/16/21 5:45 PM, Jason Merrill wrote: On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor > wrote:     On 6/16/21 2:49 PM, Jason Merrill wrote: > On 6/15/21 11:42 PM, Jason Me

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/16/21 9:01 PM, Martin Sebor wrote: On 6/16/21 6:40 PM, Jason Merrill wrote: On 6/16/21 8:17 PM, Martin Sebor wrote: On 6/16/21 5:45 PM, Jason Merrill wrote: On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor > wrote:     On 6/16/21 2:49 PM, Jason Merrill wrote: >

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/16/21 6:40 PM, Jason Merrill wrote: On 6/16/21 8:17 PM, Martin Sebor wrote: On 6/16/21 5:45 PM, Jason Merrill wrote: On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor > wrote:     On 6/16/21 2:49 PM, Jason Merrill wrote: > On 6/15/21 11:42 PM, Jason Merrill wrote:

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/16/21 8:17 PM, Martin Sebor wrote: On 6/16/21 5:45 PM, Jason Merrill wrote: On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor > wrote:     On 6/16/21 2:49 PM, Jason Merrill wrote: > On 6/15/21 11:42 PM, Jason Merrill wrote: >> On Tue, Jun 15, 2021 at 10:04 PM

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/16/21 5:45 PM, Jason Merrill wrote: On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor > wrote: On 6/16/21 2:49 PM, Jason Merrill wrote: > On 6/15/21 11:42 PM, Jason Merrill wrote: >> On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc mailto:gcc@gcc.g

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Wed, Jun 16, 2021 at 5:46 PM Martin Sebor wrote: > On 6/16/21 2:49 PM, Jason Merrill wrote: > > On 6/15/21 11:42 PM, Jason Merrill wrote: > >> On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc >> > wrote: > >> > >> On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote:

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/16/21 2:49 PM, Jason Merrill wrote: On 6/15/21 11:42 PM, Jason Merrill wrote: On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc > wrote:     On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > >> On 6

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/15/21 11:42 PM, Jason Merrill wrote: On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc > wrote: On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > >> On 6/11/21 11:32 AM, Jonathan Wakely wrote:

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Tue, 15 Jun 2021, Martin Sebor wrote: > On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > > > > > On 6/11/21 11:32 AM, Jonathan Wakely wrote: > > > > On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > > > > > My objection is to making our polic

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/15/21 9:42 PM, Jason Merrill wrote: On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc > wrote: On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > >> On 6/11/21 11:32 AM, Jonathan Wakely wrote:

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Wed, 16 Jun 2021 at 03:03, Martin Sebor wrote: > > On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > > > >> On 6/11/21 11:32 AM, Jonathan Wakely wrote: > >>> On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > My objection is to making our

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Tue, Jun 15, 2021 at 10:04 PM Martin Sebor via Gcc wrote: > On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: > > On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > > > >> On 6/11/21 11:32 AM, Jonathan Wakely wrote: > >>> On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > My objection is to

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/15/21 6:56 PM, Hans-Peter Nilsson wrote: On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: On 6/11/21 11:32 AM, Jonathan Wakely wrote: On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: My objection is to making our policies and tools more restrictive than they need to be. We shouldn't ex

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021, Martin Sebor via Gcc wrote: > On 6/11/21 11:32 AM, Jonathan Wakely wrote: > > On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > > > My objection is to making our policies and tools more restrictive > > > than they need to be. We shouldn't expect everyone to study whole > >

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021 at 19:01, Martin Sebor wrote: > > On 6/11/21 11:32 AM, Jonathan Wakely wrote: > > On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > >> My objection is to making our policies and tools more restrictive > >> than they need to be. We shouldn't expect everyone to study whole > >>

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/11/21 11:32 AM, Jonathan Wakely wrote: On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: My objection is to making our policies and tools more restrictive than they need to be. We shouldn't expect everyone to study whole manuals just to figure out how to successfully commit a change (or le

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021 at 18:02, Martin Sebor wrote: > My objection is to making our policies and tools more restrictive > than they need to be. We shouldn't expect everyone to study whole > manuals just to figure out how to successfully commit a change (or > learn how to format it just the right way

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, Jun 11, 2021 at 11:02:52AM -0600, Martin Sebor wrote: > My objection is to making our policies and tools more restrictive > than they need to be. We shouldn't expect everyone to study whole > manuals just to figure out how to successfully commit a change (or > learn how to format it just t

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/11/21 3:13 AM, Jonathan Wakely wrote: On Thu, 10 Jun 2021 at 22:16, Martin Sebor wrote: I don't see why the script users should be subjected to this tedium when it can be done in the script itself with (presumably) only a little more effort. The proposed change is, IMO, a step in the wrong

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021 at 16:45, Joseph Myers wrote: > > On Fri, 11 Jun 2021, Jonathan Wakely via Gcc wrote: > > > If you're not already doing a brief "subject" line in your git > > commits, you're Doing It Wrong! > > If you don't have a subject line which is more than one word, and does not > look l

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021, Jonathan Wakely via Gcc wrote: > If you're not already doing a brief "subject" line in your git > commits, you're Doing It Wrong! If you don't have a subject line which is more than one word, and does not look like a ChangeLog header line, and which is followed by a blank li

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Fri, 11 Jun 2021 at 10:08, Jonathan Wakely wrote: > > On Thu, 10 Jun 2021 at 18:06, Martin Sebor wrote: > > By "the subject line" are you referring to what the ChangeLog calls > > $git_description, and, AFAICS, consists of multiple lines? (Based > > on the Example patch on the conventions page

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 10 Jun 2021 at 22:16, Martin Sebor wrote: > I don't see why the script users should be subjected to this tedium > when it can be done in the script itself with (presumably) only > a little more effort. The proposed change is, IMO, a step in > the wrong direction. I don't see why "improve

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 10 Jun 2021 at 18:06, Martin Sebor wrote: > > On 6/10/21 9:56 AM, Jonathan Wakely wrote: > > On Thu, 10 Jun 2021 at 15:56, Martin Sebor wrote: > >> > >> On 6/10/21 4:40 AM, Jonathan Wakely via Gcc wrote: > >>> On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: > > On Thu, Jun 10

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 3:28 PM, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 03:16:43PM -0600, Martin Sebor wrote: Just look at the start of this thread. Some people put the [PRn] only in the first line of the commit. And that is what these changes want to diagnose, that is an error and results in bug

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 10, 2021 at 03:16:43PM -0600, Martin Sebor wrote: > > Just look at the start of this thread. Some people put > > the [PRn] only in the first line of the commit. And that is > > what these changes want to diagnose, that is an error and results > > in bugzilla not being updated. >

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 1:09 PM, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 12:55:43PM -0600, Martin Sebor wrote: Instead of rejecting commits that don't mention all the same PRs on the first line of the commit as in the ChangeLog entries it seems that the Git commit script could extract the PR referen

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 10, 2021 at 12:55:43PM -0600, Martin Sebor wrote: > Instead of rejecting commits that don't mention all the same PRs on > the first line of the commit as in the ChangeLog entries it seems > that the Git commit script could extract the PR references from > just the ChangeLong entries

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 11:30 AM, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 11:20:26AM -0600, Martin Sebor wrote: One other note: you mention policy above, which suggests a requirement. My understanding is that the format of a commit message is a convention put in place to take some of the tedium out of c

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 10, 2021 at 11:20:26AM -0600, Martin Sebor wrote: > One other note: you mention policy above, which suggests a requirement. > My understanding is that the format of a commit message is a convention > put in place to take some of the tedium out of creating ChangeLog > entries. If that's

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 11:06 AM, Martin Sebor wrote: On 6/10/21 9:56 AM, Jonathan Wakely wrote: On Thu, 10 Jun 2021 at 15:56, Martin Sebor wrote: On 6/10/21 4:40 AM, Jonathan Wakely via Gcc wrote: On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wak

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 9:56 AM, Jonathan Wakely wrote: On Thu, 10 Jun 2021 at 15:56, Martin Sebor wrote: On 6/10/21 4:40 AM, Jonathan Wakely via Gcc wrote: On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wakely via Gcc wrote: On 10/06/21 10:44 +010

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 10 Jun 2021 at 16:55, Tobias Burnus wrote: > Independent of the PR matching and checking issues, I think Jonathan was > thinking about extending the documentation (as I gathered from IRC > #gcc); Right. > I did not quite follow whether it is about best practice or > contained bits which

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 10 Jun 2021 at 15:56, Martin Sebor wrote: > > On 6/10/21 4:40 AM, Jonathan Wakely via Gcc wrote: > > On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: > >> > >> On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wakely via Gcc wrote: > >>> On 10/06/21 10:44 +0100, Jonathan Wakely wrote: >

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 10.06.21 16:55, Martin Sebor via Gcc wrote: I'm a little lost as to what's being changed, and, truth be told, what exactly the current "right" format is. Where are the PRn strings recognized as special? For my version of the patch at least, which is https://gcc.gnu.org/pipermail/gcc-pat

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 4:40 AM, Jonathan Wakely via Gcc wrote: On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wakely via Gcc wrote: On 10/06/21 10:44 +0100, Jonathan Wakely wrote: Quite interesting idea! Are you willing to prepare a patch for it?

[Patch] contrig/gcc-changelog: Check that PR in subject in in changelog (was:: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

On 10.06.21 10:07, Martin Liška wrote: On 6/10/21 8:35 AM, Tobias Burnus wrote: One options would be to require a 'PR /' line if there is 'PRn+' in the commit title, rejecting the commit otherwise. Quite interesting idea! Are you willing to prepare a patch for it? Done. I was thinking o

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, 10 Jun 2021 at 11:08, Jakub Jelinek wrote: > > On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wakely via Gcc wrote: > > On 10/06/21 10:44 +0100, Jonathan Wakely wrote: > > > > Quite interesting idea! Are you willing to prepare a patch for it? > > > > > > This works. > > > > And this wo

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On Thu, Jun 10, 2021 at 11:01:49AM +0100, Jonathan Wakely via Gcc wrote: > On 10/06/21 10:44 +0100, Jonathan Wakely wrote: > > > Quite interesting idea! Are you willing to prepare a patch for it? > > > > This works. > > And this works better, because it checks the PR in the title matches > one in

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 10/06/21 10:44 +0100, Jonathan Wakely wrote: Quite interesting idea! Are you willing to prepare a patch for it? This works. And this works better, because it checks the PR in the title matches one in the changelog. I'll get something added to the tests and prep this for commit. diff --g

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

> Quite interesting idea! Are you willing to prepare a patch for it? This works. diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py index bd8c1ff7af2..58aad8b7f26 100755 --- a/contrib/gcc-changelog/git_commit.py +++ b/contrib/gcc-changelog/git_commit.py @@ -15

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 2021/6/10 11:31, Xionghu Luo via Gcc-patches wrote: > Hi, > I noticed that the "git gcc-commit-mklog" command doesn't extract PR > number from title to ChangeLog automatically, then the committed patch > doesn't update the related bugzilla PR website after check in the patch? Well then you shou

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 8:35 AM, Tobias Burnus wrote: On 10.06.21 08:17, Martin Liška wrote: Yes, we currently only support automatic extraction from comments from test-cases. How does your commit title look like? Note that we require bugzilla components being part of PR entry, which is not commonly used in

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 8:25 AM, Xionghu Luo wrote: On 2021/6/10 14:17, Martin Liška wrote: On 6/10/21 7:22 AM, Xionghu Luo wrote: Sorry, should be sent to this mail-list. On 2021/6/10 11:31, Xionghu Luo via Gcc-patches wrote: Hi, I noticed that the "git gcc-commit-mklog" command doesn't extract PR num

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 10.06.21 08:17, Martin Liška wrote: Yes, we currently only support automatic extraction from comments from test-cases. How does your commit title look like? Note that we require bugzilla components being part of PR entry, which is not commonly used in git titles due to length limitation. On

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 2021/6/10 14:17, Martin Liška wrote: > On 6/10/21 7:22 AM, Xionghu Luo wrote: >> Sorry, should be sent to this mail-list. >> >> >> On 2021/6/10 11:31, Xionghu Luo via Gcc-patches wrote: >>> Hi, >>> I noticed that the "git gcc-commit-mklog" command doesn't extract PR >>> number from title to C

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

On 6/10/21 7:22 AM, Xionghu Luo wrote: Sorry, should be sent to this mail-list. On 2021/6/10 11:31, Xionghu Luo via Gcc-patches wrote: Hi, I noticed that the "git gcc-commit-mklog" command doesn't extract PR number from title to ChangeLog automatically, then the committed patch doesn't update

Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog

Sorry, should be sent to this mail-list. On 2021/6/10 11:31, Xionghu Luo via Gcc-patches wrote: Hi, I noticed that the "git gcc-commit-mklog" command doesn't extract PR number from title to ChangeLog automatically, then the committed patch doesn't update the related bugzilla PR website after ch