On 6/17/21 4:18 AM, Jonathan Wakely wrote:
On Thu, 17 Jun 2021 at 02:01, Martin Sebor wrote:
On 6/16/21 6:40 PM, Jason Merrill wrote:
On 6/16/21 8:17 PM, Martin Sebor wrote:
3) adds the PR component/nnnnn to each ChangeLog
This would be reverting the r12-771 change, which seems both unrelated
and undesirable.
Now I'm confused. Isn't that just what caused the problem to begin
with? (The bug not being updated with the commit because it's not
in the ChangeLog entries?)
No.
The original problem is that the PR wasn't in the body of the commit AT ALL.
But I see [PR100085] right there at the end of the summary line:
https://gcc.gnu.org/pipermail/gcc/2021-June/236346.html
and here:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f700e4b0ee3ef53b48975cf89be26b9177e3a3f3
The current mklog.py will do this:
PR cmpt/nnnn
gcc/ChangeLog:
* blah.c (blah): Blah blah.
That will cause updates to bugzilla, it works fine. You do not need to
change it to:
gcc/ChangeLog:
PR cmpt/nnnn
* blah.c (blah): Blah blah.
That would also work, but isn't necessary (and would be reverting the
r12-771 change).
Either of the forms above will update bugzilla. The original problem
was that neither of those forms was used.
You mean the sole reason why Bugzilla wasn't updated was that
the component was missing from the PR? And the proposed change
is to reject commits without the component bit? Why?
Martin
