On Thu, Jun 10, 2021 at 12:55:43PM -0600, Martin Sebor wrote:
> Instead of rejecting commits that don't mention all the same PRs on
> the first line of the commit as in the ChangeLog entries it seems
> that the Git commit script could extract the PRnnnn references from
> just the ChangeLong entries (if we wanted to constrain it that way
> to avoid the unrelated references and append each to the end of
> the $git_description if it isn't already there. I thought it
> already did that (and more).
Just look at the start of this thread. Some people put
the [PRnnnnn] only in the first line of the commit. And that is
what these changes want to diagnose, that is an error and results
in bugzilla not being updated.
The current changes won't do the other direction, i.e. if there
is a PR line in the ChangeLog entry complain about [PRnnnnn] missing
in the first line. The fact that it isn't required by the script doesn't
mean people shouldn't do it, but if they occassionally forget, it is not
that bad as not mentioning it in ChangeLog.
Jakub
