Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-24 Thread Igor Filatov
So I'd created a new project instead of forking and it didn't give me an option to manually chose libfprint/libfprint as target for the merge request. Which is weird, I think github allows that at least... but I'm not sure and it's not important. I've re-created as fork and everything seems fine no

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-24 Thread Bastien Nocera
On Sun, 2018-06-24 at 14:25 +0300, Igor Filatov wrote: > Bastien, > > I've incorporated latest upstream changes so I could open a merge > request but it looks like on gitlab I need a permission to do it. Or > should I just send a patch? You don't have rights to commit directly to the libfprint r

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-24 Thread Igor Filatov
Bastien, I've incorporated latest upstream changes so I could open a merge request but it looks like on gitlab I need a permission to do it. Or should I just send a patch? ___ fprint mailing list fprint@lists.freedesktop.org https://lists.freedesktop.org

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Igor Filatov
Ok, I'll try to find some time to prepare a patch against upstream in the coming days. On Mon, Jun 18, 2018 at 4:22 PM Hans de Goede wrote: > Hi, > > On 18-06-18 15:03, Bastien Nocera wrote: > > On Mon, 2018-06-18 at 15:01 +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 18-06-18 14:58, Igor Fi

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Hans de Goede
Hi, On 18-06-18 15:03, Bastien Nocera wrote: On Mon, 2018-06-18 at 15:01 +0200, Hans de Goede wrote: Hi, On 18-06-18 14:58, Igor Filatov wrote: I'd like to but I'm worried that people will have bad experience with these devices (esp. 96x96 ones) and blame libfprint. And I still haven't had th

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Bastien Nocera
On Mon, 2018-06-18 at 15:01 +0200, Hans de Goede wrote: > Hi, > > On 18-06-18 14:58, Igor Filatov wrote: > > I'd like to but I'm worried that people will have bad experience > > with these devices (esp. 96x96 ones) and blame libfprint. And I > > still haven't had the chance to pull in latest upstr

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Hans de Goede
Hi, On 18-06-18 14:58, Igor Filatov wrote: I'd like to but I'm worried that people will have bad experience with these devices (esp. 96x96 ones) and blame libfprint. And I still haven't had the chance to pull in latest upstream, so... Well ATM people are just blindly adding new USB-ids witho

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Igor Filatov
I'd like to but I'm worried that people will have bad experience with these devices (esp. 96x96 ones) and blame libfprint. And I still haven't had the chance to pull in latest upstream, so... On Mon, Jun 18, 2018 at 3:53 PM Bastien Nocera wrote: > On Wed, 2018-01-17 at 15:11 +0100, Sébastien Béc

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-06-18 Thread Bastien Nocera
On Wed, 2018-01-17 at 15:11 +0100, Sébastien Béchet wrote: > On 2018-01-17 12:12, Igor Filatov wrote: > > Looks like o1ca as well https://github.com/iafilatov/libfprint/pull > > /4 > > Not o1ca but 0x0C1A. I create repository for POC: > > http://github.com/sbechet/elanfp Any plans on sending tho

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-03-04 Thread TeEmZe
totally wrong. I’ll try to fix this and write you as soon as I have new information. Kind regards Timo From: fprint On Behalf Of TeEmZe Sent: Sunday, 4 March 2018 18:23 To: 'Igor Filatov' Cc: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-03-04 Thread TeEmZe
If you have a better idea, let me know. Regards Timo From: fprint On Behalf Of TeEmZe Sent: Sunday, 11 February 2018 00:07 To: 'Igor Filatov' Cc: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi, Well, that’s the problem. Currently

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-10 Thread TeEmZe
[mailto:ia.fila...@gmail.com] Sent: Saturday, 10 February 2018 23:45 To: TeEmZe Cc: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi Timo, I'll only be able to test closer to the end of next week... Although I'm not sure I understand what you mea

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-10 Thread Igor Filatov
t; > *From:* fprint [mailto:fprint-boun...@lists.freedesktop.org] *On Behalf > Of *TeEmZe > *Sent:* Friday, 9 February 2018 23:48 > *To:* 'Igor Filatov' ; fprint@lists.freedesktop.org > > > *Subject:* Re: [fprint] elan patch + poc 0x903 and 0x0C03 > > > > H

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-10 Thread TeEmZe
; ; fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi Igor, I implemented the basis of an algorithm – you can take a look at it here <https://github.com/MetaColon/Libfprint/tree/master/Algorithm> . It is however far from finished or even optimised and is

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-09 Thread TeEmZe
Kind regards Timo From: fprint [mailto:fprint-boun...@lists.freedesktop.org] On Behalf Of Igor Filatov Sent: Friday, 9 February 2018 20:43 To: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi Timo, I've noticed this when working on

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-09 Thread Igor Filatov
t;> *From:* fprint [mailto:fprint-boun...@lists.freedesktop.org] *On Behalf >> Of *wp12880529-timo wp12880529-timo >> *Sent:* Friday, 9 February 2018 03:30 >> *To:* Hans de Goede ; Sebastien Bechet < >> sebastien.bec...@osinix.com>; Igor Filatov >> *Cc:* fprin

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-09 Thread TeEmZe
[mailto:fprint-boun...@lists.freedesktop.org] On Behalf Of wp12880529-timo wp12880529-timo Sent: Friday, 9 February 2018 03:30 To: Hans de Goede ; Sebastien Bechet ; Igor Filatov Cc: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi Igor, I tried the new version

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-08 Thread wp12880529-timo wp12880529-timo
> > > > > > > > > > > Kind regards, > > > > > > > > > > > > Timo > > > > > > > > > > > >

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-02-04 Thread Igor Filatov
maybe a bit of >> help including it into the main project. >> >> >> >> >> >> Kind regards, >> >> >> >> Timo >> >> >> >> -Original Message- >> From: Hans de Goede [mailto:hdego...@redhat.com] >

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-30 Thread Igor Filatov
gorithm which does a good job of matching > (with example code please). Once we have that we can worry about > integrating it into libfprint (IMHO). > > > > Regards, > > > > Hans > > > > > > > > > > > > > > > > > > Kind

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-30 Thread TeEmZe
; < <mailto:sebastien.bec...@osinix.com> sebastien.bec...@osinix.com>; TeEmZe < > <mailto:t...@teemze.de> t...@teemze.de>; > <mailto:fprint@lists.freedesktop.org> fprint@lists.freedesktop.org > *Subject:* Re: [fprint] elan patch + poc 0x903 and 0x0C03 > > Well

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-30 Thread Hans de Goede
...@gmail.com> <mailto:ia.fila...@gmail.com <mailto:ia.fila...@gmail.com>>> >     Cc: TeEmZe mailto:t...@teemze.de> <mailto:t...@teemze.de <mailto:t...@teemze.de>>>; konachan@gmail.com <mailto:konachan....@gmail.com> <mailt

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-30 Thread Igor Filatov
as I > currently > >> don't have access to the Laptop. I'll notify you as soon as I manage to > get > >> the data. > >> > >> Regards, > >> > >> Timo > >> > >> -Original Message- &g

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread Vasily Khoruzhick
dhat.com >> <mailto:hdego...@redhat.com>] >> Sent: Thursday, 18 January 2018 16:14 >> To: Sebastien Bechet > <mailto:sebastien.bec...@osinix.com>>; Igor Filatov > <mailto:ia.fila...@gmail.com>> >> Cc: TeEmZe mailto:t...@teemze.de>>; >&

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread Igor Filatov
t; *Sent:* Monday, 29 January 2018 20:26 > > > *To:* Hans de Goede > > *Cc:* konachan@gmail.com; Sebastien Bechet < > sebastien.bec...@osinix.com>; TeEmZe ; > fprint@lists.freedesktop.org > > > *Subject:* Re: [fprint] elan patch + poc 0x903 and 0x0C03 > >

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread TeEmZe
replace a library? Kind regards, Timo From: Igor Filatov [mailto:ia.fila...@gmail.com] Sent: Monday, 29 January 2018 20:26 To: Hans de Goede Cc: konachan@gmail.com; Sebastien Bechet ; TeEmZe ; fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread Igor Filatov
t the data. > > > > Regards, > > > > Timo > > > > -Original Message- > > From: Hans de Goede [mailto:hdego...@redhat.com hdego...@redhat.com>] > > Sent: Thursday, 18 January 2018 16:14 > > To: Sebastien Bec

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread Hans de Goede
...@redhat.com>] Sent: Thursday, 18 January 2018 16:14 To: Sebastien Bechet mailto:sebastien.bec...@osinix.com>>; Igor Filatov mailto:ia.fila...@gmail.com>> Cc: TeEmZe mailto:t...@teemze.de>>; konachan@gmail.com <mailto:konachan....@gmail.com>; fprint@lists.free

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-29 Thread wp12880529-timo wp12880529-timo
Hello Igor, where do I get the fprint_demo tool from? I failed to find it. The overall image looks alright, but still not very good - I attached an image of mine. I made a really careful swipe and now it detects my finger in about 50% of the cases - still not very good, but I guess I'll just

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-28 Thread Igor Filatov
1 out of 10 isn't practical so it shouldn't be like that. I'm getting roughly 4 OKs out of 5 (which is still somewhat low and can be attributed to the quality if images the scanner produces with swiping; I also have a Validity sensor and it blows my Elan out of the water). 1. Try to get some visua

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread wp12880529-timo wp12880529-timo
Hi, the enroll process seems to work. However, when verifying it detects my finger in about 1 out of 10 tries. Is this a bug or is it normal? Regards Timo > Igor Filatov hat am 27. Januar 2018 um 18:52 > geschrieben: > > Yes, this time it worked. First of all, you should be able to op

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread Igor Filatov
Yes, this time it worked. First of all, you should be able to open finger.pgm in the same directory with an image viewer and see your finger. Then you can try exmaples/enroll and examples/verify to enroll and verify your fingerprint. If everything seems ok, install the driver with `sudo make instal

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread wp12880529-timo wp12880529-timo
-> 403F > > > > <- 55 1.3.3 > > > > -> 4031 > > > > -> 0009 > > > > <- ? 1.3.2 > > > > ... >

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread Igor Filatov
t; > <- ? 1.3.2 > > ... > > -> 4031 > > -> 403F > > <- 55 1.3.3 > > ... > > -> 4031 > > -> 0009 > > <- ? > > -> 000b > > -> 0009 > > <- ? > > ->

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread TeEmZe
y, 27 January 2018 15:43 To: Meta Colon ; Igor Filatov Cc: Hans de Goede ; konachan....@gmail.com; fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hello Timo, Le samedi 27 janvier 2018 à 13:40 +0100, Meta Colon a écrit : > fp:debug

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread Sebastien Bechet
Hello Timo, Le samedi 27 janvier 2018 à 13:40 +0100, Meta Colon a écrit : > fp:debug [find_supporting_driver] driver elan supports USB device > > 04f3:0c1a > > elan:debug [activate_run_state] FW ver 1.66 > > elan:debug [activate_run_state] sensor dimensions, WxH: 144x64 Ok, I record your informat

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-27 Thread Meta Colon
..@redhat.com>>; konachan@gmail.com <mailto:konachan@gmail.com>; Sebastien Bechet mailto:sebastien.bec...@osinix.com>>; TeEmZe mailto:t...@teemze.de>> *Cc:* fprint@lists.freedesktop.org <mailto:fprint@lists.freedesktop.org> *Subject:* Re: [fprint]

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-26 Thread Igor Filatov
han@gmail.com; > Sebastien Bechet ; TeEmZe > *Cc:* fprint@lists.freedesktop.org > > > *Subject:* Re: [fprint] elan patch + poc 0x903 and 0x0C03 > > > > I've updated the driver to support the devices known so far. Please see if > it works for you. Please send me yo

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-26 Thread TeEmZe
; Sebastien Bechet ; TeEmZe Cc: fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 I've updated the driver to support the devices known so far. Please see if it works for you. Please send me your logs if not. I've enabled all commands for all devic

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
Updated the driver. Skipping calibration for 0x0903 till we know more. I'll ask Kt soon but I need to prepare first because I have a few Qs of my own. On Wed, Jan 24, 2018 at 4:33 PM Sébastien Béchet < sebastien.bec...@osinix.com> wrote: > I do not know. I am not the right person I updated the qu

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
I do not know. I am not the right person I updated the questions with our latest comments. Maybe you can ask directly kt@elan? see [questions](https://github.com/sbechet/elanfp/#preparation-of-questions-for-ktelan). On 2018-01-24 13:50, Igor Filatov wrote: Sebastien, Are you sure it's abou

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
Sebastien, Are you sure it's about firmware versions, not the devices themselves? Do we have 0x0903 with different firmware? On Wed, Jan 24, 2018 at 12:10 PM Sébastien Béchet < sebastien.bec...@osinix.com> wrote: > For sure. > > Better code in attachment (correctly remove 4024 access for 0903).

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
For sure. Better code in attachment (correctly remove 4024 access for 0903). On 2018-01-24 11:03, Igor Filatov wrote: I have a feeling that for 0903 commands 4023 and 4024 mean something different. I-byte mean is weird. given 2-byte "pixels". diff --git a/libfprint/drivers/elan.c b/libfprint/d

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
I have a feeling that for 0903 commands 4023 and 4024 mean something different. I-byte mean is weird. given 2-byte "pixels". On Wed, 24 Jan 2018, 11:59 Sébastien Béchet, wrote: > Hello Igor, > > This hack for firmware <= 0x0153 working. > > ___ fprint

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
Hello Igor, This hack for firmware <= 0x0153 working. diff --git a/libfprint/drivers/elan.c b/libfprint/drivers/elan.c index 1152509..a2cc013 100644 --- a/libfprint/drivers/elan.c +++ b/libfprint/drivers/elan.c @@ -45,6 +45,9 @@ static struct fpi_frame_asmbl_ctx assembling_ctx = { }; struct

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
Hello Igor, Thank you very much for your driver modification. It remains a problem for firmware version 1.53. get_calib_mean_cmd answer length is 1 not 2. see: https://github.com/sbechet/elanfp#hardware-report see: https://github.com/sbechet/elanfp/blob/master/elanfp.c#L178 MEAN_H only. I ha

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-23 Thread Igor Filatov
e- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Thursday, 18 January 2018 16:14 > To: Sebastien Bechet ; Igor Filatov < > ia.fila...@gmail.com> > Cc: TeEmZe ; konachan@gmail.com; > fprint@lists.freedesktop.org > Subject: Re: [fprint] elan patch + poc 0x90

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-19 Thread TeEmZe
y 2018 16:14 To: Sebastien Bechet ; Igor Filatov Cc: TeEmZe ; konachan@gmail.com; fprint@lists.freedesktop.org Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi, On 18-01-18 16:03, Sebastien Bechet wrote: > Thank you Igor. Hans, you can try again with last version. Not tested,

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread Hans de Goede
Hi, On 18-01-18 16:03, Sebastien Bechet wrote: Thank you Igor. Hans, you can try again with last version. Not tested, but looking at the code, it will loop in the calibration, my 2 devices both need a: if (result == 0x03) break; Directly after the: printf("Calibration Status: 0x%x\n", resul

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread Sebastien Bechet
Thank you Igor. Hans, you can try again with last version. I also tried to remove reset+fuseload then calibration not working anymore for 0x0903. It seems it is a part for calibration (same pdf file for reset _and_ calibration or reset _then_ calibration?). https://github.com/sbechet/elanfp

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread Igor Filatov
> square and seems to contain the image 3 times Could be because convert is hardcoded at 96x96. On Thu, 18 Jan 2018, 12:04 Hans de Goede, wrote: > Hi, > > On 18-01-18 10:48, Sébastien Béchet wrote: > > On 17-01-18 19:21, Igor Filatov wrote: > >> We didn't have the spec before so I had no idea h

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread Hans de Goede
Hi, On 18-01-18 10:48, Sébastien Béchet wrote: On 17-01-18 19:21, Igor Filatov wrote: We didn't have the spec before so I had no idea how different devices worked. Especially given that some commands which worked fine for me produced errors one other devices. Now that we have the docs I'll wo

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread Sébastien Béchet
On 17-01-18 19:21, Igor Filatov wrote: We didn't have the spec before so I had no idea how different devices worked. Especially given that some commands which worked fine for me produced errors one other devices. Now that we have the docs I'll work on adapting the driver. Naturally, any info yo

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-18 Thread TeEmZe
2018 16:26 To: Igor Filatov Cc: fprint@lists.freedesktop.org; Sébastien Béchet Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi, On 17-01-18 16:22, Igor Filatov wrote: > For me this is either 0x01 or 0x03, just like in the docs. But I do remember > that I could never make it

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Hans de Goede
6:26 To: Igor Filatov mailto:ia.fila...@gmail.com>> Cc: fprint@lists.freedesktop.org <mailto:fprint@lists.freedesktop.org>; Sébastien Béchet mailto:sebastien.bec...@osinix.com>> Subject: Re: [fprint] elan patch + poc 0x903 and 0x0C03 Hi, On 17-01-18 16:22, Igor

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Igor Filatov
> > Regards, > > Timo > > -Original Message- > From: fprint [mailto:fprint-boun...@lists.freedesktop.org] On Behalf Of > Hans de Goede > Sent: Wednesday, 17 January 2018 16:26 > To: Igor Filatov > Cc: fprint@lists.freedesktop.org; Sébastien Béchet < > sebastien.

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Hans de Goede
Hi, On 17-01-18 16:22, Igor Filatov wrote: For me this is either 0x01 or 0x03, just like in the docs. But I do remember that I could never make it behave like Windows driver did, e.g. return same values when I sent the same commands in the same order. But I didn't know I had to give it some t

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Igor Filatov
For me this is either 0x01 or 0x03, just like in the docs. But I do remember that I could never make it behave like Windows driver did, e.g. return same values when I sent the same commands in the same order. But I didn't know I had to give it some time, so that could be the problem. And I've neve

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Hans de Goede
Hi, On 17-01-18 14:46, Sébastien Béchet wrote: Hello, I have done more test and find a functionnal calibration method. Strangely, the calibration return returns Mean_H and not the expected status. I need to read the "FP Status" register for the calibration to work in the next step. Also, i a

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Sébastien Béchet
On 2018-01-17 12:12, Igor Filatov wrote: Looks like o1ca as well https://github.com/iafilatov/libfprint/pull/4 Not o1ca but 0x0C1A. I create repository for POC: http://github.com/sbechet/elanfp ___ fprint mailing list fprint@lists.freedesktop.org h

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Sébastien Béchet
Hello, I have done more test and find a functionnal calibration method. Strangely, the calibration return returns Mean_H and not the expected status. I need to read the "FP Status" register for the calibration to work in the next step. Also, i added 0x04f3:0x01cA to the test list. Hans, can

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Igor Filatov
Looks like o1ca as well https://github.com/iafilatov/libfprint/pull/4 I wonder if we can get a list of ids if devices like these. 2018-01-17 12:50 GMT+02:00 Sébastien Béchet : > Hello, > > In attachment what I understood from the documentation. > > must work for > > 0x04f3,0x0903 > 0x04f3,0x0907 >

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Sébastien Béchet
Hello, In attachment what I understood from the documentation. must work for 0x04f3,0x0903 0x04f3,0x0907 0x04f3,0x0C03 0x04f3,0x0C16 Please try it. #include #include #include #include #include #include #include #define BULK_EP1_OUT0x01 #define BULK_EP2_IN 0x82 #define BULK_EP3

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Sébastien Béchet
Hello Hans de Goede, On 2018-01-17 08:57, Hans de Goede wrote: https://fedorapeople.org/~jwrdegoede/elan-fingerprint/ Thank you, you are a magician :-) Unfortunately I have not yet had time to look at supporting my own reader and it does not look like I will have time for this soon. Still th

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-17 Thread Igor Filatov
Wow, thanks, Hans! This should be really useful. I'll take a closer look later today. On Wed, 17 Jan 2018, 09:57 Hans de Goede, wrote: > Hi Sébastien and Igor, > > I too have an Elan fingerprint reader tucked away in a corner > of my touchpad, my model is: 04f3:0c16 . > > Since I've a contact in

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-16 Thread Hans de Goede
Hi Sébastien and Igor, I too have an Elan fingerprint reader tucked away in a corner of my touchpad, my model is: 04f3:0c16 . Since I've a contact inside Elantech from my work on touchpads, I've been communicating with them to get some specifications and they have provided me with some command r

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-16 Thread Igor Filatov
Hi Sebastien, Thanks for your work. Please try https://github.com/iafilatov/libfprint/commit/fec2a1f3cffca1b1da2f9e379745db344bab2ab5 and see if it works for you. Also please tell me if you don't want your email mentioned in the header. 2018-01-16 13:37 GMT+02:00 Sébastien Béchet : > Hello Igor,

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-16 Thread Sébastien Béchet
Hello Igor, On 2018-01-15 17:38, Igor Filatov wrote: I don't quite understand what happens though. You've replaced a number of stages by plain image read commands (CALIBRATE, CAPTURE_START, DEACTIVATE) which don't seem to do anything but read and discard the image. Maybe it's fine to not do anyt

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-15 Thread Igor Filatov
Hi Sébastien, thanks for the patches! I don't quite understand what happens though. You've replaced a number of stages by plain image read commands (CALIBRATE, CAPTURE_START, DEACTIVATE) which don't seem to do anything but read and discard the image. Maybe it's fine to not do anything at all at th

[fprint] elan patch + poc 0x903 and 0x0C03

2018-01-15 Thread Sébastien Béchet
Hello, I take time to create a POC for 04f3:0903 Elan Microelectronics Corp driver. I think it is working too for 0x0C03. Can someone test it (poc_0903_0C03.diff)? I found a bug in elan.c (see bugframesup30.diff) and a small typo (typo.diff). Thank you. diff --git a/libfprint/drivers/el