Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 02/01/2016 04:48 AM, Mats Peterson wrote: On 01/31/2016 11:22 PM, Mats Peterson wrote: also i dont think its just avi. The raw video decoder is potentially used for more than avi. mkv and nut come to mind as potential formats that might use the same codepath Yes it is used for other file

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 11:22 PM, Mats Peterson wrote: also i dont think its just avi. The raw video decoder is potentially used for more than avi. mkv and nut come to mind as potential formats that might use the same codepath Yes it is used for other file formats as well, but only AVI and QuickTime ex

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 11:19 PM, Michael Niedermayer wrote: i think that default palette code could be removed if 1bpp->pal8 isnt done when theres no palete also i dont think its just avi. The raw video decoder is potentially used for more than avi. mkv and nut come to mind as potential formats that migh

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 11:11:31PM +0100, Mats Peterson wrote: > On 01/31/2016 11:08 PM, Michael Niedermayer wrote: > >On Sun, Jan 31, 2016 at 10:53:35PM +0100, Mats Peterson wrote: > >>On 01/31/2016 10:49 PM, Mats Peterson wrote: > this decission should be made by other developers, who where n

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 11:08 PM, Michael Niedermayer wrote: my suggestion is just about the raw video decoder, that is if a AVPacket contains monochrome 1bpp black/white data without a palette that this is passed through and not converted to pal8 * If you want to pass it through, just use "-c:v copy".

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 11:08 PM, Michael Niedermayer wrote: On Sun, Jan 31, 2016 at 10:53:35PM +0100, Mats Peterson wrote: On 01/31/2016 10:49 PM, Mats Peterson wrote: this decission should be made by other developers, who where not involved in this disagreement, that should result in a outcome that rep

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:53 PM, Mats Peterson wrote: Just because we have monow and monob pixel formats, it doesn't mean they should be used wherever 1 bpp data is involved. And once again, the semantics according to Microsoft are that 1 bpp AVI is NEVER monochrome, it is ALWAYS palettized, regardless of

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 10:53:35PM +0100, Mats Peterson wrote: > On 01/31/2016 10:49 PM, Mats Peterson wrote: > >>this decission should be made by other developers, who where not > >>involved in this disagreement, that should result in a outcome that > >>represents the preferrances of the community

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:49 PM, Mats Peterson wrote: this decission should be made by other developers, who where not involved in this disagreement, that should result in a outcome that represents the preferrances of the community better. wm4 is already on my side, as far as I understand. Just beca

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:49 PM, Michael Niedermayer wrote: So, will you apply my patch? Or are you willing to change to this funny logic for every file format that uses 1 bpp? As I said, both 2 and 4 bpp uses pal8 internally, and nobody seems to complain about that. I'm beginning to get rather tired of t

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 10:33:33PM +0100, Mats Peterson wrote: > On 01/31/2016 10:31 PM, Michael Niedermayer wrote: > > > >If a AVI contains a palette one might argue its a paletted avi > >either way i dont know, i dont have such a file > >it would be needed to have real world files in that categor

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:33 PM, Mats Peterson wrote: On 01/31/2016 10:31 PM, Michael Niedermayer wrote: If a AVI contains a palette one might argue its a paletted avi either way i dont know, i dont have such a file it would be needed to have real world files in that category to know if treating them as

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:31 PM, Michael Niedermayer wrote: If a AVI contains a palette one might argue its a paletted avi either way i dont know, i dont have such a file it would be needed to have real world files in that category to know if treating them as pal8 is better or not So, will you apply

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 10:08:41PM +0100, Mats Peterson wrote: > On 01/31/2016 03:07 PM, Michael Niedermayer wrote: > >On Sun, Jan 31, 2016 at 01:27:22PM +0100, Mats Peterson wrote: > >>I don't really appreciate that you're doing things behind my back, > >>Michael. There's nothing mentioned on the

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 10:08 PM, Mats Peterson wrote: Even if you stubbornly decide to keep your patch, it is incorrect anyway. If a 1 bpp AVI contains a palette, black & white or not, pal8 will be used regardless. Look at the snippet below. Furthermore, the palette side data packet will be retrieved twi

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:07 PM, Michael Niedermayer wrote: On Sun, Jan 31, 2016 at 01:27:22PM +0100, Mats Peterson wrote: I don't really appreciate that you're doing things behind my back, Michael. There's nothing mentioned on the ffmpeg-devel mailing lis indeed, i should have clearly stated that i ap

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 07:04 PM, Mats Peterson wrote: Why whould it "stop working well" with monochrome just because we use a different internal depth? And as I said, both QuickTime (raw and RLE) Both 2 bpp and 4 bpp use pal8 internally, but nobody seems to complain about that fact. Mats ___

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 07:04 PM, Mats Peterson wrote: either way, as said iam happy to switch to using pal8 for monochrome avis if people want. I just dont know if people want that Furthermore, there is no such thing as "monochrome AVIs". The semantics are that they are palettized, even if there are on

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 05:48 PM, Michael Niedermayer wrote: ffmpeg (the application) reads and writes multimedia files why should ffmpeg suddenly stop working well with monochrome ? (and require the user to per file convert to monochrome when the input already is monochrome) Also we talk about the raw

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 04:03:36PM +0100, Mats Peterson wrote: > On 01/31/2016 03:59 PM, Michael Niedermayer wrote: > >ffmpeg source is not unchanegable, > >if you belive that pal8 should be used in place of monochrome you > >could certaily make the code act more reasonable with a 2 entry > >(black

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 04:41:44PM +0100, Mats Peterson wrote: > On 01/31/2016 04:19 PM, Mats Peterson wrote: > >People will have to get used to the video data being converted from 1 > >bpp to 8 bpp internally, just as they have become used to 2 and 4 bpp > >data being converted to 8 bpp. It should

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 04:19 PM, Mats Peterson wrote: People will have to get used to the video data being converted from 1 bpp to 8 bpp internally, just as they have become used to 2 and 4 bpp data being converted to 8 bpp. It shouldn't come as a shock, since this is perfectly logical behaviour, as long

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 04:05 PM, Mats Peterson wrote: I don't believe. It's a fact. And it is used in other places (QuickTime, both raw and RLE, and BMP) for 1 bpp data, so why shouldn't it for AVI as well? Please, just apply my latest patch that restores the pal8-only behaviour. This is a lot more logica

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 04:03 PM, Mats Peterson wrote: On 01/31/2016 03:59 PM, Michael Niedermayer wrote: ffmpeg source is not unchanegable, if you belive that pal8 should be used in place of monochrome you could certaily make the code act more reasonable with a 2 entry (black+white) PAL8 I don't belie

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:59 PM, Michael Niedermayer wrote: ffmpeg source is not unchanegable, if you belive that pal8 should be used in place of monochrome you could certaily make the code act more reasonable with a 2 entry (black+white) PAL8 I don't believe. It's a fact. And it is used in other place

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 03:33:00PM +0100, Mats Peterson wrote: > On 01/31/2016 03:29 PM, Michael Niedermayer wrote: > >less than one out of a hundread users would realize that > >also it does feel unclean to me to convert monochrome to pal8 in > >the decoder and then require the user to manually fo

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:33 PM, Mats Peterson wrote: On 01/31/2016 03:29 PM, Michael Niedermayer wrote: less than one out of a hundread users would realize that also it does feel unclean to me to convert monochrome to pal8 in the decoder and then require the user to manually force convertion of paletted

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:29 PM, Michael Niedermayer wrote: less than one out of a hundread users would realize that also it does feel unclean to me to convert monochrome to pal8 in the decoder and then require the user to manually force convertion of paletted data back to monochrome Since this is the w

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:27 PM, Michael Niedermayer wrote: It's not bizarre at all. Black & white is just a variant of palettized data in this context, it's not monochrome. And just because you don't have a non-b/w sample, it doesn't mean you should use monow. A 1 bpp AVI is not monochrome once again, it

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 03:16:46PM +0100, Mats Peterson wrote: > On 01/31/2016 03:07 PM, Michael Niedermayer wrote: > >indeed, i should have clearly stated that i applied the pal8 > >patches with the plan to use pal8 only when neccessary. > >I had asked you to implement exactly that but it seemed y

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 03:22:57PM +0100, Mats Peterson wrote: > On 01/31/2016 03:20 PM, Michael Niedermayer wrote: > >but > >converting from monochrome avis/nuts/others? to other formats would > >not store monochrome but paletted or RGB then > > > >heres an example with tiff: > > > >./ffmpeg

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:20 PM, Michael Niedermayer wrote: but converting from monochrome avis/nuts/others? to other formats would not store monochrome but paletted or RGB then heres an example with tiff: ./ffmpeg -i test.avi -vframes 1 test.tiff ./ffmpeg-ref -i test.avi -vframes 1 test-ref.tiff

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:22 PM, Mats Peterson wrote: Yes it would, but just force -pix_fmt monow then. With the reservation that pal8 to monow is somewhat erratic, but I'll leave that to you guys to solve. I'm not able to. Mats ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:20 PM, Michael Niedermayer wrote: On Sun, Jan 31, 2016 at 01:33:02PM +0100, wm4 wrote: On Sun, 31 Jan 2016 13:27:22 +0100 Mats Peterson wrote: I don't really appreciate that you're doing things behind my back, Michael. There's nothing mentioned on the ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 03:07 PM, Michael Niedermayer wrote: indeed, i should have clearly stated that i applied the pal8 patches with the plan to use pal8 only when neccessary. I had asked you to implement exactly that but it seemed you didnt know how to do that cleanly and simply so i thought "no problem

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 01:33:02PM +0100, wm4 wrote: > On Sun, 31 Jan 2016 13:27:22 +0100 > Mats Peterson wrote: > > > I don't really appreciate that you're doing things behind my back, > > Michael. There's nothing mentioned on the ffmpeg-devel mailing list > > about your "monowhite switching p

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 01:27:22PM +0100, Mats Peterson wrote: > I don't really appreciate that you're doing things behind my back, > Michael. There's nothing mentioned on the ffmpeg-devel mailing lis indeed, i should have clearly stated that i applied the pal8 patches with the plan to use pal8 on

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
On 01/31/2016 01:33 PM, wm4 wrote: On Sun, 31 Jan 2016 13:27:22 +0100 Mats Peterson wrote: I don't really appreciate that you're doing things behind my back, Michael. There's nothing mentioned on the ffmpeg-devel mailing list about your "monowhite switching patch". Furthermore, to me it's high

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread wm4
On Sun, 31 Jan 2016 13:27:22 +0100 Mats Peterson wrote: > I don't really appreciate that you're doing things behind my back, > Michael. There's nothing mentioned on the ffmpeg-devel mailing list > about your "monowhite switching patch". Furthermore, to me it's highly > unncecessary to use mono

[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

2016-01-31 Thread Mats Peterson
I don't really appreciate that you're doing things behind my back, Michael. There's nothing mentioned on the ffmpeg-devel mailing list about your "monowhite switching patch". Furthermore, to me it's highly unncecessary to use monowhite whatsoever. The space savings are quite irrelevant nowadays