Thanks for your review. No further improvements needed for this implementation
- it already handles all error cases appropriately.
Best regards,
Henry
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
Expose the drm crtc sharpness strength property which will enable
or disable the sharpness/casf based on user input. With this user
can set/update the strength of the sharpness or casf filter.
v2: Update subject[Ankit]
Signed-off-by: Nemesa Garg
Rev
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
To enable or disable the sharpness check the
casf_enable flag. While enabling the sharpness
write the programmable coefficients, sharpness
register bits and also enable the scaler.
Load the filter lut value which needs to be done
one time while enabling
> -Original Message-
> From: Nautiyal, Ankit K
> Sent: Tuesday, April 1, 2025 11:07 AM
> To: Garg, Nemesa ; intel-...@lists.freedesktop.org;
> intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Subject: Re: [PATCH 09/12] drm/i915/display: Set a scaler mode
>
>
> On 3/21/
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
Write the casf registers bits to enable the sharpness
Hmm, there is no write here. We are setting the configuration for CASF
and capturing it in crtc_state, and we are getting the configuration
after a read back.
Also, as mentioned, in previous pat
The analogix_dp_prepare_panel() returns immediately if there is no
attached panel. Drop several calls to this function which are performed
when dp->plat_data->panel is NULL.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +-
1 file
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
Compare the sharpness win_size, strength and enable bits
Signed-off-by: Nemesa Garg
---
drivers/gpu/drm/i915/display/intel_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/d
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
sharpness
This again is part of subject.
As only second scaler can be used for sharpness check if it
is available and also check if panel fitting is not enabled,
then set the sharpness as both uses pipe scaler so only one
can be enabled at a time.
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
coefficients
This is part of the subject, need to fix.
Regards,
Ankit
The sharpness property requires the use of one of the scaler
so need to set the sharpness scaler coefficient values.
These values are based on experiments and vary for different
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
register
I think this is part of the subject, need to fix this.
The strength value for sharpness is based on user input and
the winsize is based on resolution. Set the casf_enable flag
if there is a platform support and uapi strength is not zero.
O
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
HAS_CASF macro will be used to check whether platform
support the content adaptive sharpness capability or
not.
Perhaps reworded to maintain imperative mood:
Add HAS_CASF macro to check..
Otherwise LGTM.
Reviewed-by: Ankit Nautiyal
v2: Update co
Now there are no users of the return value of the drm_panel_prepare(),
drm_panel_unprepare(), drm_panel_enable() and drm_panel_disable() calls.
Usually these calls are performed from the atomic callbacks, where it is
impossible to return an error. Stop returning error codes and return
void instead.
Follow the example of other drivers and ignore return values of the
drm_panel_prepare() / unprepare() / enable() / disable() calls. There is
no possible error recovery, so the driver just logs a message.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 39
The analogix_dp_prepare_panel() is now only calling a corresponding
drm_panel function. Inline it to simplify the code.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43 +-
1 file changed, 10 insertions(+), 33 deletions(-)
diff --gi
The dp->panel_is_modeset is now a write-only field. Drop it completely.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +--
drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 -
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git
On Mon, Mar 31, 2025, at 11:20 AM, Harry Wentland wrote:
> Agreed. Little timing changes often have unintended effects.
> I have no desire to change working code unless it's required
> to fix a real-life issue.
>
> Harry
Thanks for your explanation, and for taking the time to review.
Best regar
devm_kasprintf() returns NULL when memory allocation fails. Currently,
wled_configure() does not check for this case, which results in a NULL
pointer dereference.
Add NULL check after devm_kasprintf() to prevent this issue.
Fixes: f86b77583d88 ("backlight: pm8941: Convert to using %pOFn instead o
On 3/29/25 09:48, Simon Ser wrote:
I would prefer these functions to be introduced together with the
patches adding functions to create objects and adding the new fields.
That way it's easier to check the symmetry and at no point in the
series there are memory leaks.
The object creation and
On 3/31/25 19:04, Shengyu Qu wrote:
My understanding is that currently the driver would just report no
colorop support on cursor plane and actually implement the background
plane's colorop on cursor?
No.
Again it is up to compositors or apps to determine how color pipeline
and color
On Wed, Mar 12, 2025 at 12:38:03AM +0100, Aleksandrs Vinarskis wrote:
> Take into account LTTPR capabilities when selecting maximum allowed
> link rate, number of data lines. Initialize LTTPR before
> msm_dp_panel_read_sink_caps, as
> a) Link params computation need to take into account LTTPR's cap
When devm_kasprintf() fails, it returns a NULL pointer. However, this return
value is not properly checked in the function wled_configure.
A NULL check should be added after the devm_kasprintf call to prevent potential
NULL pointer dereference error.
Fixes: f86b77583d88c ("backlight: pm8941: Co
On Tue, Apr 01, 2025 at 04:01:03AM +0300, Dmitry Baryshkov wrote:
> On Mon, Mar 31, 2025 at 03:40:27PM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov
> > wrote:
> > >
> > > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote:
> > > > Hi,
> >
Hi Dmitry,
On 30/03/25 22:36, Dmitry Baryshkov wrote:
On Thu, Mar 27, 2025 at 09:31:11PM +0530, Vignesh Raman wrote:
Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
exit with a non-zero error code while configuring them as warning in
the GitLab CI pipeline.
Can it reall
在 2025/3/27 7:46, Alex Hung 写道:
From: Harry Wentland
With the introduction of the pre-blending color pipeline we
can no longer have color operations that don't have a clear
position in the color pipeline. We deprecate all existing
plane properties. For upstream drivers those are:
- COLOR_EN
On Mon, Mar 31, 2025 at 03:40:27PM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov
> wrote:
> >
> > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin
> > > wrote:
> > > >
> > >
On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote:
> DisplayPort requires per-segment link training when LTTPR are switched
> to non-transparent mode, starting with LTTPR closest to the source.
> Only when each segment is trained individually, source can link train
> to sink.
>
On 3/29/25 09:26, Simon Ser wrote:
I would also highlight that we need to seamlessly switch between HW
fixed-function blocks and shaders/CPU with no visible difference. Depending on
the content being displayed we might need to fallback to shaders/CPU at any
time. (A classic example would be a
Rq->lock only protects the tree walk so lets move the rest out.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/gpu/drm/scheduler/sched_main.c | 31 ++
1 file changed, 17 insertions(+), 14 deleti
On 2025-03-31 09:18, Ваторопин Андрей wrote:
From: Andrey Vatoropin
Static analysis shows that pointer "svms" cannot be NULL because it points
to the object "struct svm_range_list". Remove the extra NULL check. It is
meaningless and harms the readability of the code.
In the function svm_range_
Deadline scheduling policy should be a fairer flavour of FIFO with two
main advantages being that it can naturally connect with the dma-fence
deadlines, and secondly that it can get away with multiple run queues per
scheduler.
>From the latter comes the fairness advantage. Where the current FIFO
p
Hi,
On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov
wrote:
>
> On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote:
> > >
> > > @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel
> > > *panel)
>
It doesn't make much sense to allow devices to specify their min/max
resolution as signed integers, and in Rust with CONFIG_RUST_OVERFLOW_CHECKS
enabled this provides us actual over/underflow checks. Similarly, it
doesn't really make much sense for us to allow devices to specify their
minimum/maxim
A negative resolution doesn't really make any sense, so let's make these
parameters unsigned. In C this doesn't make much of a difference, but Rust
is stricter about signed/unsigned casts and additionally can check for
arithmetic over/underflows if CONFIG_RUST_OVERFLOW_CHECKS is enabled.
Signed-of
During the review of some of my patches for KMS bindings in Rust, it was
pointed out we have some areas of DRM that are storing resolutions as
signed integers when it doesn't really make sense. Since Rust has
arithematic overflow checking by default in the kernel, let's change
these to unsigned so
On Tue, 1 Apr 2025 at 00:38, Christopher Obbard
wrote:
>
> Hi Dmitry,
>
> On Mon, 31 Mar 2025 at 17:49, Dmitry Baryshkov
> wrote:
> >
> > On 31/03/2025 18:39, Christopher Obbard wrote:
> > > Hi Johan,
> > >
> > > On Mon, 31 Mar 2025 at 09:50, Johan Hovold wrote:
> > >>
> > >> On Thu, Mar 27, 202
Hi Dmitry,
On Mon, 31 Mar 2025 at 17:49, Dmitry Baryshkov
wrote:
>
> On 31/03/2025 18:39, Christopher Obbard wrote:
> > Hi Johan,
> >
> > On Mon, 31 Mar 2025 at 09:50, Johan Hovold wrote:
> >>
> >> On Thu, Mar 27, 2025 at 04:56:53PM +, Christopher Obbard wrote:
> >>> The eDP panel has an HPD
From: Rob Clark
Add support for exporting a dma_fence fd for a specific point on a
timeline. This is needed for vtest/vpipe[1][2] to implement timeline
syncobj support, as it needs a way to turn a point on a timeline back
into a dma_fence fd. It also closes an odd omission from the syncobj
UAPI
On Mon, Mar 31, 2025 at 10:16:54PM +0800, Henry Martin wrote:
> devm_kasprintf() return NULL if memory allocation fails. Currently,
> wled_configure() does not check for this case, leading to a possible NULL
> pointer dereference.
>
> Add NULL check after devm_kasprintf() to prevent this issue.
>
On Tue, 11 Mar 2025 at 00:26, Maxime Ripard wrote:
>
> Hi,
>
> On Mon, Mar 10, 2025 at 03:16:53PM +0100, Christian König wrote:
> > [Adding Ben since we are currently in the middle of a discussion
> > regarding exactly that problem]
> >
> > Just for my understanding before I deep dive into the cod
Hi,
On Mon, Mar 31, 2025 at 08:01:34PM +0100, Mark Brown wrote:
> On Wed, Dec 11, 2024 at 01:06:17AM +0200, Cristian Ciocaltea wrote:
> > Add the necessary DT changes to enable the second HDMI output port on
> > Radxa ROCK 5B.
> >
> > While at it, switch the position of &vop_mmu and @vop to maint
On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote:
> Hi,
>
> On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote:
> >
> > @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel
> > *panel)
> >
> > ret = boe_bf060y8m_aj0_on(boe);
> > if (ret < 0) {
> >
Now that the run queue to scheduler relationship is always 1:1 we can
embed it (the run queue) directly in the scheduler struct and save on
some allocation error handling code and such.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
Move work queue allocation into a helper for a more streamlined function
body.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/gpu/drm/scheduler/sched_main.c | 28 +-
1 file changed, 14 insertion
Move the code dealing with entities entering and exiting run queues to
helpers to logically separate it from jobs entering and exiting entities.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/gpu/drm/scheduler/sched_en
Round-robin being the non-default policy and unclear how much it is used,
we can notice that it can be implemented using the FIFO data structures if
we only invent a fake submit timestamp which is monotonically increasing
inside drm_sched_rq instances.
So instead of remembering which was the last
Extract out two copies of the identical code to function epilogue to make
it smaller and more readable.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/gpu/drm/scheduler/sched_main.c | 48 +++---
1 f
Lets move all the code dealing with struct drm_sched_rq into a separate
compilation unit. Advantage being sched_main.c is left with a clearer set
of responsibilities.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/gpu/
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
Cc: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/tests/Makefile | 3 +-
.../gpu/drm/scheduler/tests/tests_scheduler.c | 548 ++
2 files changed, 550
This is similar to v2 but I dropped some patches (for now) and added some new
ones. Most notably deadline scaling based on queue depth appears to be able to
add a little bit of fairness with spammy clients (deep submission queue).
As such, on the high level main advantages of the series:
1. Code
On Thu, Mar 27, 2025 at 12:14:26PM +0200, Jani Nikula wrote:
> On Thu, 27 Mar 2025, Denis Arefev wrote:
> > The value LCD_MISC_CNTL is used in the 'aty_st_lcd()' function to
> > calculate an index for accessing an array element of size 9.
> > This may cause a buffer overflow.
>
> The fix is to fi
From: Wayne Lin
[ Upstream commit bc068194f548ef1f230d96c4398046bf59165992 ]
[Why]
Observe after suspend/resme, we can't light up mst monitors under specific
mst hub. The reason is that driver still writes DPCD DP_MSTM_CTRL after LT.
It's forbidden even we write the same value for that dpcd regi
Add support for screen_info setups with VIDEO_TYPE_VLFB. Provide the
minimum functionality of reading modes, updating and clearing the display.
There is existing support for these displays provided by simpledrm with
CONFIG_SYSFB_SIMPLEFB=y. Using vesadrm over simpledrm will allow for the
use of ad
> devm_kasprintf() return NULL if memory allocation fails. Currently,
call? failed?
> wled_configure() does not check for this case, leading to a possible NULL
> pointer dereference.
You may omit the word “possible” in such a change description.
(W
> Cursor plane has no color pipeline and thus it has no colorop either. It
> inherits color processing from its parent plane.
Just to be sure: That means amdgpu will reject atomic commits that try
to set a color pipeline on the primary plane while showing the cursor
plane on top of it? Just like w
On 3/31/25 11:04, Shengyu Qu wrote:
Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE
property, to let userspace know that cursor plane and background plane
share the same colorop config. So that userspace could do extra
conversion on cursor image data to avoid display
Hi,
On 28/03/2025 00:52, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Wed, Mar 26, 2025 at 03:22:52PM +0200, Tomi Valkeinen wrote:
Add support for Y8 and Y10_P32 formats. We also need to add new csc
matrices for the y-only formats.
Signed-off-by: Tomi Valkeinen
---
drivers
Thanks, I mistook about the MPO document. Maybe we should also disable
colorop on the background plane of the cursor plane? So that compositors
would do sw color convertion on both cursor plane and background plane,
which should keep cursor display correctly.
在 2025/4/1 0:34, Alex Hung 写道:
From: Mark Dietzer
Similarly for the Framework 13 panels already handled in those quirks,
the 16 can be helped by the same kind of patch.
I have run this on my own 16 for multiple months (hard coding the value to
0 before the quirks made it upstream) and it has resulted in a darker
minimum brigh
On 28/03/2025 13:11, Maxime Ripard wrote:
On Thu, Mar 20, 2025 at 09:32:36AM -0300, Helen Koike wrote:
Hi Maxime,
Thanks for your reply.
On 20/03/2025 06:33, Maxime Ripard wrote:
Hi,
On Wed, Mar 19, 2025 at 02:39:59PM -0300, Helen Koike wrote:
Hi Maxime,
On 19/03/2025 11:11, Maxime Ripa
You are right. Sorry for the noise.
在 2025/4/1 0:41, Alex Hung 写道:
On 3/31/25 10:24, Shengyu Qu wrote:
在 2025/3/27 7:46, Alex Hung 写道:
From: Harry Wentland
Add documentation for color pipeline API.
Signed-off-by: Alex Hung
Signed-off-by: Harry Wentland
---
v8:
- Fix typo "definint"
On 3/31/25 10:24, Shengyu Qu wrote:
在 2025/3/27 7:46, Alex Hung 写道:
From: Harry Wentland
Add documentation for color pipeline API.
Signed-off-by: Alex Hung
Signed-off-by: Harry Wentland
---
v8:
- Fix typo "definint" -> "defining"
v7:
- Add a commit messages
v5:
- Don't require
Start moving to the new refcounted allocations using
the new API devm_drm_panel_alloc(). Deprecate any other
allocation.
Reviewed-by: Luca Ceresoli
Reviewed-by: Maxime Ripard
Signed-off-by: Anusha Srivatsa
---
v4: none.
v3: none.
v2: make the documentation changes in v1 more precise (Maxime)
-
On 3/31/25 10:31, Shengyu Qu wrote:
Sorry for vague expression. I mean that I think we shouldn't register
DRM_PLANE_TYPE_CURSOR in the driver, as we don't have actual hardware
support.
This is not true. AMD has hardware cursor support.
在 2025/4/1 0:26, Alex Hung 写道:
On 3/31/25 10:12,
Add palette support and export GAMMA properties via sysfs. User-space
compositors can use this interface for programming gamma ramps or night
mode.
Vesadrm supports palette updates via VGA DAC registers or VESA palette
calls. Up to 256 palette entries are available. Userspace always supplies
gamma
On Mon, Mar 31, 2025 at 10:09 AM Maxime Ripard wrote:
> On Sun, Mar 30, 2025 at 10:24:12PM -0400, Anusha Srivatsa wrote:
> > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> > index
> a9c042c8dea1a82ef979c7a68204e0b55483fc28..97a5457b64fbbe9c91c6a4f41b8e1fbfe4fa604e
> 100644
> > -
Sorry for vague expression. I mean that I think we shouldn't register
DRM_PLANE_TYPE_CURSOR in the driver, as we don't have actual hardware
support.
在 2025/4/1 0:26, Alex Hung 写道:
On 3/31/25 10:12, Shengyu Qu wrote:
So currently we have to hope the compositor won't use
DRM_PLANE_TYPE_CURSOR
Start using the new helper that does the refcounted
allocations.
Reviewed-by: Luca Ceresoli
Reviewed-by: Maxime Ripard
Signed-off-by: Anusha Srivatsa
---
v4: none.
v3: none.
v2: check error condition (Luca)
---
drivers/gpu/drm/panel/panel-simple.c | 9 -
1 file changed, 4 insertions(+
Introduce reference counted allocations for panels to avoid
use-after-free. The patch adds the macro devm_drm_bridge_alloc()
to allocate a new refcounted panel. Followed the documentation for
drmm_encoder_alloc() and devm_drm_dev_alloc and other similar
implementations for this purpose.
Reviewed-b
在 2025/3/27 7:46, Alex Hung 写道:
From: Harry Wentland
Add documentation for color pipeline API.
Signed-off-by: Alex Hung
Signed-off-by: Harry Wentland
---
v8:
- Fix typo "definint" -> "defining"
v7:
- Add a commit messages
v5:
- Don't require BYPASS to succeed (Sebastian)
- use DA
Enable the connector's EDID property if edid_info contains valid
data. Exports the EDID via sysfs for user-space compositors.
EDID information is not always available. Depending on the system
and kernel configuration, it is either provided by the boot loader
or read by the kernel during early boot
Allocate panel via reference counting. Add _get() and _put() helper
functions to ensure panel allocations are refcounted. Avoid use after
free by ensuring panel pointer is valid and can be usable till the last
reference is put.
Reviewed-by: Luca Ceresoli
Reviewed-by: Maxime Ripard
Signed-off-by:
The helper drm_simple_encoder_init() is a trivial helper around
drm_encoder_init() and therefore deprecated. Open-code the function
and remove the dependency.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/tiny/ofdrm.c | 7 +--
1 file changed, 5 i
So currently we have to hope the compositor won't use
DRM_PLANE_TYPE_CURSOR planes at all Why do we still register
DRM_PLANE_TYPE_CURSOR in the driver?
在 2025/4/1 0:06, Alex Hung 写道:
On 3/31/25 09:43, Shengyu Qu wrote:
Hi,
Thanks for reply. So currently we have to apply color conversio
The field nformats is unused. Remove it.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/tiny/simpledrm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index 5d9ab8adf8005..d94971
Add support for screen_info setups with VIDEO_TYPE_EFI. Provide the
minimum functionality of reading modes, updating and clearing the display.
There is existing support for these displays provided by simpledrm with
CONFIG_SYSFB_SIMPLEFB=y. Using efidrm over simpledrm will allows for the
mapping of
On 3/31/25 09:43, Shengyu Qu wrote:
Hi,
Thanks for reply. So currently we have to apply color conversion on the
background plane of the cursor to do some color space conversion. What
would happen if cursor and background plane needs different conversion
config? Or we just give the cursor a
Enable the connector's EDID property if edid_info contains valid
data. Exports the EDID via sysfs for user-space compositors.
EDID information is not always available. Depending on the system
and kernel configuration, it is either provided by the boot loader
or read by the kernel during early boot
The ofdrm and simpledrm drivers are special as they operate on
externally provided framebuffers. Move them into their own sub-
directory. Will let them share common code.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
---
MAINTAINERS | 3
Merge the connector functions of ofdrm and simpledrm. Replace the
code in each driver with the shared helpers. Set up callbacks with
initializer macros.
No effective code changes. The sysfb connector only returns the
preconfigured display mode.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Javie
Add struct drm_sysfb_device that stores the system display's hardware
settings. Further helpers for the mode-setting pipeline will use these
fields. Convert ofdrm and simpledrm by embedding the sysfb device in
their device structs.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Can
Merge the CRTC functions of ofdrm and simpledrm. Replace the code
in each driver with the shared helpers. Set up callbacks with
initializer macros.
Ofdrm supports a gamma LUT, while simpledrm does not. So far ofdrm's
LUT size has been hard-coded in the driver CRTC's atomic_check helper.
Now pass t
Move ofdrm's struct ofdrm_crtc_state plus functions to sysfb
helpers and rename everything to drm_sysfb_crtc_state.
The sysfb CRTC state is a regular CRTC state with information on
the primary plane's color format, as required for color management.
Helpers for sysfb planes will later set this up a
Merge the primary plane code of ofdrm and simpledrm. Replace the
plane implementation in each driver with the shared helpers. Set
up driver callbacks and format modifiers with initializer macros.
The plane code in ofdrm and simpledrm is very similar. Ofdrm has a
more sophisticated implementation o
Add EDID support to sysfb connector helpers. Read the EDID property
from the OF node in ofdrm. Without EDID, this does nothing.
Some systems with OF display, such as 32-bit PPC Macintoshs, provide
the system display's EDID data as node property in their DT. Exporting
this information allows compos
This series simplifies the existing ofdrm and simepldrm drivers,
and adds new drivers for EFI- and VESA-based framebuffers. Existing
drivers for system framebuffers, ofdrm and simpledrm, share much of
their mode-setting pipeline. The major difference between the two
drivers is in how they retrieve
On Fri, Mar 28, 2025 at 09:26:19PM +0530, Arun R Murthy wrote:
> All of the formats/modifiers supported by the plane during synchronous
> flips are nor supported by asynchronous flips. The formats/modifiers
> exposed to user by IN_FORMATS exposes all formats/modifiers supported by
> plane and this
On Fri, 28 Mar 2025 12:09:08 -0400
Anusha Srivatsa wrote:
> On Fri, Mar 28, 2025 at 4:54 AM Luca Ceresoli
> wrote:
>
> > On Thu, 27 Mar 2025 10:55:42 -0400
> > Anusha Srivatsa wrote:
> >
> > > Start using the new helper that does the refcounted
> > > allocations.
> > >
> > > v2: check error
On Mon, Mar 31, 2025 at 01:53:37PM +0300, Pekka Paalanen wrote:
> On Mon, 31 Mar 2025 11:21:35 +0300 Laurent Pinchart wrote:
> > On Mon, Mar 31, 2025 at 10:54:46AM +0300, Pekka Paalanen wrote:
> > > On Thu, 27 Mar 2025 17:35:39 +0100 Geert Uytterhoeven wrote:
> > > > On Thu, 27 Mar 2025 at 16:59, P
On Fri, Mar 28, 2025 at 09:26:24PM +0530, Arun R Murthy wrote:
> Async flip is not supported with Indexed 8 bit format as it depends on
> LUT and can't be updated atomically.
We should again highlight that this may change the alignment for
C8 framebuffers on some platforms.
>
> Signed-off-by: Ar
On Fri, Mar 28, 2025 at 09:26:23PM +0530, Arun R Murthy wrote:
> Hook up the newly added plane function pointer
> format_mod_supported_async to populate the modifiers/formats supported
> by asynchronous flips.
>
> v5: Correct the if condition for modifier support check (Chaitanya)
> v6: Replace ui
On Fri, Mar 28, 2025 at 09:26:22PM +0530, Arun R Murthy wrote:
> The function intel_plane_can_async_flip() checks for async supported
> modifier, add format support check also in the same function.
>
> Note: on ADL the surface base addr is required to be 16k aligned and if
> not might generate DMA
Hi,
Thanks for reply. So currently we have to apply color conversion on the
background plane of the cursor to do some color space conversion. What
would happen if cursor and background plane needs different conversion
config? Or we just give the cursor a dedicated plane?
Best regards,
Shengy
On Mon, 31 Mar 2025 at 03:17, Jani Nikula wrote:
>
> I suggest a Kconfig knob to truly make this opt-in, only for developers
> who actually want it.
So honestly, the thing I *really* hated was the horrendous naming.
I live in auto-complete. I basically never type out file-names, and I
replace ke
On 10.03.25 23:23, Kees Cook wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and correctly identify t
Hi,
On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote:
>
> @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel
> *panel)
>
> ret = boe_bf060y8m_aj0_on(boe);
> if (ret < 0) {
> - dev_err(dev, "Failed to initialize panel: %d\n", ret);
>
Thomas Zimmermann writes:
> Enable the connector's EDID property if edid_info contains valid
> data. Exports the EDID via sysfs for user-space compositors.
>
> EDID information is not always available. Depending on the system
> and kernel configuration, it is either provided by the boot loader
>
-Original Message-
From: Landwerlin, Lionel G
Sent: Monday, March 31, 2025 1:18 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
On Sun, Mar 30, 2025 at 08:31:07PM +0100, Christopher Obbard wrote:
> According to the eDP specification (VESA Embedded DisplayPort Standard
> v1.4b, Section 3.3.10.2), if the value of DP_EDP_PWMGEN_BIT_COUNT is
> less than DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, the sink is required to use
> the MIN valu
On Sun, Mar 30, 2025 at 10:24:12PM -0400, Anusha Srivatsa wrote:
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index
> a9c042c8dea1a82ef979c7a68204e0b55483fc28..97a5457b64fbbe9c91c6a4f41b8e1fbfe4fa604e
> 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
>
Hi
Am 19.03.25 um 13:50 schrieb nerdopolis:
[...]
FYI When this gets merged,
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589
might need to be updated to add exceptions for vesadrm and efidrm like there
is for simpledrm.
I am willi
1 - 100 of 156 matches
Mail list logo
