> -----Original Message----- > From: Nautiyal, Ankit K <ankit.k.nauti...@intel.com> > Sent: Tuesday, April 1, 2025 11:07 AM > To: Garg, Nemesa <nemesa.g...@intel.com>; intel-...@lists.freedesktop.org; > intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH 09/12] drm/i915/display: Set a scaler mode > > > On 3/21/2025 9:36 PM, Nemesa Garg wrote: > > Set the mode of scaler to HQ for casf. > > > > Signed-off-by: Nemesa Garg <nemesa.g...@intel.com> > > --- > > drivers/gpu/drm/i915/display/skl_scaler.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c > > b/drivers/gpu/drm/i915/display/skl_scaler.c > > index d816dae9cec4..93a847c05535 100644 > > --- a/drivers/gpu/drm/i915/display/skl_scaler.c > > +++ b/drivers/gpu/drm/i915/display/skl_scaler.c > > @@ -392,6 +392,9 @@ static int intel_atomic_setup_scaler(struct > intel_crtc_state *crtc_state, > > "Cannot find scaler for %s:%d\n", name, idx)) > > return -EINVAL; > > > > + if (casf_scaler) > > + mode = SKL_PS_SCALER_MODE_HQ; > > I am not very sure, if we need this. Couldn't find any where in the Spec. Can > you check if this is really required. > > If this is indeed required then would be better to document the reasoning. > > Regards, > > Ankit > This patch is not required. I will remove it.
Regards, Nemesa > > + > > /* set scaler mode */ > > if (plane_state && plane_state->hw.fb && > > plane_state->hw.fb->format->is_yuv &&
