On Mon, Mar 31, 2025 at 10:09 AM Maxime Ripard <mrip...@kernel.org> wrote:
> On Sun, Mar 30, 2025 at 10:24:12PM -0400, Anusha Srivatsa wrote:
> > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> > index
> a9c042c8dea1a82ef979c7a68204e0b55483fc28..97a5457b64fbbe9c91c6a4f41b8e1fbfe4fa604e
> 100644
> > --- a/include/drm/drm_panel.h
> > +++ b/include/drm/drm_panel.h
> > @@ -268,6 +268,30 @@ struct drm_panel {
> > bool enabled;
> > };
> >
> > +void *__devm_drm_panel_alloc(struct device *dev, size_t size, size_t
> offset,
> > + const struct drm_panel_funcs *funcs,
> > + int connector_type);
> > +
> > +/**
> > + * devm_drm_panel_alloc - Allocate and initialize a refcounted panel.
> > + * The reference count is initialised to 1 and is automatically given
> back
> > + * by devm action.
>
> No. I told you in my previous email that it needed to be between the
> arguments and returns
> sections ...
>
> > + * @dev: struct device of the panel device
> > + * @type: the type of the struct which contains struct &drm_panel
> > + * @member: the name of the &drm_panel within @type
> > + * @funcs: callbacks for this panel
> > + * @connector_type: the connector type (DRM_MODE_CONNECTOR_*)
> corresponding to
> > + * the panel interface
>
> ... So here, just like you did for all the other functions you introduced.
>
> Also, there's no reference counting yet, so that paragraph should be in
> your second patch.
>
Yup. this patch should just have the helper, arguments and returns.
Anything about refcounting should be in the next one.
Making this change.
Anusha
Maxime
>
