On 9/5/19 8:38 PM, Laszlo Ersek wrote:
> Section "6.2 Comments" seems to permit "/*" for multi-line comments in
> general. That's incorrect; "/*" comments are permitted only for a subset
> of multi-line comments (namely Doxygen-style file and function header
> comment blocks). Update the rule accor
Hi Laszlo,
(Cc'ing Ard)
On 9/5/19 8:38 PM, Laszlo Ersek wrote:
> Problem statement from Ard:
>
>> Sometimes, the GCC compiler warns about variables potentially being used
>> without having been initialized, while visual inspection reveals that
>> this is impossible. In such cases, we need to ini
On 9/9/19 2:25 PM, Laszlo Ersek wrote:
> On 09/06/19 10:13, Philippe Mathieu-Daudé wrote:
>> Hi Laszlo,
>>
>> (Cc'ing Ard)
>>
>> On 9/5/19 8:38 PM, Laszlo Ersek wrote:
>>> Problem statement from Ard:
>>>
>>>> Sometimes, the GC
Hi Ard,
On 9/7/19 12:20 AM, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want to
On 8/17/19 1:28 AM, Vitaly Cheptsov via Groups.Io wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048
>
> Provide a macro for compile time assertions.
> Equivalent to C11 static_assert macro from assert.h.
>
> Signed-off-by: Vitaly Cheptsov
> ---
> MdePkg/Include/Base.h | 14 ++
Hi Prince,
On 9/10/19 1:15 AM, Agyeman, Prince wrote:
> This patch series fix gcc build issues seen
> in SimicsOpenBoardPkg.
> Patches were tested on GCC 5
>
> Prince Agyeman (3):
> AdvancedFeaturePkg: Fix GCC build
> SimicsOpenBoardPkg: Fix GCC build issues
> SimicsIch10Pkg: Fix GCC build
Hi Ard,
On 9/11/19 6:23 PM, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want to
On 9/12/19 6:50 PM, Ard Biesheuvel wrote:
> On Thu, 12 Sep 2019 at 16:20, Philippe Mathieu-Daudé
> wrote:
>>
>> Hi Ard,
>>
>> On 9/11/19 6:23 PM, Ard Biesheuvel wrote:
>>> After upgrading the CI system we use for building the ArmVirtPkg
>>> targ
On 9/12/19 7:13 PM, Ard Biesheuvel wrote:
> On Thu, 12 Sep 2019 at 18:05, Philippe Mathieu-Daudé
> wrote:
>>
>> On 9/12/19 6:50 PM, Ard Biesheuvel wrote:
>>> On Thu, 12 Sep 2019 at 16:20, Philippe Mathieu-Daudé
>>> wrote:
>>>>
>>>>
On 9/12/19 6:58 PM, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want to increase
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> In the following call tree:
>
> PlatformInit ()
>mInstalledPackages = HiiAddPackages ()
> GopInstalled ()
> PopulateForm (PackageList = mInstalledPackages)
> CreateResolutionOptions (PackageList)
> HiiSetString (PackageList
>
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*).
> Fix the call in the notification function of
> "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket".
>
> This is an actual bug. The reason it's never been triggered is likely that
> the "SNP.
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> "gTimerEvent" has type EFI_EVENT already, drop the superfluous cast.
>
> Cc: Andrew Fish
> Cc: Jordan Justen
> Cc: Ray Ni
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> build-tested only
>
> EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c | 2 +-
On 9/19/19 6:03 PM, Leif Lindholm wrote:
> I have started looking into doing the CRLF->native conversion for EDK2,
> and as part of my initial scan, I found a bunch of trivial issues that
> would be easier to just fix beforehand.
>
> Mike asked me to also do a trainling whitespace cleanup, and tha
On 9/19/19 8:06 PM, Leif Lindholm wrote:
> Cc: Jordan Justen
> Cc: Andrew Fish
> Cc: Ray Ni
> Signed-off-by: Leif Lindholm
> ---
> EmulatorPkg/Readme.md | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/EmulatorPkg/Readme.md b/EmulatorPkg/Readme.md
> index 5ea61ca7a
On 9/19/19 8:06 PM, Leif Lindholm wrote:
> Cc: Ard Biesheuvel
> Signed-off-by: Leif Lindholm
> ---
> ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> b/ArmPkg/Library/ArmMmuLib/A
On 9/19/19 8:06 PM, Leif Lindholm wrote:
> Cc: Ard Biesheuvel
> Signed-off-by: Leif Lindholm
> ---
> ArmPlatformPkg/Scripts/Ds5/profile.py | 2 +-
> ArmPlatformPkg/Scripts/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/profi
On 9/19/19 8:06 PM, Leif Lindholm wrote:
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Leif Lindholm
> ---
> UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> b/UefiCpuPkg/Ap
On 9/20/19 12:24 PM, Leif Lindholm wrote:
>
> On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote:
>> On 09/19/19 20:06, Leif Lindholm wrote:
>>> Cc: Jordan Justen
>>> Cc: Laszlo Ersek
>>> Cc: Ard Biesheuvel
>>> Cc: Anthony Perard
>>> Cc: Julien Grall
>>> Cc: David Woodhouse
>>> Sig
On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> The original the of last line is '/r'. Now update it to '/r/n'.
>
> Cc: Dandan Bi
> Cc: Liming Gao
> Signed-off-by: Shenglei Zhang
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
> The v1 patch is "UserInterfaceFeatureP
On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
>
> Cc: Eric Dong
> Cc: Liming Gao
> Signed-off-by: Shenglei Zhang
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is u
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> Unlike the InstallMultipleProtocolInterfaces() boot service, which takes
> an (EFI_HANDLE*) as first parameter, the
> UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as
> first parameter.
>
> These are actual bugs. They must have rem
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration",
> similarly to gBS->RegisterProtocolNotify(). We should pass the address of
> an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT
> just happens to be specified as (VO
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The TouchFileByHandle() and IsDirectoryEmpty() functions are passed
> SHELL_FILE_HANDLE parameters, and they use those parameters correctly.
> However, their parameter lists say EFI_HANDLE.
>
> Spell out the right type in the parameter lists.
>
> In pract
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory
> Can Not Be Saved".
>
> The ShellCloseFile() function takes a (SHELL_FILE_HANDLE*) parameter
> called "FileHandle", and correctly passes the de-referenced (*FileHandle)
> to EFI_SH
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The HiiConstructConfigHdr() function takes the "DriverHandle" parameter in
> order to fetch the device path from it, and then turn the device path into
> PATH routing information.
>
> The HiiConstructConfigHdr() function is called from
> VariableCleanupHii
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> Unlike the InstallMultipleProtocolInterfaces() boot service, which takes
> an (EFI_HANDLE*) as first parameter, the
> UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as
> first parameter.
>
> This is an actual bug. It must have remai
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The last parameter of ReserveResourceInGcd() is "ImageHandle", forwarded
> in turn to gDS->AllocateMemorySpace() or gDS->AllocateIoSpace() as "owner"
> image handle.
>
> But BlDxeEntryPoint() passes "SystemTable" as "ImageHandle".
>
> Compilers have not f
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The SockFreeFoo() callback function for NetbufFromExt() has to match the
> NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument
> (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the
> SockFreeFoo() parameter list.
>
>
Hi Laszlo,
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> According to the UEFI spec -- and to the edk2 header
> "MdePkg/Include/Protocol/EdidOverride.h" too --,
> EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID takes an (EFI_HANDLE*), and not an
> EFI_HANDLE, as second parameter ("ChildHandle").
>
> This is prob
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD
> take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*).
>
> This patch fixes a real bug.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by: Laszlo Ersek
> ---
>
.
>
> Thanks,
> Guo
>
>> -Original Message-
>> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
>> Sent: Monday, September 23, 2019 8:08 AM
>> To: devel@edk2.groups.io; ler...@redhat.com
>> Cc: You, Benjamin ; Dong, Guo
>> ; Ma, Maurice
>>
On 9/18/19 5:05 AM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if the caller o
On 9/18/19 5:05 AM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if the caller o
Hi Dandan,
On 9/18/19 5:05 AM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if
On 9/18/19 5:05 AM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if the caller o
On 9/18/19 5:05 AM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if the caller o
Hi Liming,
On 9/24/19 3:19 AM, Liming Gao wrote:
> ShellBinPkg is generated for each edk2 stable tag release.
>
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Liming Gao
> ---
> Maintainers.txt | 13 ++---
> 1 file changed, 6 inserti
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> GetModuleInfoFromHandle() takes an EFI_HANDLE -- (VOID*) -- as first
> parameter, but InsertFpdtRecord() passes (EFI_HANDLE*) -- (VOID**).
> (VOID**) converts silently to (VOID*), which is why the wrong cast is
> masked.
>
> Note that the *value* that is p
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require
> the notification handle to have type (VOID*). The notification handle has
> nothing to do with the EFI_HANDLE type.
>
> This change is a semantic fix; functionally, it's a no-op.
>
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is:
>
> IN OUT EFI_HANDLE *ChildHandle
>
> - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is:
>
> IN EFI_HANDLE ChildHandle
>
> Fix the DestroyChild() call in TcpFastbootTransportStop
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> HiiGetHiiHandles() returns an array of EFI_HII_HANDLEs, not EFI_HANDLEs.
> HiiGetString() takes an EFI_HII_HANDLE, not an EFI_HANDLE.
>
> This change is a no-op in practice; it's a semantic improvement.
>
> Cc: Dandan Bi
> Cc: Eric Dong
> Cc: Hao A Wu
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require
> the notification handle to have type (VOID*). The notification handle has
> nothing to do with the EFI_HANDLE type.
>
> This change is a semantic fix; functionally, it's a no-op.
>
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> NULL-check. Fix the type of "SnpHandle".
>
> This patch is a no-op.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off
On 9/24/19 1:34 PM, Laszlo Ersek wrote:
> Before adding another SMM-related, and therefore Q35-only, dynamically
> detectable feature, extract the current board type check from
> Q35TsegMbytesInitialization() to a standalone function.
>
> Cc: Ard Biesheuvel
> Cc: Boris Ostrovsky
> Cc: Brijesh Si
On 9/24/19 1:34 PM, Laszlo Ersek wrote:
> In a subsequent patch, we'll introduce new DRAM controller macros in
> "Q35MchIch9.h". Their names are too long for the currently available
> vertical whitespace, so increase the latter first.
>
> There is no functional change in this patch ("git show -b"
On 9/24/19 3:16 PM, Dandan Bi wrote:
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if the caller o
On 9/24/19 5:08 PM, Gao, Liming wrote:
> Philipe:
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Philippe
>> Mathieu-Daudé
>> Sent: Tuesday, September 24, 2019 6:41 PM
>> To: devel@edk2.groups.io; Gao, Liming ; Leif Lindholm
&
On 9/24/19 5:17 PM, Gao, Liming wrote:
>> -Original Message-
>> From: Philippe Mathieu-Daudé
>> Sent: Tuesday, September 24, 2019 11:13 PM
>> To: Gao, Liming ; devel@edk2.groups.io; Leif Lindholm
>>
>> Cc: Andrew Fish ; Laszlo Ersek ; Kinney,
>&
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The HandleProtocol() boot service takes an EFI_HANDLE, not an
> (EFI_HANDLE*). Remove the bogus cast in the
> InternalImageHandleToFvHandle() function.
>
> This is a semantic cleanup; there is no change in behavior.
>
> Cc: Liming Gao
> Cc: Michael D Kin
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> Clean up two issues around FindFileEx():
>
> - The "AprioriFile" parameter's type differs between the function
> declaration and the function definition. The correct type is
> (EFI_PEI_FILE_HANDLE*).
>
> - "FfsFileHeader" has type (EFI_FFS_FILE_HEADER
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) --
> objects to ConvertAndConnectControllers(), and
> ConvertAndConnectControllers() passes those to gBS->OpenProtocol().
>
> Accordingly, ConvertAndConnectControllers() should specify EFI_
On 9/24/19 5:05 PM, Liming Gao wrote:
> EBC compiler doesn't support C11 static_assert macro.
> So, define STATIC_ASSERT as empty to pass EBC arch build.
> STATIC_ASSERT macro is introduced @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0
>
> Cc: Michael D Kinney
> Signed-off-by: Liming Gao
> ---
> Md
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration",
> similarly to gBS->RegisterProtocolNotify(). We should pass the address of
> an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT
> just happens to be specified as (VO
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The UefiShell*CommandsLib instances have constructor functions that do
> something like:
>
> gHiiHandle = HiiAddPackages (...);
> ...
> ShellCommandRegisterCommandName (..., gHiiHandle, ...);
>
> and destructor functions that implement the following
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Signed-off-by: Philippe Mathieu-Daude
---
StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
StandaloneMmPkg/Core/FwVol.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/StandaloneMmPk
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
b/MdeModul
An extra 's' slipped into the 'processing' word.
Drop it to fix the typo.
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6Option.c b/NetworkPkg/Ip6Dxe/Ip6Option.c
index 88111e3c24f5..
Some "processing/processed" words are written with an extra 's'.
Properly write them.
Unrelated note, I'm sending this series using git-publish with
a 'cc.cmd' script which build the Cc list of each patch calling
BaseTools/Scripts/GetMaintainer.py, appologi
AuthConfigDxe.c
> index 18ee763002b4..c0870ab9979c 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.c
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.c
> @@ -39,7 +39,7 @@ TlsAuthConfigDxeUnload (
>ASSERT (PrivateData->Signature == TLS_AUTH_CONFIG_PRIVATE_DATA_SIGNATURE);
>
>gB
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> (This patch is unrelated to the rest of this series; its purpose is to
> enable building the UefiPayloadPkg DSC files with GCC.)
>
> When building "UefiPayloadPkg/UefiPayloadPkgIa32.dsc" with GCC48 for the
> DEBUG target, the compiler reports that "Entry32
On 9/27/19 2:23 AM, Liming Gao wrote:
> ShellBinPkg is generated for each edk2 stable tag release.
>
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Liming Gao
> ---
> In v2, use real URL for edk2 release
> Maintainers.txt | 15 ---
On 9/27/19 4:30 AM, Bob Feng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221
>
> The command used by multiple thread genffs feature in makefile
> for testing if file exist is generated based on the toolchain family.
> It should be based on the OS type.
>
> Cc: Liming Gao
> Sign
On 9/26/19 9:28 PM, Leif Lindholm wrote:
> The AArch64 definitions of UINT64/INT64 differ from the X64 ones.
> Since this is on the tool side, doing like X64 and picking the
> definitions from stdint.h feels like a better idea than hardcoding
> them. So copy the pattern from X64/ProcesorBind.h.
Ty
Hi Liming,
On 9/27/19 9:46 AM, Liming Gao wrote:
> Signed-off-by: Liming Gao
> ---
> BaseTools/Conf/build_rule.template | 26 +--
> BaseTools/Conf/tools_def.template | 102
> +
> 2 files changed, 118 insertions(+), 10 deletio
On 9/27/19 9:46 AM, Liming Gao wrote:
> Signed-off-by: Liming Gao
> ---
> BaseTools/Source/C/GenFw/GenFw.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/GenFw/GenFw.c
> b/BaseTools/Source/C/GenFw/GenFw.c
> index c99782b78e..d8d3360c24 100644
Hi Pete,
On 9/27/19 11:20 AM, Pete Batard wrote:
> From: Andrei Warkentin
>
> The Pi GPU decouples requested resolution from actual physical resolution
> and can perform scaling of virtual resolutions. This enables platform users
> to do something like ask for 1024x768 and get a framebuffer of t
On 9/27/19 7:49 PM, Leif Lindholm wrote:
> On Fri, Sep 27, 2019 at 06:38:07PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Pete,
>>
>> On 9/27/19 11:20 AM, Pete Batard wrote:
>>> From: Andrei Warkentin
>>>
>>> The Pi GPU decouples requested resolu
On 9/30/19 10:16 PM, Laszlo Ersek wrote:
Hi Phil,
On 09/26/19 14:42, Philippe Mathieu-Daudé wrote:
Hi Laszlo,
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
Both the "ControllerHandle" parameter of CloseProtocol()
Maybe worth adding "of type EFI_CLOSE_PROTOCOL"
and the &
On 9/23/19 2:31 AM, Abner Chang wrote:
Implement RISC-V cache maintenance functions in
BaseCacheMaintenanceLib.
Signed-off-by: Abner Chang
---
.../BaseCacheMaintenanceLib.inf| 4 +
.../Library/BaseCacheMaintenanceLib/RiscVCache.c | 250 +
2 files
Hi Leif,
On 9/27/19 1:39 AM, Leif Lindholm wrote:
On Mon, Sep 23, 2019 at 08:31:35AM +0800, Abner Chang wrote:
RISC-V MMIO library instance. RISC-V only supports memory map I/O.
We need fewer, not more, C implementations of MMIO accessors.
While this set doesn't need to wait for upstream to
kages were only searched into
$PACKAGES_PATH (which did not change).
Anyhow I'll adapt my setup and not use edk2/ as $WORKSPACE anymore.
Thanks for the pointers,
Phil.
On 2019.09.27 21:23, Philippe Mathieu-Daudé wrote:
On 9/27/19 7:49 PM, Leif Lindholm wrote:
On Fri, Sep 27, 2019 at 06:38:
On 10/1/19 3:10 PM, Leif Lindholm wrote:
On Mon, Sep 30, 2019 at 10:32:03AM +0100, Pete Batard wrote:
Hi Leif,
On 2019.09.29 00:05, Leif Lindholm wrote:
On Fri, Sep 27, 2019 at 10:20:15AM +0100, Pete Batard wrote:
From: Andrei Warkentin
The Pi GPU decouples requested resolution from actual
On 10/2/19 9:40 AM, Nate DeSimone wrote:
The GalagoPro3 platform in KabylakeOpenBoardPkg is using the
instance of PlatformSecLib in MinPlatformPkg instead of the
instance in KabylakeOpenBoardPkg. The version in MinPlatformPkg
does not support FSP 2.1 Dispatch Mode, whearas the version in
typo:
On 10/8/19 1:27 PM, Laszlo Ersek wrote:
PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are
only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen does
not include that module. Remove the unnecessary dynamic PCD defaults from
"OvmfXen.dsc".
Cc: Anthony Perard
On 10/9/19 2:00 PM, Leif Lindholm wrote:
Synchronize header with edk2/Maintainers.txt and change references
from "EDK II to EDK II Platforms".
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 42 +-
1 file ch
On 10/9/19 2:00 PM, Leif Lindholm wrote:
The ',' character, when used in the name part of email addresses,
must be escaped. Not doing so leads to all kinds of fun with SMTP.
So rework all M: entries containing a , to not do so.
Oh, good tip!
Cc: Ard Bieshuevel
Cc: Michael D Kinney
Signed-of
On 10/9/19 2:00 PM, Leif Lindholm wrote:
Cc: Marcin Wojtas
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 43803592d369..56b12dd79c3f 100644
--- a/Maintainers.txt
+++
On 10/9/19 2:00 PM, Leif Lindholm wrote:
Many of the original (ARM) platforms, and drivers brought in for them,
had no explicit maintainership defined. Add entries for these, roughly
corresponding to how they have already been handled in the past.
Cc: Ard Bieshuevel
Cc: Michael D Kinney
Signed
On 10/9/19 2:54 PM, Leif Lindholm wrote:
On Wed, Oct 09, 2019 at 02:51:38PM +0200, Philippe Mathieu-Daudé wrote:
On 10/9/19 2:00 PM, Leif Lindholm wrote:
Synchronize header with edk2/Maintainers.txt and change references
from "EDK II to EDK II Platforms".
Cc: Ard Biesheuvel
Cc:
On 10/9/19 3:16 PM, Leif Lindholm wrote:
On Wed, Oct 09, 2019 at 02:53:34PM +0200, Philippe Mathieu-Daudé wrote:
On 10/9/19 2:00 PM, Leif Lindholm wrote:
The ',' character, when used in the name part of email addresses,
must be escaped. Not doing so leads to all kinds of fun wit
Hi Zhang,
On 10/14/19 5:14 AM, Zhang, Shenglei wrote:
After the expression,
'CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
^ This is one change, ...
Besides the boundary check should be mor
On 10/14/19 8:35 AM, Gao, Zhichao wrote:
Refer to CSS 5.2.2.6 Always put space before an open parenthesis.
FreePool(AsciiBuffer); should be FreePool (AsciiBuffer);
After address that, Reviewed-by: Zhichao Gao
Thanks,
Zhichao
-Original Message-
From: Zhang, Shenglei
Sent: Monday, Octob
Hi Zhang,
On 10/12/19 9:43 AM, Zhang, Shenglei wrote:
The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless
if Index < 0. So 'Index < 0' should be performed first in the if statement.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/Library/Dxe
On 10/11/19 5:24 PM, Pete Batard wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
Independently of how we decide to address other aspects of the regression
introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it doesn't
make much sense to call for a progress update if P
On 10/11/19 1:07 PM, Pete Batard wrote:
This patch introduces the capability to also query the Model Name/
Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware
protocol. This is aims at making the driver more suitable to cater
for platforms other than the Raspberry Pi 3 as well as s
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b) and doubling in size for each value.
Signed-off-by: Pete Batard
Reviewe
On 10/14/19 1:44 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the
On 10/14/19 2:03 PM, Pete Batard wrote:
On 2019.10.14 12:53, Philippe Mathieu-Daudé wrote:
On 10/14/19 1:44 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use
On 10/14/19 5:03 PM, Pete Batard wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
Independently of how we decide to address other aspects of the regression
introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it doesn't
make much sense to call for a progress update if P
On 10/14/19 5:03 PM, Pete Batard wrote:
Similar to what we now do for OVMF, we need to consider the possibility
that PlatformBootManagerWaitCallback () may be called with a
PcdPlatformBootTimeOut that was set to zero, in which case the call should
simply return.
Oh I forgot this one, good catch
On 10/15/19 2:26 AM, Liming Gao wrote:
Signed-off-by: Liming Gao
---
BaseTools/Source/C/GenFw/GenFw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c
index c99782b78e..d8d3360c24 100644
--- a/BaseT
On 10/15/19 2:26 AM, Liming Gao wrote:
__inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5
toolchains, but it breaks the build with CLANG9. Remove __inline__.
I never understod how the compiler can optimize inlining such functions,
and always considered this behavior b
Hi Liming,
On 10/15/19 2:26 AM, Liming Gao wrote:
Disable warning reported from CLANG9.
Signed-off-by: Liming Gao
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 +
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 +
On 10/15/19 2:26 AM, Liming Gao wrote:
With this change, global variable _fltused will not be removed by LTO
Signed-off-by: Liming Gao
---
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/Intrin
On 10/15/19 2:26 AM, Liming Gao wrote:
CLANG9 tool chain defines __clang__ macro only,
doesn't define __GNUC__ macro. But, it uses some same definitions with GCC.
So, update base definition for CLANG9 tool chain.
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 6 +++---
M
On 1/14/20 5:37 PM, Ard Biesheuvel wrote:
On Tue, 14 Jan 2020 at 17:32, Leif Lindholm wrote:
I changed jobs at the turn of the year and now work for NUVIA
(https://nuviainc.com/). My employer would like me to continue working
on TianoCore, so let's just update the address to my current one.
I
On 1/10/20 12:25 AM, Laszlo Ersek wrote:
In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when
CPU supports", 2019-07-12), the Page Directory Entry setting was regressed
(corrupted) when splitting a 2MB page to 512 4KB pages, in the
InitPaging() function.
Consider the followin
On 1/14/20 9:27 PM, Laszlo Ersek wrote:
CC Phil
On 01/14/20 17:32, Leif Lindholm wrote:
Leif now works at NUVIA Inc, update email address accordingly.
Cc: Andrew Fish
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Leif Lindholm
Signed-off-by: Lei
1 - 100 of 1052 matches
Mail list logo
