On 1/14/20 9:27 PM, Laszlo Ersek wrote:
CC Phil

On 01/14/20 17:32, Leif Lindholm wrote:
Leif now works at NUVIA Inc, update email address accordingly.

Cc: Andrew Fish <af...@apple.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Cc: Zhichao Gao <zhichao....@intel.com>
Cc: Leif Lindholm <l...@nuviainc.com>
Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>
---
  Maintainers.txt | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

For this patch:

Reviewed-by: Laszlo Ersek <ler...@redhat.com>

Phil, would it make sense for us to ask Leif to post an update to
".mailmap"?

For example, what happens if we run "git shortlog" over a period that
contains patches authored by *both* of Leif's email addresses? Would
those entries be merged into a single block? Would such a merging be
desirable (that's for Leif to decide / propose)?

One use of .mailmap is to clean/unify the NAME part.
In this case Leif isn't affected because his NAME is the same.

The other use is to redirect email when a user switch email. When fixing/referring old commit, some email tools might take the old commit author/committer. In this case .mailmap helps. I think it is desirable in Leif particular case.

If he agrees the maintainer pushing his patch can amend this snippet:

-- >8 --
diff --git a/.mailmap b/.mailmap
index ae179b0886c7..bbf3052aa3aa 100644
--- a/.mailmap
+++ b/.mailmap
@@ -37,6 +37,7 @@ Jim Dailey <jim.dai...@dell.com>
 Jim Dailey <jim.dai...@dell.com> <jim_dai...@dell.com>
Laszlo Ersek <ler...@redhat.com> <lersek@6f19259b-4bc3-4df7-8a09-765794883524>
 Laszlo Ersek <ler...@redhat.com> <lersek@Edk2>
+Leif Lindholm <l...@nuviainc.com> <leif.lindh...@linaro.org>
 Liming Gao <liming....@intel.com> <Gao, Liming liming....@intel.com>
Liming Gao <liming....@intel.com> <lgao4@6f19259b-4bc3-4df7-8a09-765794883524>
 Liming Gao <liming....@intel.com> <lgao4@Edk2>
---

Note he stays close to you and Liming ;)


Right now, Leif is not listed in ".mailmap" -- probably because there is
exactly one email address associated with his authorship, all across the
project history. But that's what's changing now, isn't it?

Thanks,
Laszlo



diff --git a/Maintainers.txt b/Maintainers.txt
index 146d8aca93f0..ca9da2892534 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -70,7 +70,7 @@ Tianocore Stewards
  F: *
  M: Andrew Fish <af...@apple.com>
  M: Laszlo Ersek <ler...@redhat.com>
-M: Leif Lindholm <leif.lindh...@linaro.org>
+M: Leif Lindholm <l...@nuviainc.com>
  M: Michael D Kinney <michael.d.kin...@intel.com>
Responsible Disclosure, Reporting Security Issues
@@ -87,7 +87,7 @@ UEFI Shell Binaries (ShellBinPkg.zip) from EDK II Releases:
  W: https://github.com/tianocore/edk2/releases/
  M: Ray Ni <ray...@intel.com>                  (Ia32/X64)
  M: Zhichao Gao <zhichao....@intel.com>        (Ia32/X64)
-M: Leif Lindholm <leif.lindh...@linaro.org>   (ARM/AArch64)
+M: Leif Lindholm <l...@nuviainc.com>          (ARM/AArch64)
  M: Ard Biesheuvel <ard.biesheu...@linaro.org> (ARM/AArch64)
EDK II Architectures:
@@ -95,7 +95,7 @@ EDK II Architectures:
  ARM, AARCH64
  F: */AArch64/
  F: */Arm/
-M: Leif Lindholm <leif.lindh...@linaro.org>
+M: Leif Lindholm <l...@nuviainc.com>
  M: Ard Biesheuvel <ard.biesheu...@linaro.org>
EDK II Continuous Integration:
@@ -126,13 +126,13 @@ EDK II Packages:
  ArmPkg
  F: ArmPkg/
  W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPkg
-M: Leif Lindholm <leif.lindh...@linaro.org>
+M: Leif Lindholm <l...@nuviainc.com>
  M: Ard Biesheuvel <ard.biesheu...@linaro.org>
ArmPlatformPkg
  F: ArmPlatformPkg/
  W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg
-M: Leif Lindholm <leif.lindh...@linaro.org>
+M: Leif Lindholm <l...@nuviainc.com>
  M: Ard Biesheuvel <ard.biesheu...@linaro.org>
ArmVirtPkg
@@ -140,7 +140,7 @@ F: ArmVirtPkg/
  W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
  M: Laszlo Ersek <ler...@redhat.com>
  M: Ard Biesheuvel <ard.biesheu...@linaro.org>
-R: Leif Lindholm <leif.lindh...@linaro.org>
+R: Leif Lindholm <l...@nuviainc.com>
ArmVirtPkg: modules used on Xen
  F: ArmVirtPkg/ArmVirtXen.*
@@ -173,7 +173,7 @@ M: Alexei Fedorov <alexei.fedo...@arm.com>
  EmbeddedPkg
  F: EmbeddedPkg/
  W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
-M: Leif Lindholm <leif.lindh...@linaro.org>
+M: Leif Lindholm <l...@nuviainc.com>
  M: Ard Biesheuvel <ard.biesheu...@linaro.org>
EmulatorPkg




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53313): https://edk2.groups.io/g/devel/message/53313
Mute This Topic: https://groups.io/mt/69696909/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to