On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > This is an actual bug. It must have remained hidden until now because it's > on an error path. Fix the UninstallMultipleProtocolInterfaces() call. > > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Julien Grall <julien.gr...@arm.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > build-tested only > > OvmfPkg/XenBusDxe/XenBus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/XenBusDxe/XenBus.c b/OvmfPkg/XenBusDxe/XenBus.c > index bb8ddbc4d44d..2451e58a5961 100644 > --- a/OvmfPkg/XenBusDxe/XenBus.c > +++ b/OvmfPkg/XenBusDxe/XenBus.c > @@ -210,7 +210,7 @@ XenBusAddDevice ( > > ErrorOpenProtocolByChild: > gBS->UninstallMultipleProtocolInterfaces ( > - &Private->Handle, > + Private->Handle, > &gEfiDevicePathProtocolGuid, Private->DevicePath, > &gXenBusProtocolGuid, &Private->XenBusIo, > NULL); >
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47854): https://edk2.groups.io/g/devel/message/47854 Mute This Topic: https://groups.io/mt/34180223/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
